Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-11 Thread Anand Jain
 If the old btrfs is over written with newer btrfs SB, and if mkfs.btrfs  is not overwriting all the copies of SB then its a mkfs.btrfs bug. Nope. If the new btrfs is a smaller one than original btrfs, the 2nd super can still be there. Oh right, the mkfs.btrfs -b option, where we

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 22:02, Anand Jain wrote: > > > On 12/08/2017 08:51 PM, Austin S. Hemmelgarn wrote: >> On 2017-12-08 02:57, Anand Jain wrote: >>> -EXPERIMENTAL- >>> As of now when primary SB fails we won't self heal and would fail mount, >>> this is an experimental patch which thinks why not go

RE: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Paul Jones
t: Re: [PATCH RFC] btrfs: self heal from SB fail > > On 2017-12-08 02:57, Anand Jain wrote: > > -EXPERIMENTAL- > > As of now when primary SB fails we won't self heal and would fail > > mount, this is an experimental patch which thinks why not go and read > > backup copy

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 08:51 PM, Austin S. Hemmelgarn wrote: On 2017-12-08 02:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy. I like the concept, and actually think

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 21:05, Austin S. Hemmelgarn wrote: > On 2017-12-08 07:59, Qu Wenruo wrote: >> >> >> On 2017年12月08日 20:51, Austin S. Hemmelgarn wrote: >>> On 2017-12-08 02:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount,

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Austin S. Hemmelgarn
On 2017-12-08 07:59, Qu Wenruo wrote: On 2017年12月08日 20:51, Austin S. Hemmelgarn wrote: On 2017-12-08 02:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy.

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 08:12 PM, Nikolay Borisov wrote: On 8.12.2017 12:33, Anand Jain wrote: On 12/08/2017 04:40 PM, Nikolay Borisov wrote: On  8.12.2017 09:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 20:51, Austin S. Hemmelgarn wrote: > On 2017-12-08 02:57, Anand Jain wrote: >> -EXPERIMENTAL- >> As of now when primary SB fails we won't self heal and would fail mount, >> this is an experimental patch which thinks why not go and read backup >> copy. > I like the concept, and

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 20:41, Anand Jain wrote: > > > On 12/08/2017 08:02 PM, Qu Wenruo wrote: >> >> >> On 2017年12月08日 19:48, Anand Jain wrote: >>> >>> >>> On 12/08/2017 07:01 PM, Qu Wenruo wrote: On 2017年12月08日 18:39, Anand Jain wrote: > > > On 12/08/2017 04:17 PM, Qu

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Austin S. Hemmelgarn
On 2017-12-08 02:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy. I like the concept, and actually think this should be default behavior on a filesystem

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 08:02 PM, Qu Wenruo wrote: On 2017年12月08日 19:48, Anand Jain wrote: On 12/08/2017 07:01 PM, Qu Wenruo wrote: On 2017年12月08日 18:39, Anand Jain wrote: On 12/08/2017 04:17 PM, Qu Wenruo wrote: On 2017年12月08日 15:57, Anand Jain wrote: -EXPERIMENTAL- As of now when

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Hans van Kranenburg
On 12/08/2017 09:17 AM, Qu Wenruo wrote: > > > On 2017年12月08日 15:57, Anand Jain wrote: >> -EXPERIMENTAL- >> As of now when primary SB fails we won't self heal and would fail mount, >> this is an experimental patch which thinks why not go and read backup >> copy. > > Just curious about in which

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Nikolay Borisov
On 8.12.2017 12:33, Anand Jain wrote: > > > On 12/08/2017 04:40 PM, Nikolay Borisov wrote: >> >> >> On  8.12.2017 09:57, Anand Jain wrote: >>> -EXPERIMENTAL- >>> As of now when primary SB fails we won't self heal and would fail mount, >>> this is an experimental patch which thinks why not go

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 19:48, Anand Jain wrote: > > > On 12/08/2017 07:01 PM, Qu Wenruo wrote: >> >> >> On 2017年12月08日 18:39, Anand Jain wrote: >>> >>> >>> On 12/08/2017 04:17 PM, Qu Wenruo wrote: On 2017年12月08日 15:57, Anand Jain wrote: > -EXPERIMENTAL- > As of now when primary

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 07:01 PM, Qu Wenruo wrote: On 2017年12月08日 18:39, Anand Jain wrote: On 12/08/2017 04:17 PM, Qu Wenruo wrote: On 2017年12月08日 15:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 18:39, Anand Jain wrote: > > > On 12/08/2017 04:17 PM, Qu Wenruo wrote: >> >> >> On 2017年12月08日 15:57, Anand Jain wrote: >>> -EXPERIMENTAL- >>> As of now when primary SB fails we won't self heal and would fail mount, >>> this is an experimental patch which thinks why not go and

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 04:17 PM, Qu Wenruo wrote: On 2017年12月08日 15:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy. Just curious about in which real world case

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Anand Jain
On 12/08/2017 04:40 PM, Nikolay Borisov wrote: On 8.12.2017 09:57, Anand Jain wrote: -EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy. Signed-off-by: Anand Jain

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Nikolay Borisov
On 8.12.2017 09:57, Anand Jain wrote: > -EXPERIMENTAL- > As of now when primary SB fails we won't self heal and would fail mount, > this is an experimental patch which thinks why not go and read backup > copy. > > Signed-off-by: Anand Jain > --- > fs/btrfs/disk-io.c |

Re: [PATCH RFC] btrfs: self heal from SB fail

2017-12-08 Thread Qu Wenruo
On 2017年12月08日 15:57, Anand Jain wrote: > -EXPERIMENTAL- > As of now when primary SB fails we won't self heal and would fail mount, > this is an experimental patch which thinks why not go and read backup > copy. Just curious about in which real world case that backup super block can help. At

[PATCH RFC] btrfs: self heal from SB fail

2017-12-07 Thread Anand Jain
-EXPERIMENTAL- As of now when primary SB fails we won't self heal and would fail mount, this is an experimental patch which thinks why not go and read backup copy. Signed-off-by: Anand Jain --- fs/btrfs/disk-io.c | 8 +++- fs/btrfs/volumes.c | 10 +++--- 2 files