Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-09-23 Thread Qu Wenruo
David Sterba wrote on 2015/09/22 17:07 +0200: On Mon, Aug 31, 2015 at 09:13:29AM +0800, Qu Wenruo wrote: That's the wrong interface to use for such actions. But IMHO, deduplication is much like compression, we only need to execution extra hook to handle data at run_delalloc_range(). It is,

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-09-22 Thread David Sterba
On Mon, Aug 31, 2015 at 09:13:29AM +0800, Qu Wenruo wrote: > > That's the wrong interface to use for such actions. > > > But IMHO, deduplication is much like compression, we only need to > execution extra hook to handle data at run_delalloc_range(). It is, but the filesystem-wide compression alre

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-08-30 Thread Qu Wenruo
David Sterba wrote on 2015/08/27 11:14 +0200: On Mon, Aug 03, 2015 at 03:18:55PM +0800, Qu Wenruo wrote: Implement details includes the following: 1) LRU hash maps to limit the memory usage The hash -> extent mapping is control by LRU (or unlimited), to get a controllable memory usag

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-08-27 Thread David Sterba
On Mon, Aug 03, 2015 at 03:18:55PM +0800, Qu Wenruo wrote: > >> Implement details includes the following: > >> 1) LRU hash maps to limit the memory usage > >> The hash -> extent mapping is control by LRU (or unlimited), to > >> get a controllable memory usage (can be tuned by mount option)

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-08-26 Thread Qu Wenruo
Qu Wenruo wrote on 2015/08/03 15:18 +0800: David Sterba wrote on 2015/07/28 16:50 +0200: On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. What's the reason to st

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-08-03 Thread Qu Wenruo
David Sterba wrote on 2015/07/28 16:50 +0200: On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. What's the reason to start another implementation? [[CORE FEATURES]

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Liu Bo
On Wed, Jul 29, 2015 at 09:47:12AM +0800, Qu Wenruo wrote: > First, thanks David for the review. > > David Sterba wrote on 2015/07/28 16:50 +0200: > >On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: > >>Although Liu Bo has already submitted a V10 version of his deduplication > >>implemen

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Qu Wenruo
Liu Bo wrote on 2015/07/28 17:52 +0800: On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. [[CORE FEATURES]] The main design concept is the following: 1) Controllable

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Qu Wenruo
First, thanks David for the review. David Sterba wrote on 2015/07/28 16:50 +0200: On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. What's the reason to start another

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Chris Mason
On Tue, Jul 28, 2015 at 04:50:21PM +0200, David Sterba wrote: > On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: > > Although Liu Bo has already submitted a V10 version of his deduplication > > implement, here is another implement for it. > > What's the reason to start another implementa

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread David Sterba
On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: > Although Liu Bo has already submitted a V10 version of his deduplication > implement, here is another implement for it. What's the reason to start another implementation? > [[CORE FEATURES]] > The main design concept is the following: >

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Liu Bo
On Tue, Jul 28, 2015 at 04:30:36PM +0800, Qu Wenruo wrote: > Although Liu Bo has already submitted a V10 version of his deduplication > implement, here is another implement for it. > > [[CORE FEATURES]] > The main design concept is the following: > 1) Controllable memory usage > 2) No guarantee to

[PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Qu Wenruo
Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. [[CORE FEATURES]] The main design concept is the following: 1) Controllable memory usage 2) No guarantee to dedup every duplication. 3) No on-disk format change or new format 4) Pa

Re: [PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Qu Wenruo
Oh, there seems to be something wrong with the internal mail server. The codes and patches can also get from github, as only the first 4 patches are successfully sent... https://github.com/adam900710/linux/tree/dedup Thanks, Qu Qu Wenruo wrote on 2015/07/28 16:30 +0800: Although Liu Bo has

[PATCH RFC 00/14] Yet Another In-band(online) deduplication implement

2015-07-28 Thread Qu Wenruo
Although Liu Bo has already submitted a V10 version of his deduplication implement, here is another implement for it. [[CORE FEATURES]] The main design concept is the following: 1) Controllable memory usage 2) No guarantee to dedup every duplication. 3) No on-disk format change or new format 4) Pa