Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-30 Thread Liu Bo
On Mon, Oct 16, 2017 at 11:53:08AM +0300, Nikolay Borisov wrote: > > > On 13.10.2017 23:51, Liu Bo wrote: > > On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: > >> > >> > >> On 10.10.2017 20:53, Liu Bo wrote: > >>> We've avoided data losing raid profile when doing balance, but it

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-16 Thread Liu Bo
On Mon, Oct 16, 2017 at 12:22:44PM +0800, Anand Jain wrote: > > > On 10/14/2017 04:51 AM, Liu Bo wrote: > >On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: > >> > >> > >>On 10.10.2017 20:53, Liu Bo wrote: > >>>We've avoided data losing raid profile when doing balance, but it > >>>

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-16 Thread Nikolay Borisov
On 13.10.2017 23:51, Liu Bo wrote: > On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: >> >> >> On 10.10.2017 20:53, Liu Bo wrote: >>> We've avoided data losing raid profile when doing balance, but it >>> turns out that deleting a device could also result in the same >>> problem >>

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-15 Thread Anand Jain
On 10/14/2017 04:51 AM, Liu Bo wrote: On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: On 10.10.2017 20:53, Liu Bo wrote: We've avoided data losing raid profile when doing balance, but it turns out that deleting a device could also result in the same problem This fixes the

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-13 Thread Liu Bo
On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: > > > On 10.10.2017 20:53, Liu Bo wrote: > > We've avoided data losing raid profile when doing balance, but it > > turns out that deleting a device could also result in the same > > problem > > > > This fixes the problem by creatin

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-11 Thread Nikolay Borisov
On 10.10.2017 20:53, Liu Bo wrote: > We've avoided data losing raid profile when doing balance, but it > turns out that deleting a device could also result in the same > problem > > This fixes the problem by creating an empty data chunk before > relocating the data chunk. Why is this needed - c

[PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-10 Thread Liu Bo
We've avoided data losing raid profile when doing balance, but it turns out that deleting a device could also result in the same problem. This fixes the problem by creating an empty data chunk before relocating the data chunk. Metadata/System chunk are supposed to have non-zero bytes all the time