Re: [PATCH v2 0/9] free space B-tree

2015-09-22 Thread David Sterba
On Fri, Sep 11, 2015 at 09:21:13AM +0800, Qu Wenruo wrote: > Also, it should provide a quite good base for rework inode cache for > future development. You mean what's now under 'inode_cache' mount option? It builds on the free space cache infrastructure so it would be natural to use it as well.

Re: [PATCH v2 0/9] free space B-tree

2015-09-10 Thread Omar Sandoval
On Fri, Sep 11, 2015 at 11:58:13AM +0800, Qu Wenruo wrote: > > > Omar Sandoval wrote on 2015/09/10 20:48 -0700: > >On Fri, Sep 11, 2015 at 09:21:13AM +0800, Qu Wenruo wrote: > >>Hi Omar, > >> > >>Thanks for your patchset. > >>Quite a nice one, and debug-tree can give better output on space cache.

Re: [PATCH v2 0/9] free space B-tree

2015-09-10 Thread Qu Wenruo
Omar Sandoval wrote on 2015/09/10 20:48 -0700: On Fri, Sep 11, 2015 at 09:21:13AM +0800, Qu Wenruo wrote: Hi Omar, Thanks for your patchset. Quite a nice one, and debug-tree can give better output on space cache. With current implement, space cache is near a black box in debug-tree output. A

Re: [PATCH v2 0/9] free space B-tree

2015-09-10 Thread Omar Sandoval
On Fri, Sep 11, 2015 at 09:21:13AM +0800, Qu Wenruo wrote: > Hi Omar, > > Thanks for your patchset. > Quite a nice one, and debug-tree can give better output on space cache. > With current implement, space cache is near a black box in debug-tree > output. > > And current on disk format is not qui

Re: [PATCH v2 0/9] free space B-tree

2015-09-10 Thread Qu Wenruo
Hi Omar, Thanks for your patchset. Quite a nice one, and debug-tree can give better output on space cache. With current implement, space cache is near a black box in debug-tree output. And current on disk format is not quite easy to understand.(In fact, space cache is restored in tree root, a

Re: [PATCH v2 0/9] free space B-tree

2015-09-03 Thread Omar Sandoval
tember 04, 2015 3:44 AM > > To: linux-btrfs@vger.kernel.org > > Cc: Omar Sandoval > > Subject: [PATCH v2 0/9] free space B-tree > > > > Here's version 2 of the the free space B-tree patches, addressing Josef's > > review > > from the last

RE: [PATCH v2 0/9] free space B-tree

2015-09-03 Thread Zhao Lei
fs@vger.kernel.org > Cc: Omar Sandoval > Subject: [PATCH v2 0/9] free space B-tree > > Here's version 2 of the the free space B-tree patches, addressing Josef's > review > from the last round, which you can find here: > http://www.spinics.net/lists/linux-btrfs/msg46713

[PATCH v2 0/9] free space B-tree

2015-09-03 Thread Omar Sandoval
Here's version 2 of the the free space B-tree patches, addressing Josef's review from the last round, which you can find here: http://www.spinics.net/lists/linux-btrfs/msg46713.html Changes from v1->v2: - Cleaned up a bunch of unnecessary instances of "if (ret) goto out; ret = 0" - Added aborts i