Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-18 Thread Liu Bo
On Wed, May 17, 2017 at 06:07:42PM +0300, Nikolay Borisov wrote: > Currently the struct space_info creation code is intermixed in the > udpate_space_info function. There are well-defined points at which the we > actually want to create brand-new space_info structs (e.g. during mount of > the

Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Noah Massey
On Wed, May 17, 2017 at 4:55 PM, Jeff Mahoney wrote: > On 5/17/17 4:52 PM, Noah Massey wrote: >> On Wed, May 17, 2017 at 4:34 PM, Nikolay Borisov wrote: >>> >>> >>> On 17.05.2017 21:57, Noah Massey wrote: On Wed, May 17, 2017 at 11:07 AM, Nikolay Borisov

Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Jeff Mahoney
On 5/17/17 4:52 PM, Noah Massey wrote: > On Wed, May 17, 2017 at 4:34 PM, Nikolay Borisov wrote: >> >> >> On 17.05.2017 21:57, Noah Massey wrote: >>> On Wed, May 17, 2017 at 11:07 AM, Nikolay Borisov wrote: Currently the struct space_info creation code

Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Noah Massey
On Wed, May 17, 2017 at 4:34 PM, Nikolay Borisov wrote: > > > On 17.05.2017 21:57, Noah Massey wrote: >> On Wed, May 17, 2017 at 11:07 AM, Nikolay Borisov wrote: >>> Currently the struct space_info creation code is intermixed in the >>> udpate_space_info

Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Nikolay Borisov
On 17.05.2017 21:57, Noah Massey wrote: > On Wed, May 17, 2017 at 11:07 AM, Nikolay Borisov wrote: >> Currently the struct space_info creation code is intermixed in the >> udpate_space_info function. There are well-defined points at which the we > > ^^^ update_space_info >

Re: [PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Noah Massey
On Wed, May 17, 2017 at 11:07 AM, Nikolay Borisov wrote: > Currently the struct space_info creation code is intermixed in the > udpate_space_info function. There are well-defined points at which the we ^^^ update_space_info > actually want to create brand-new space_info

[PATCH v2 1/2] btrfs: Separate space_info create/update

2017-05-17 Thread Nikolay Borisov
Currently the struct space_info creation code is intermixed in the udpate_space_info function. There are well-defined points at which the we actually want to create brand-new space_info structs (e.g. during mount of the filesystem as well as sometimes when adding/initialising new chunks). In such