Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-12 Thread Helmut Hullen
Hallo, Chris, Du meintest am 12.11.10: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of it taking 12 hours to balance a non-trivial amount of data I suspect putting this operation into the background by default and

Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-12 Thread Sander
Chris Samuel wrote (ao): On 12/11/10 12:33, Li Zefan wrote: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of it taking 12 hours to balance a non-trivial amount of data I suspect putting this operation into the

Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-12 Thread Andreas Philipp
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12.11.2010 10:07, Sander wrote: Chris Samuel wrote (ao): On 12/11/10 12:33, Li Zefan wrote: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of it taking 12 hours to

Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-12 Thread Hugo Mills
On Fri, Nov 12, 2010 at 03:28:08PM +1100, Chris Samuel wrote: On 12/11/10 12:33, Li Zefan wrote: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of it taking 12 hours to balance a non-trivial amount of data I

Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-12 Thread Hugo Mills
On Fri, Nov 12, 2010 at 11:36:55AM +, Hugo Mills wrote: On Fri, Nov 12, 2010 at 03:28:08PM +1100, Chris Samuel wrote: On 12/11/10 12:33, Li Zefan wrote: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of

[PATCH v2 2/2] Cancel filesystem balance.

2010-11-11 Thread Hugo Mills
This patch adds an ioctl for cancelling a btrfs balance operation mid-flight. The ioctl simply sets a flag, and the operation terminates after the current block group move has completed. Signed-off-by: Hugo Mills h...@carfax.org.uk --- fs/btrfs/ctree.h |1 + fs/btrfs/ioctl.c | 28

Re: [PATCH v2 2/2] Cancel filesystem balance.

2010-11-11 Thread Chris Samuel
On 12/11/10 12:33, Li Zefan wrote: Is there any blocker that prevents us from canceling balance by just Ctrl+C ? Given that there's been at least 1 report of it taking 12 hours to balance a non-trivial amount of data I suspect putting this operation into the background by default and having