Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-05-05 Thread David Sterba
On Tue, Apr 11, 2017 at 09:44:03AM +0800, Qu Wenruo wrote: > > I get that we cannot easily avoid using the extent_changeset, so we'll > > end up one way or another, the stack conservation has slight preference. > > Yes, I understand dynamic allocation can complicate the error handler. > > But

Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-04-10 Thread Qu Wenruo
At 04/10/2017 10:14 PM, David Sterba wrote: On Mon, Apr 10, 2017 at 04:00:25PM +0200, David Sterba wrote: On Mon, Apr 10, 2017 at 09:25:18AM +0800, Qu Wenruo wrote: At 04/07/2017 08:00 PM, David Sterba wrote: On Mon, Mar 13, 2017 at 03:52:15PM +0800, Qu Wenruo wrote: @@ -3355,12 +3355,14

Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-04-10 Thread David Sterba
On Mon, Apr 10, 2017 at 04:00:25PM +0200, David Sterba wrote: > On Mon, Apr 10, 2017 at 09:25:18AM +0800, Qu Wenruo wrote: > > > > > > At 04/07/2017 08:00 PM, David Sterba wrote: > > > On Mon, Mar 13, 2017 at 03:52:15PM +0800, Qu Wenruo wrote: > > >> @@ -3355,12 +3355,14 @@ static int

Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-04-10 Thread David Sterba
On Mon, Apr 10, 2017 at 09:25:18AM +0800, Qu Wenruo wrote: > > > At 04/07/2017 08:00 PM, David Sterba wrote: > > On Mon, Mar 13, 2017 at 03:52:15PM +0800, Qu Wenruo wrote: > >> @@ -3355,12 +3355,14 @@ static int cache_save_setup(struct > >> btrfs_block_group_cache *block_group, > >>struct

Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-04-09 Thread Qu Wenruo
At 04/07/2017 08:00 PM, David Sterba wrote: On Mon, Mar 13, 2017 at 03:52:15PM +0800, Qu Wenruo wrote: @@ -3355,12 +3355,14 @@ static int cache_save_setup(struct btrfs_block_group_cache *block_group, struct btrfs_fs_info *fs_info = block_group->fs_info; struct btrfs_root

Re: [PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-04-07 Thread David Sterba
On Mon, Mar 13, 2017 at 03:52:15PM +0800, Qu Wenruo wrote: > @@ -3355,12 +3355,14 @@ static int cache_save_setup(struct > btrfs_block_group_cache *block_group, > struct btrfs_fs_info *fs_info = block_group->fs_info; > struct btrfs_root *root = fs_info->tree_root; > struct inode

[PATCH v2 8/9] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-03-13 Thread Qu Wenruo
Introduce a new parameter, struct extent_changeset for btrfs_qgroup_reserved_data() and its callers. Such extent_changeset was used in btrfs_qgroup_reserve_data() to record which range it reserved in current reserve, so it can free it at error path. The reason we need to export it to callers is,