Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-12-01 Thread Jan Kara
On Wed 29-11-17 13:38:26, Chris Mason wrote: > On 11/29/2017 12:05 PM, Tejun Heo wrote: > >On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: > >>Hello, > >> > >>On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: > >>>What has happened with this patch set? > >> > >>No idea. cc'ing C

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-30 Thread Chris Mason
On 11/30/2017 12:23 PM, David Sterba wrote: On Wed, Nov 29, 2017 at 01:38:26PM -0500, Chris Mason wrote: On 11/29/2017 12:05 PM, Tejun Heo wrote: On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: Hello, On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: What has happened wi

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-30 Thread David Sterba
On Wed, Nov 29, 2017 at 01:38:26PM -0500, Chris Mason wrote: > On 11/29/2017 12:05 PM, Tejun Heo wrote: > > On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: > >> Hello, > >> > >> On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: > >>> What has happened with this patch set? > >> >

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-29 Thread Chris Mason
On 11/29/2017 12:05 PM, Tejun Heo wrote: On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: Hello, On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: What has happened with this patch set? No idea. cc'ing Chris directly. Chris, if the patchset looks good, can you please rout

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-29 Thread Tejun Heo
On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: > Hello, > > On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: > > What has happened with this patch set? > > No idea. cc'ing Chris directly. Chris, if the patchset looks good, > can you please route them through the btrfs tree?

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-29 Thread Tejun Heo
Hello, On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: > What has happened with this patch set? No idea. cc'ing Chris directly. Chris, if the patchset looks good, can you please route them through the btrfs tree? Thanks. -- tejun -- To unsubscribe from this list: send the line "uns

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-29 Thread Jan Kara
o priority inversion and ineffective IO isolation. > > This patchset makes sure that btrfs issues all metadata and shared IOs > from the root cgroup by exempting btree_inodes from cgroup writeback > and explicitly associating shared IOs with the root cgroup. > > This patchset con

[PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-10-10 Thread Tejun Heo
has different ways to issue metadata IOs and may end up issuing metadata or otherwise shared IOs from a non-root cgroup, which can lead to priority inversion and ineffective IO isolation. This patchset makes sure that btrfs issues all metadata and shared IOs from the root cgroup by exempting

[PATCHSET] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-10-09 Thread Tejun Heo
Hello, btrfs has different ways to issue metadata IOs and may end up issuing metadata or otherwise shared IOs from a non-root cgroup, which can lead to priority inversion and ineffective IO isolation. This patchset makes sure that btrfs issues all metadata and shared IOs from the root cgroup by

Re: Btrfs Issues

2017-09-25 Thread Ruoxin Jiang
Hi Satoru, I'm so sorry for the late reply! I rewrote the test programs to invoke syscalls in the conventional way and added a few comments. Please find attached the revised report. As to your questions on "mmap", you are totally right that the first mmap in the original 1/min.cpp is irrelevant.

Re: Btrfs Issues

2017-09-17 Thread Satoru Takeuchi
At Wed, 13 Sep 2017 11:53:35 -0400, Ruoxin Jiang wrote: > > [1 ] > Hello, > > We are researchers from Columbia University, New York. As part of our > current research we have found some semantic discrepancies between > btrfs and other popular filesystems. > > We have attached two cases. The fir

Btrfs Issues

2017-09-13 Thread Ruoxin Jiang
Hello, We are researchers from Columbia University, New York. As part of our current research we have found some semantic discrepancies between btrfs and other popular filesystems. We have attached two cases. The first one involves an invalid O_DIRECT write() that fails back to buffered write ins

Re: btrfs issues in 3.14

2014-05-09 Thread Liu Bo
On Thu, May 08, 2014 at 10:51:03AM -0300, Kenny MacDermid wrote: > On Wed, May 7, 2014 at 11:48 PM, Liu Bo wrote: > > > > On Wed, May 07, 2014 at 09:35:06AM -0300, Kenny MacDermid wrote: > > > On Tue, May 6, 2014 at 11:22 PM, Liu Bo wrote: > > > > > > > > What does sysrq+w say when the hang happe

Re: btrfs issues in 3.14

2014-05-08 Thread Kenny MacDermid
On Wed, May 7, 2014 at 11:48 PM, Liu Bo wrote: > > On Wed, May 07, 2014 at 09:35:06AM -0300, Kenny MacDermid wrote: > > On Tue, May 6, 2014 at 11:22 PM, Liu Bo wrote: > > > > > > What does sysrq+w say when the hang happens? > > > > The whole system isn't hung, I may have explained that wrong. The

Re: btrfs issues in 3.14

2014-05-07 Thread Liu Bo
On Wed, May 07, 2014 at 09:35:06AM -0300, Kenny MacDermid wrote: > On Tue, May 6, 2014 at 11:22 PM, Liu Bo wrote: > > > > What does sysrq+w say when the hang happens? > > The whole system isn't hung, I may have explained that wrong. The > system will hang if I try to shutdown, and the process wil

Re: btrfs issues in 3.14

2014-05-07 Thread Kenny MacDermid
On Wed, May 7, 2014 at 9:35 AM, Kenny MacDermid wrote: > On Tue, May 6, 2014 at 11:22 PM, Liu Bo wrote: >> >> What does sysrq+w say when the hang happens? > > The whole system isn't hung, I may have explained that wrong. The > system will hang if I try to shutdown, and the process will hang if I

Re: btrfs issues in 3.14

2014-05-06 Thread Liu Bo
On Tue, May 06, 2014 at 08:49:04PM -0300, Kenny MacDermid wrote: > Hello, > > I've been having a number of issues with processes hanging due to > btrfs using 3.14 kernels. This seems pretty new as it has been working > fine before. I also rebuilt the filesystem and am still receiving > hangs. > >

btrfs issues in 3.14

2014-05-06 Thread Kenny MacDermid
Hello, I've been having a number of issues with processes hanging due to btrfs using 3.14 kernels. This seems pretty new as it has been working fine before. I also rebuilt the filesystem and am still receiving hangs. The filesystem is running on dmcrypt which is running on lvm2 which is running o

Re: btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Li Zefan
Dan Rosenberg wrote: > Commit 0caa102da82799efaba88e234484786a9591c797 introduced the > SUBVOL_SETFLAGS ioctl, which contains the following check: > > if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) Oops, should be: if (flags & BTRFS_SUBVOL_CREATE_ASYNC) > return -EINVAL; > >

btrfs: issues with SUBVOL_SETFLAGS

2011-02-09 Thread Dan Rosenberg
Commit 0caa102da82799efaba88e234484786a9591c797 introduced the SUBVOL_SETFLAGS ioctl, which contains the following check: if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC) return -EINVAL; if (flags & ~BTRFS_SUBVOL_RDONLY) return -EOPNOTSUPP; Is it intentiona