Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-10 Thread Jeff Mahoney
On 5/2/18 5:11 PM, je...@suse.com wrote: > From: Jeff Mahoney > > Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the commit it > intended

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-10 Thread Jeff Mahoney
On 5/2/18 5:11 PM, je...@suse.com wrote: > From: Jeff Mahoney > > Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the commit it > intended

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-03 Thread Jeff Mahoney
On 5/3/18 11:52 AM, Nikolay Borisov wrote: > > > On 3.05.2018 16:39, Jeff Mahoney wrote: >> On 5/3/18 3:24 AM, Nikolay Borisov wrote: >>> >>> >>> On 3.05.2018 00:11, je...@suse.com wrote: From: Jeff Mahoney Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-03 Thread Nikolay Borisov
On 3.05.2018 16:39, Jeff Mahoney wrote: > On 5/3/18 3:24 AM, Nikolay Borisov wrote: >> >> >> On 3.05.2018 00:11, je...@suse.com wrote: >>> From: Jeff Mahoney >>> >>> Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker initialization) >>> fixed the issue with

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-03 Thread Jeff Mahoney
On 5/3/18 3:24 AM, Nikolay Borisov wrote: > > > On 3.05.2018 00:11, je...@suse.com wrote: >> From: Jeff Mahoney >> >> Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker initialization) >> fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but >> ended up

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-03 Thread Nikolay Borisov
On 3.05.2018 00:11, je...@suse.com wrote: > From: Jeff Mahoney > > Commit 8d9eddad194 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the commit it >

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-02 Thread Jeff Mahoney
On 5/2/18 9:15 AM, David Sterba wrote: > On Wed, May 02, 2018 at 12:29:28PM +0200, David Sterba wrote: >> On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: >>> From: Jeff Mahoney >>> +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) >>> +{ >>> +

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-02 Thread David Sterba
On Wed, May 02, 2018 at 12:29:28PM +0200, David Sterba wrote: > On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: > > From: Jeff Mahoney > > +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) > > +{ > > + mutex_lock(_info->qgroup_rescan_lock); > > +

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-05-02 Thread David Sterba
On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: > From: Jeff Mahoney > +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) > +{ > + mutex_lock(_info->qgroup_rescan_lock); > + if (btrfs_fs_closing(fs_info)) { > +

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-30 Thread Jeff Mahoney
On 4/30/18 2:20 AM, Qu Wenruo wrote: > > > On 2018年04月27日 03:23, je...@suse.com wrote: >> From: Jeff Mahoney >> >> Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) >> fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but >> ended up reintroducing

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-30 Thread Qu Wenruo
On 2018年04月27日 03:23, je...@suse.com wrote: > From: Jeff Mahoney > > Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the commit it >

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-28 Thread David Sterba
On Fri, Apr 27, 2018 at 03:28:44PM -0400, Noah Massey wrote: > On Fri, Apr 27, 2018 at 11:56 AM, David Sterba wrote: > > On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: > >> From: Jeff Mahoney > >> > >> Commit d2c609b834d6 (Btrfs: fix qgroup

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-28 Thread David Sterba
On Fri, Apr 27, 2018 at 03:32:14PM -0400, Jeff Mahoney wrote: > On 4/27/18 12:40 PM, David Sterba wrote: > > On Fri, Apr 27, 2018 at 12:02:13PM -0400, Jeff Mahoney wrote: > +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) > +{ > >>> > >>> And this had to be moved upwards

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Jeff Mahoney
On 4/27/18 12:40 PM, David Sterba wrote: > On Fri, Apr 27, 2018 at 12:02:13PM -0400, Jeff Mahoney wrote: +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) +{ >>> >>> And this had to be moved upwards as there was earlier use of >>> btrfs_queue_work that matched following the

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Noah Massey
On Fri, Apr 27, 2018 at 11:56 AM, David Sterba wrote: > On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: >> From: Jeff Mahoney >> >> Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) >> fixed the issue with

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread David Sterba
On Fri, Apr 27, 2018 at 12:02:13PM -0400, Jeff Mahoney wrote: > >> +static void queue_rescan_worker(struct btrfs_fs_info *fs_info) > >> +{ > > > > And this had to be moved upwards as there was earlier use of > > btrfs_queue_work that matched following the hunk. > > Weird. That must be exactly

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Jeff Mahoney
On 4/27/18 11:56 AM, David Sterba wrote: > On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: >> From: Jeff Mahoney >> >> Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) >> fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but >> ended

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Jeff Mahoney
On 4/27/18 4:48 AM, Filipe Manana wrote: > On Thu, Apr 26, 2018 at 8:23 PM, wrote: >> From: Jeff Mahoney >> >> Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) >> fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but >> ended up

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread David Sterba
On Thu, Apr 26, 2018 at 03:23:49PM -0400, je...@suse.com wrote: > From: Jeff Mahoney > > Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Filipe Manana
On Thu, Apr 26, 2018 at 8:23 PM, wrote: > From: Jeff Mahoney > > Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the

Re: [PATCH 1/3] btrfs: qgroups, fix rescan worker running races

2018-04-27 Thread Nikolay Borisov
On 26.04.2018 22:23, je...@suse.com wrote: > From: Jeff Mahoney > > Commit d2c609b834d6 (Btrfs: fix qgroup rescan worker initialization) > fixed the issue with BTRFS_IOC_QUOTA_RESCAN_WAIT being racy, but > ended up reintroducing the hang-on-unmount bug that the commit it >