Re: [PATCH 10/22] btrfs: alloc space cache inode with GFP_NOFS

2018-07-19 Thread Josef Bacik
On Thu, Jul 19, 2018 at 05:44:53PM +0200, David Sterba wrote: > On Thu, Jul 19, 2018 at 06:35:33PM +0300, Nikolay Borisov wrote: > > > > > > On 19.07.2018 17:49, Josef Bacik wrote: > > > If we're allocating a new space cache inode it's likely going to be > > > under a transaction handle, so we ne

Re: [PATCH 10/22] btrfs: alloc space cache inode with GFP_NOFS

2018-07-19 Thread Josef Bacik
On Thu, Jul 19, 2018 at 06:35:33PM +0300, Nikolay Borisov wrote: > > > On 19.07.2018 17:49, Josef Bacik wrote: > > If we're allocating a new space cache inode it's likely going to be > > under a transaction handle, so we need to use GFP_NOFS to keep from > > deadlocking. Otherwise GFP_KERNEL is

Re: [PATCH 10/22] btrfs: alloc space cache inode with GFP_NOFS

2018-07-19 Thread David Sterba
On Thu, Jul 19, 2018 at 06:35:33PM +0300, Nikolay Borisov wrote: > > > On 19.07.2018 17:49, Josef Bacik wrote: > > If we're allocating a new space cache inode it's likely going to be > > under a transaction handle, so we need to use GFP_NOFS to keep from > > deadlocking. Otherwise GFP_KERNEL is

Re: [PATCH 10/22] btrfs: alloc space cache inode with GFP_NOFS

2018-07-19 Thread Nikolay Borisov
On 19.07.2018 17:49, Josef Bacik wrote: > If we're allocating a new space cache inode it's likely going to be > under a transaction handle, so we need to use GFP_NOFS to keep from > deadlocking. Otherwise GFP_KERNEL is fine. > > Signed-off-by: Josef Bacik > --- > fs/btrfs/free-space-cache.c