Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-27 Thread Omar Sandoval
On Sat, Jan 27, 2018 at 06:31:11PM +0200, Nikolay Borisov wrote: > > > On 27.01.2018 07:45, Omar Sandoval wrote: > > On Sat, Jan 27, 2018 at 01:00:58PM +0800, Qu Wenruo wrote: > >> > >> > >> On 2018年01月27日 03:46, Omar Sandoval wrote: > >>> On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baronc

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-27 Thread Nikolay Borisov
On 27.01.2018 07:45, Omar Sandoval wrote: > On Sat, Jan 27, 2018 at 01:00:58PM +0800, Qu Wenruo wrote: >> >> >> On 2018年01月27日 03:46, Omar Sandoval wrote: >>> On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: On 01/26/2018 07:40 PM, Omar Sandoval wrote: > From: Omar Sa

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-27 Thread Goffredo Baroncelli
On 01/27/2018 06:45 AM, Omar Sandoval wrote: > On Sat, Jan 27, 2018 at 01:00:58PM +0800, Qu Wenruo wrote: >> >> >> On 2018年01月27日 03:46, Omar Sandoval wrote: >>> On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: On 01/26/2018 07:40 PM, Omar Sandoval wrote: > From: Omar S

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-26 Thread Omar Sandoval
On Sat, Jan 27, 2018 at 01:00:58PM +0800, Qu Wenruo wrote: > > > On 2018年01月27日 03:46, Omar Sandoval wrote: > > On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: > >> On 01/26/2018 07:40 PM, Omar Sandoval wrote: > >>> From: Omar Sandoval > >> > >> > >> Hi, > >> > >> this is a

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-26 Thread Qu Wenruo
On 2018年01月27日 03:46, Omar Sandoval wrote: > On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: >> On 01/26/2018 07:40 PM, Omar Sandoval wrote: >>> From: Omar Sandoval >> >> >> Hi, >> >> this is a great work; only few comments: >> 1) I found not intuitive the naming of the func

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-26 Thread Omar Sandoval
On Fri, Jan 26, 2018 at 08:31:06PM +0100, Goffredo Baroncelli wrote: > On 01/26/2018 07:40 PM, Omar Sandoval wrote: > > From: Omar Sandoval > > > Hi, > > this is a great work; only few comments: > 1) I found not intuitive the naming of the function: i.e. you have > > btrfs_util_create_snapsho

Re: [PATCH 11/26] libbtrfsutil: add btrfs_util_create_snapshot()

2018-01-26 Thread Goffredo Baroncelli
On 01/26/2018 07:40 PM, Omar Sandoval wrote: > From: Omar Sandoval Hi, this is a great work; only few comments: 1) I found not intuitive the naming of the function: i.e. you have btrfs_util_create_snapshot() btrfs_util_f_create_snapshot() To me it seems more clear to have btrfs_util_create_