Re: [PATCH 3/4] btrfs: sysfs: export supported checksums

2019-10-08 Thread David Sterba
On Tue, Oct 08, 2019 at 08:47:14AM +0200, Johannes Thumshirn wrote: > On 07/10/2019 17:46, David Sterba wrote: > [...] > >> nit: This function is used only once and the ARRAY_SIZE() macro is > >> descriptive enough, why not just remove it and opencoude the call to > >> array_size > > > > Agreed, A

Re: [PATCH 3/4] btrfs: sysfs: export supported checksums

2019-10-07 Thread Johannes Thumshirn
On 07/10/2019 17:46, David Sterba wrote: [...] >> nit: This function is used only once and the ARRAY_SIZE() macro is >> descriptive enough, why not just remove it and opencoude the call to >> array_size > > Agreed, ARRAY_SIZE in loops is fine, it's a compile-time constant. Nope, btrfs_csums[] is

Re: [PATCH 3/4] btrfs: sysfs: export supported checksums

2019-10-07 Thread David Sterba
On Mon, Oct 07, 2019 at 06:36:14PM +0300, Nikolay Borisov wrote: > > > On 7.10.19 г. 12:11 ч., Johannes Thumshirn wrote: > > From: David Sterba > > > > Export supported checksum algorithms via sysfs. > > > > Co-developed-by: David Sterba > > Signed-off-by: Johannes Thumshirn > > --- > > fs

Re: [PATCH 3/4] btrfs: sysfs: export supported checksums

2019-10-07 Thread Nikolay Borisov
On 7.10.19 г. 12:11 ч., Johannes Thumshirn wrote: > From: David Sterba > > Export supported checksum algorithms via sysfs. > > Co-developed-by: David Sterba > Signed-off-by: Johannes Thumshirn > --- > fs/btrfs/ctree.c | 5 + > fs/btrfs/ctree.h | 2 ++ > fs/btrfs/sysfs.c | 33 +++