Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-18 Thread Zygo Blaxell
On Sun, Dec 14, 2014 at 10:06:50PM -0800, Robert White wrote: > ABSTRACT:: Stop being clever, just give the raw values. That's what > you should be doing anyway. There are no other correct values to > give that doesn't blow someone's paradigm somewhere. The trouble is a lot of existing software ca

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-16 Thread Dongsheng Yang
Hi Goffredo, On Tue, Dec 16, 2014 at 1:47 AM, Goffredo Baroncelli wrote: > I Yang, > > On 12/14/2014 12:29 PM, Dongsheng Yang wrote: >> On Sat, Dec 13, 2014 at 3:25 AM, Goffredo Baroncelli >> wrote: >>> On 12/11/2014 09:31 AM, Dongsheng Yang wrote: When function btrfs_statfs() calculate th

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-15 Thread Robert White
On 12/15/2014 12:26 AM, Dongsheng Yang wrote: On 12/15/2014 03:49 PM, Robert White wrote: On 12/14/2014 10:06 PM, Robert White wrote: On 12/14/2014 05:21 PM, Dongsheng Yang wrote: Anyone have some suggestion about it? (... strong advocacy for raw numbers...) Hi Robert, thanx for your so det

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-15 Thread Dongsheng Yang
On 12/15/2014 03:49 PM, Robert White wrote: On 12/14/2014 10:06 PM, Robert White wrote: On 12/14/2014 05:21 PM, Dongsheng Yang wrote: Anyone have some suggestion about it? (... strong advocacy for raw numbers...) Hi Robert, thanx for your so detailed reply. You are proposing to report the r

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-14 Thread Robert White
On 12/14/2014 10:06 PM, Robert White wrote: On 12/14/2014 05:21 PM, Dongsheng Yang wrote: Anyone have some suggestion about it? (... strong advocacy for raw numbers...) Concise Example to attempt to be clearer: /dev/sda == 1TiB /dev/sdb == 2TiB /dev/sdc == 3TiB /dev/sdd == 3TiB mkfs.btrfs /

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-14 Thread Robert White
On 12/14/2014 05:21 PM, Dongsheng Yang wrote: Does it make sense to you? I understood what you were saying but it didn't make sense to me... As there are 2 complaints for the same change of @size in df, I have to say it maybe not so easy to understand. Anyone have some suggestion about it

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-14 Thread Dongsheng Yang
On 12/14/2014 10:32 PM, Grzegorz Kowal wrote: Hi, I see another problem on 1 device fs after applying this patch. I set up 30GB system partition: in gdisk key 'i' Partition size: 62914560 sectors (30.0 GiB) -> 62914560 * 512 = 32212254720 = 30.0GiB before applying the patch df -B1 shows Files

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-14 Thread Grzegorz Kowal
Hi, I see another problem on 1 device fs after applying this patch. I set up 30GB system partition: in gdisk key 'i' Partition size: 62914560 sectors (30.0 GiB) -> 62914560 * 512 = 32212254720 = 30.0GiB before applying the patch df -B1 shows Filesystem1B-blocks UsedAvailable

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-14 Thread Dongsheng Yang
On Sat, Dec 13, 2014 at 3:25 AM, Goffredo Baroncelli wrote: > On 12/11/2014 09:31 AM, Dongsheng Yang wrote: >> When function btrfs_statfs() calculate the tatol size of fs, it is >> calculating >> the total size of disks and then dividing it by a factor. But in some >> usecase, >> the result is n

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-13 Thread Dongsheng Yang
On 12/13/2014 08:50 AM, Duncan wrote: Goffredo Baroncelli posted on Fri, 12 Dec 2014 19:00:20 +0100 as excerpted: $ sudo ./btrfs fi df /mnt/btrfs1/ Data, RAID1: total=1.00GiB, used=512.00KiB Data, single: total=8.00MiB, used=0.00B System, RAID1: total=8.00MiB, used=16.00KiB System, single: tota

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-13 Thread Dongsheng Yang
On 12/13/2014 02:00 AM, Goffredo Baroncelli wrote: On 12/11/2014 09:31 AM, Dongsheng Yang wrote: When function btrfs_statfs() calculate the tatol size of fs, it is calculating the total size of disks and then dividing it by a factor. But in some usecase, the result is not good to user. I am che

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-12 Thread Duncan
Goffredo Baroncelli posted on Fri, 12 Dec 2014 19:00:20 +0100 as excerpted: > $ sudo ./btrfs fi df /mnt/btrfs1/ > Data, RAID1: total=1.00GiB, used=512.00KiB > Data, single: total=8.00MiB, used=0.00B > System, RAID1: total=8.00MiB, used=16.00KiB > System, single: total=4.00MiB, used=0.00B > Metadat

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-12 Thread Goffredo Baroncelli
On 12/11/2014 09:31 AM, Dongsheng Yang wrote: > When function btrfs_statfs() calculate the tatol size of fs, it is calculating > the total size of disks and then dividing it by a factor. But in some usecase, > the result is not good to user. I Yang; during my test I discovered an error: $ sudo l

Re: [PATCH v2 1/3] Btrfs: get more accurate output in df command.

2014-12-12 Thread Goffredo Baroncelli
On 12/11/2014 09:31 AM, Dongsheng Yang wrote: > When function btrfs_statfs() calculate the tatol size of fs, it is calculating > the total size of disks and then dividing it by a factor. But in some usecase, > the result is not good to user. I am checking it; to me it seems a good improvement. How