Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-28 Thread David Sterba
On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: > Qu Wenruo (6): > btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots() > btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() > btrfs: qgroup: Introduce per-root swapped blocks infrastructure > btrfs: qgroup:

Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-24 Thread David Sterba
On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: > - A lot of coding style fixes: > * naming change from "file"/"subv" to "subvol" > * {} for any else if branch > * avoid err/ret confusion by introducing "tmp_ret" > * proper errno for non-uptodate extent buffer > * struct member

Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-24 Thread Qu Wenruo
On 2019/1/24 上午1:47, David Sterba wrote: > On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: >> v5: >> - Use Josef's superior qgroup deadlock fix. >> No performance regression now. > > Does this pass fstests on your side? Namely if test btrfs/007 does not > crash, > https://lore.kerne

Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-23 Thread Qu Wenruo
On 2019/1/24 上午1:47, David Sterba wrote: > On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: >> v5: >> - Use Josef's superior qgroup deadlock fix. >> No performance regression now. > > Does this pass fstests on your side? Namely if test btrfs/007 does not > crash, > https://lore.kerne

Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-23 Thread David Sterba
On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote: > v5: > - Use Josef's superior qgroup deadlock fix. > No performance regression now. Does this pass fstests on your side? Namely if test btrfs/007 does not crash, https://lore.kernel.org/linux-btrfs/20190123135120.gt2...@twin.jikos.cz/

Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

2019-01-22 Thread Qu Wenruo
On 2019/1/23 下午3:15, Qu Wenruo wrote: > This patchset can be fetched from github: > https://github.com/adam900710/linux/tree/qgroup_delayed_subtree > > Which is based on v5.0-rc1. > > This patch address the heavy load subtree scan, but delaying it until > we're going to modify the swapped tree