Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-11 Thread Qu Wenruo
Mark Fasheh wrote on 2016/04/11 11:09 -0700: On Mon, Apr 11, 2016 at 09:05:47AM +0800, Qu Wenruo wrote: Mark Fasheh wrote on 2016/04/08 12:18 -0700: On Fri, Apr 08, 2016 at 03:10:35PM +0200, Holger Hoffstätte wrote: [cc: Mark and Qu] On 04/08/16 13:51, Holger Hoffstätte wrote: On

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-11 Thread Mark Fasheh
On Mon, Apr 11, 2016 at 09:05:47AM +0800, Qu Wenruo wrote: > > > Mark Fasheh wrote on 2016/04/08 12:18 -0700: > >On Fri, Apr 08, 2016 at 03:10:35PM +0200, Holger Hoffstätte wrote: > >>[cc: Mark and Qu] > >> > >>On 04/08/16 13:51, Holger Hoffstätte wrote: > >>>On 04/08/16 13:14, Filipe Manana

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-10 Thread Qu Wenruo
Mark Fasheh wrote on 2016/04/08 12:18 -0700: On Fri, Apr 08, 2016 at 03:10:35PM +0200, Holger Hoffstätte wrote: [cc: Mark and Qu] On 04/08/16 13:51, Holger Hoffstätte wrote: On 04/08/16 13:14, Filipe Manana wrote: Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs patches,

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-08 Thread Mark Fasheh
On Fri, Apr 08, 2016 at 03:10:35PM +0200, Holger Hoffstätte wrote: > [cc: Mark and Qu] > > On 04/08/16 13:51, Holger Hoffstätte wrote: > > On 04/08/16 13:14, Filipe Manana wrote: > >> Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs > >> patches, it didn't reproduce here: > >

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-08 Thread Holger Hoffstätte
[cc: Mark and Qu] On 04/08/16 13:51, Holger Hoffstätte wrote: > On 04/08/16 13:14, Filipe Manana wrote: >> Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs >> patches, it didn't reproduce here: > > Great, that's good to know (sort of :). Thanks also to Liu Bo. > >> Are you

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-08 Thread Holger Hoffstätte
On 04/08/16 13:14, Filipe Manana wrote: > Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs > patches, it didn't reproduce here: Great, that's good to know (sort of :). Thanks also to Liu Bo. > Are you sure that you are not using some patches not in 4.6? Quite a few, but to

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-08 Thread Filipe Manana
On Thu, Apr 7, 2016 at 5:44 PM, Holger Hoffstätte wrote: > Hi, > > Looks like I just found an exciting new corner case. > kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs patches, it

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-07 Thread Liu Bo
On Thu, Apr 07, 2016 at 06:44:20PM +0200, Holger Hoffstätte wrote: > Hi, > > Looks like I just found an exciting new corner case. > kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. > > Try on a fresh volume: > > $btrfs subvolume create foo > Create subvolume './foo' > $sync > $btrfs

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-07 Thread Filipe Manana
On Thu, Apr 7, 2016 at 5:44 PM, Holger Hoffstätte wrote: > Hi, > > Looks like I just found an exciting new corner case. > kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. > > Try on a fresh volume: > > $btrfs subvolume create foo > Create subvolume './foo'

WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

2016-04-07 Thread Holger Hoffstätte
Hi, Looks like I just found an exciting new corner case. kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. Try on a fresh volume: $btrfs subvolume create foo Create subvolume './foo' $sync $btrfs subvolume snapshot foo foo-1 Create a snapshot of 'foo' in './foo-1' $sync $mv foo-1 foo.new