[PATCH 1/2] Btrfs: add a type field for the transaction handle

2012-09-20 Thread Miao Xie
This patch add a type field into the transaction handle structure, in this way, we needn't implement various end-transaction functions and can make the code more simple and readable. Signed-off-by: Miao Xie --- This patch is based on btrfs-next tree. --- fs/btrfs/inode.c | 19 ---

[PATCH 2/2] Btrfs: fix orphan transaction on the freezed filesystem

2012-09-20 Thread Miao Xie
With the following debug patch: static int btrfs_freeze(struct super_block *sb) { + struct btrfs_fs_info *fs_info = btrfs_sb(sb); + struct btrfs_transaction *trans; + + spin_lock(&fs_info->trans_lock); + trans = fs_info->running_transaction; + if (trans) { +

Re: [PATCH 1/2] Btrfs: make space to keep default mount options

2012-09-20 Thread David Sterba
On Wed, Sep 19, 2012 at 05:31:25PM +0900, Hidetoshi Seto wrote: > >> > >> + info->mount_opt = info->super_copy->default_mount_opt; > > > > the options have to respect some priority, eg. when I set default > > options to a filesystem, but mount with a different set, I expect that > > the explici

Re: [PATCH 2/2] Btrfs-progs: add mount-option command

2012-09-20 Thread David Sterba
On Wed, Sep 19, 2012 at 05:32:16PM +0900, Hidetoshi Seto wrote: > (2012/09/18 11:31), Miao Xie wrote: > > On tue, 18 Sep 2012 10:30:17 +0900, Hidetoshi Seto wrote: > >> This patch adds mount-option command. > >> The command can set/get default mount options. > >> Now, the command can set/get 24 opt

[PATCH 1/2] Btrfs-progs: introduce -g -c --sort options into btrfs subvol list command

2012-09-20 Thread Miao Xie
From: Wang Shilong This patch introduces '-g' '-c' '--sort' options The option '-g' can help you filter the subvolumes by the generation, you may use it just like: btrfs subvol list -g +/-value '+' means the generation of the subvolumes should >= the value you specified. '-' means the

[PATCH 2/2] Btrfs-progs: introduce '-t' option into subvolume list command

2012-09-20 Thread Miao Xie
From: Wang Shilong This patch introduces '-t' option into subvolume list command. By this option, we can output the result as a table. Signed-off-by: Wang Shilong Signed-off-by: Miao Xie --- This patch is based on patchset: [PATCH V4 0/7] Btrfs-progs: enhance btrfs subvol list only to show rea

Re: R: [PATCH 2/2] Btrfs-progs: add mount-option command

2012-09-20 Thread David Sterba
On Tue, Sep 18, 2012 at 12:03:47PM +0200, Goffredo Baroncelli wrote: > Why it was not provided a way to clear a *single* flag ? To me it seems a bit > too long to clear all the flag (btrfs mount-option clear) and then set the > right one. > > As user interface I suggest something like chmod: >

Re: enquiry about autodefrag option

2012-09-20 Thread David Sterba
On Thu, Sep 20, 2012 at 07:36:53AM +0800, ching wrote: > > >>> 2. AFAIK, "autodefrag" detects small random writes into files and > >>> queues them up for an automatic defrag process, so the filesystem will > >>> defragment itself while it's used. > >>> > >>> If the system reboot/crash/remount-

Re: [PATCH V4 5/7] Btrfs-progs: restructure list_subvolumes

2012-09-20 Thread David Sterba
On Tue, Sep 18, 2012 at 07:06:49PM +0800, Miao Xie wrote: > The current code of list_subvols() has very bad scalability, if we want to > add new filter conditions or new sort methods, we have to modify lots of code. I've briefly skimmed through the patch, not a short one, IMO the right way to go.

Re: [PATCH] Btrfs + Btrfs-progs: make pipe functions re-usable

2012-09-20 Thread David Sterba
On Tue, Sep 18, 2012 at 01:33:29PM +0800, Anand Jain wrote: > 'btrfs service history |' > is basically to show the list of cli/gui commands which are > successfully run on the btrfs as part of its - > creation (may be), configuration and maintenance. Is it modelled after ZFS 'zpool history' c

Re: [PATCH V2 1/2] Btrfs: cleanup duplicated division functions

2012-09-20 Thread David Sterba
On Thu, Sep 20, 2012 at 10:57:54AM +0800, Miao Xie wrote: > Because those functions are mostly used on the hot path, and we are sure > the parameters are right in the most cases, we don't add complex checks > for the parameters. But in the other place, we must check and make sure > the parameters a

Re: btrfs: open_ctree failed on external usb drive

2012-09-20 Thread David Sterba
On Sun, Sep 16, 2012 at 03:24:53PM +0200, Sébastien Kalt wrote: > I'm running Debian Sid, 3.2.0-3-amd64 kernel and Btrfs v0.19 > (0.19+20120328-8 according to dpkg), using XFCE4 and dolphin as a file > manager. The usb drive is auto-mounting, and I'm accessing it with > dolphin or console. I alway

Re: enquiry about autodefrag option

2012-09-20 Thread David Sterba
On Wed, Sep 19, 2012 at 07:39:42PM +0200, Martin Steigerwald wrote: > > >>(P.S. I am aware that autodefrag will introduce extra write I/O) > > > > Yes, your understanding is right, random write workloads will benefit > > from it. > > What about the extra I/O? And the greatly reduced seek time

Re: [RFC][PATCH] Btrfs-progs: Fix compiler warnings on PPC64.

2012-09-20 Thread David Sterba
On Fri, Sep 14, 2012 at 10:13:13AM -0700, Wade Cline wrote: > By the time kerncompat.h is included, u64 is almost always defined to > the non-compatible value. So either kerncompat.h needs to be defined as the > -first- This makes most sense to me. Although the include files should go in the orde

[PATCH] Btrfs: make compress and nodatacow mount options mutually exclusive

2012-09-20 Thread Andrei Popa
If a filesystem is mounted with compression and then remounted by adding nodatacow, the compression is disabled but the compress flag is still visible. Also, if a filesystem is mounted with nodatacow and then remounted with compression, nodatacow flag is still present but it's not active. This pa

[PATCH] Btrfs: small fix the commment for the action flags in delayed-ref.h

2012-09-20 Thread Wang Sheng-Hui
The action has been merged into struct btrfs_delayed_ref_node, and no struct btrfs_delayed_ref is available now. Signed-off-by: Wang Sheng-Hui --- fs/btrfs/delayed-ref.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/delayed-ref.h b/fs/btrfs/delayed-ref.h inde

Re: [PATCH] Btrfs: small fix the commment for the action flags in delayed-ref.h

2012-09-20 Thread Liu Bo
On 09/20/2012 11:07 PM, Wang Sheng-Hui wrote: > The action has been merged into struct btrfs_delayed_ref_node, > and no struct btrfs_delayed_ref is available now. > You can consider sending this kind of typo fix patch to trivial list instead. thanks, liubo > Signed-off-by: Wang Sheng-Hui > ---

Re: [PATCH] Btrfs: make compress and nodatacow mount options mutually exclusive

2012-09-20 Thread David Sterba
On Thu, Sep 20, 2012 at 05:42:11PM +0300, Andrei Popa wrote: > If a filesystem is mounted with compression and then remounted by adding > nodatacow, > the compression is disabled but the compress flag is still visible. > Also, if a filesystem is mounted with nodatacow and then remounted with > co

3.5.3: kernel BUG at fs/btrfs/ctree.c:3451!

2012-09-20 Thread Marc MERLIN
I had a btrfs built on top of 5 drives (dmcrypt devices). The drive then died while I was writing to the filesystem and my system crashed and rebooted: [384555.534020] sd 10:0:0:0: rejecting I/O to offline device [384555.535057] sd 10:0:0:0: rejecting I/O to offline device

ENOSPC design issues

2012-09-20 Thread Josef Bacik
Hello, I'm going to look at fixing some of the performance issues that crop up because of our reservation system. Before I go and do a whole lot of work I want some feedback. I've done a brain dump here https://btrfs.wiki.kernel.org/index.php/ENOSPC This has an explanation of how our reservati

[PATCH] btrfs: fix min csum item size warnings in 32bit

2012-09-20 Thread Zach Brown
commit 7ca4be45a0255ac8f08c05491c6add2dd87dd4f8 limited csum items to PAGE_CACHE_SIZE. It used min() with incompatible types in 32bit which generates warnings: fs/btrfs/file-item.c: In function ‘btrfs_csum_file_blocks’: fs/btrfs/file-item.c:717: warning: comparison of distinct pointer types lacks

Re: enquiry about autodefrag option

2012-09-20 Thread ching
>> Is there any io niceness control for autodefrag process too? it will >> be nice if the idle class is used. > No. Autodefrag will mark file data dirty and they'll be written back to > the storage in the same way as any other write through the worker > threads. > > AFAIK, the autodefrag will rea

[PATCH] Btrfs-progs: Fix compiler warnings on PPC64

2012-09-20 Thread clinew
From: Wade Cline The kernel uses unsigned long long for u64, but PPC64 uses unsigned long by default. This results in compilation warnings such as: print-tree.c:333: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'u64' To fix this, the macro __KERNEL__ nee

[RESEND][PATCH] Btrfs: small fix the commment for the action flags in delayed-ref.h

2012-09-20 Thread Wang Sheng-Hui
The action field has been merged into struct btrfs_delayed_ref_node, and no struct btrfs_delayed_ref is available now. Signed-off-by: Wang Sheng-Hui --- fs/btrfs/delayed-ref.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/delayed-ref.h b/fs/btrfs/delayed-ref.

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread Marc MERLIN
On Thu, Sep 20, 2012 at 10:17:47AM -0700, Marc MERLIN wrote: > I had a btrfs built on top of 5 drives (dmcrypt devices). > > The drive then died while I was writing to the filesystem and my system > crashed and rebooted: > > [384555.534020] sd 10:0:0:0: rejecting I/O to offline device

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread cwillu
On Thu, Sep 20, 2012 at 9:46 PM, Marc MERLIN wrote: > On Thu, Sep 20, 2012 at 10:17:47AM -0700, Marc MERLIN wrote: >> I had a btrfs built on top of 5 drives (dmcrypt devices). >> >> The drive then died while I was writing to the filesystem and my system >> crashed and rebooted: >> >> [384555.53402

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread Liu Bo
On 09/21/2012 11:46 AM, Marc MERLIN wrote: > On Thu, Sep 20, 2012 at 10:17:47AM -0700, Marc MERLIN wrote: >> I had a btrfs built on top of 5 drives (dmcrypt devices). >> >> The drive then died while I was writing to the filesystem and my system >> crashed and rebooted: >> >> [384555.534020] sd 10:0

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread Marc MERLIN
On Thu, Sep 20, 2012 at 09:51:59PM -0600, cwillu wrote: > > Oh my, now I'm trying again with a new drive, and a big cp from an > > existing array to a new one dies with: > > [32042.079411] [ cut here ] > > [32042.085799] kernel BUG at fs/btrfs/extent_io.c:1884! > > [32042.09

[PATCH] Btrfs: fix return value check in btrfs_ioctl_send()

2012-09-20 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function btrfs_read_fs_root_no_name() returns ERR_PTR() and never returns NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(), and remove useless NULL test. dpatch engine is used to auto generated this patch. (https://git

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread Stefan Behrens
On 09/21/2012 05:46, Marc MERLIN wrote: Oh my, now I'm trying again with a new drive, and a big cp from an existing array to a new one dies with: [32042.079411] [ cut here ] [32042.085799] kernel BUG at fs/btrfs/extent_io.c:1884! [32042.092528] invalid opcode: [#1] PR

Re: kernel BUG at fs/btrfs/extent_io.c:1884!

2012-09-20 Thread Marc MERLIN
On Fri, Sep 21, 2012 at 06:57:32AM +0200, Stefan Behrens wrote: > > BUG_ON(!mirror_num); < > > > > This was fixed with commit c0901581ad077004145c9ee80e843fba71c100b8 and > is included in Linux 3.6 RC1. Congrats for all having a time machine and fixing my reported bugs in the past :)

[PATCH] Btrfs-progs: btrfs subvolume delete could delete subvolumes

2012-09-20 Thread Anand jain
From: Anand Jain With this user will be able to provide more than one subvolume to delete. eg: btrfs subvolume delete Signed-off-by: Anand Jain --- cmds-subvolume.c | 36 man/btrfs.8.in |4 ++-- 2 files changed, 26 insertions(+), 14 deletions(-)

[PATCH 1/2] Btrfs-progs: fix the btrfs-debug-tree usage

2012-09-20 Thread Anand jain
From: Anand Jain Signed-off-by: Anand Jain --- debug-tree.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/debug-tree.c b/debug-tree.c index 94ffd8e..0e391fc 100644 --- a/debug-tree.c +++ b/debug-tree.c @@ -30,7 +30,7 @@ static int print_usage(void) { - fp

[PATCH] Btrfs-progs: correct the mkfs.btrfs man page

2012-09-20 Thread Anand jain
From: Anand Jain Signed-off-by: Anand Jain --- man/mkfs.btrfs.8.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in index fc2e1d2..d425c33 100644 --- a/man/mkfs.btrfs.8.in +++ b/man/mkfs.btrfs.8.in @@ -1,6 +1,6 @@ .TH MKFS.BT