Questions about mkfs -A option

2012-10-17 Thread Wang Sheng-Hui
Hi, I'm reading the mkfs code, and confused by its -A option. >From its comments, the value specified by -A should be regarded as the start of the filesystem. But mkfs will always zero some area at the beginning of the first dev, regardless -r specified or not. My question is: Why mkfs zeros the

Re: filesystem in such a state that btrfsck crashes

2012-10-17 Thread Sami Haahtinen
On Tue, Oct 16, 2012 at 11:25 PM, Sami Haahtinen wrote: > The kernel I started seeing the problems is 3.6.0 and I was on 3.6.2 > during the few final moments. I have backups of the filesystem, but > I'm a bit curious what is causing this. I've seen mentions of other > segfault causing problems, so

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> NOTE: >> >> The patchset is currently post out mainly to make sure >> it is going in the correct direction and hope to get some >> helpful comm

[PATCH] btrfs-progs: Fix the receive code pathing

2012-10-17 Thread Alex Lyakas
The receive code was not distinguishing properly between the mount root and the directory to create the received subvolume in. Also make sure the find_mount_root reports an error if it cannot find a match at all. Reported-by: Robert Buhren Reported-by: Rory Campbell-Lange Reported-by: Stefan Pri

[RFC] Systemcall for offline deduplication

2012-10-17 Thread Gabriel
On Mon, 15 Oct 2012 22:15:16 +0200, David Sterba wrote: > On Mon, Oct 15, 2012 at 07:09:23PM +0200, Bob Marley wrote: >> I would really appreciate a systemcall (or ioctl or the like) to allow >> deduplication of a block of a file against a block of another file. >> (ok if blocks need to be aligned

Weird checksum error with VM images

2012-10-17 Thread Alexander Larsson
I recently got some checksum errors on my btrfs filesystem that seem "interesting". This is on a F18 kernel (3.6.0-3.fc18.x86_64) with the filesystem on a single INTEL SSDSA2CW16 disk (ssd). Its my workstation, so i do normal development on it, i.e. its not a server. Recently I have been doing some

[PATCH] Btrfs: Send: preserve ownership (uid and gid) also for symlinks.

2012-10-17 Thread Alex Lyakas
This patch also requires a change in the user-space part of "receive". We need to use "lchown" instead of "chown". We will do this in the following patch. Signed-off-by: Alex Lyakas diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index c7beb54..7d1eed2 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/

[PATCH] btrfs-progs: Receive: preserve ownership for symlinks, by using 'lchown'

2012-10-17 Thread Alex Lyakas
Signed-off-by: Alex Lyakas diff --git a/cmds-receive.c b/cmds-receive.c index 6b7cf12..a6a6a5b 100644 --- a/cmds-receive.c +++ b/cmds-receive.c @@ -731,7 +731,7 @@ static int process_chown(const char *path, u64 uid, u64 gid, void *user) fprintf(stderr, "chown %s - uid=%llu, gid=%l

Re: [BUG] __tree_mod_log_rewind makes extent buffers larger than leafsize

2012-10-17 Thread Liu Bo
On 10/17/2012 11:27 PM, Liu Bo wrote: > [ 103.354284] kernel BUG at fs/btrfs/ctree.c:1582! > [ 103.354305] invalid opcode: [#1] SMP > [ 103.354326] Modules linked in: btrfs(O) tcp_lp zlib_deflate libcrc32c fuse > lockd rfcomm bnep ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 > ip6table_f

[PATCH] Btrfs-progs: Filter out deleting or already-deleted subvolumes in lookup_ino_path.

2012-10-17 Thread Alex Lyakas
If a subvolume is deleted between __list_subvol_search() and __list_subvol_fill_paths(), the tool would have stopped with an error. So drop those subvolumes that did not have ROOT_BACKREF, and those for whom a path component to the parent root was missing. (Note that BTRFS_IOC_INO_LOOKUP does not d

Re: [PATCH] Btrfs-progs: Filter out deleting or already-deleted subvolumes in lookup_ino_path.

2012-10-17 Thread Miao Xie
On Wed, 17 Oct 2012 18:06:52 +0200, Alex Lyakas wrote: > -static int __list_subvol_fill_paths(int fd, struct root_lookup *root_lookup) > +static int __list_subvol_fill_paths(int fd, struct root_lookup *root_lookup, > + struct root_lookup *root_lookup_final) > { > struct rb_node *n; > >

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-17 Thread Zheng Liu
On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote: > >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h > >> index d19e64a..7a79a6d 100644 > >> --- a/fs/hot_tracking.h > >> +++ b/fs/hot_tracking.h > >> @@ -36,6 +36,9 @@ > >> */ > >> #define TIME_TO_KICK 400 > >> > >> +/* set how oft

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 10:25 AM, Zheng Liu wrote: > On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote: >> >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h >> >> index d19e64a..7a79a6d 100644 >> >> --- a/fs/hot_tracking.h >> >> +++ b/fs/hot_tracking.h >> >> @@ -36,6 +36,9 @@ >> >>

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: > On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: > > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: > >> From: Zhi Yong Wu > > (*) Tested on an empty 17TB XFS filesystem with: > > > > $ sudo mkfs.xfs -f

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote: > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: >> On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: >> > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: >> >> From: Zhi Yong Wu > >> > (*) Tested o

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote: > On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote: > > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: > >> On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote: > >> > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker.

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Zhi Yong Wu
On Thu, Oct 18, 2012 at 1:17 PM, Dave Chinner wrote: > On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote: >> On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote: >> > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: >> >> On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote

Re: [BUG] __tree_mod_log_rewind makes extent buffers larger than leafsize

2012-10-17 Thread Jan Schmidt
Hi liubo, On Wed, October 17, 2012 at 17:27 (+0200), Liu Bo wrote: > Hi Jan, > > Here is the steps, > > 1. apply the three patches onto the latest btrfs Can you give me a commit id? They don't apply to cmason/master as of today. Patch 1 looks reversed, by the way. I'd comment on patch 2, but i