Re: BTRFS: Transaction aborted (error -28)

2016-07-31 Thread Mordechay Kaganer
B.H. Thanks for the detailed answer! On Fri, Jul 29, 2016 at 8:23 PM, Duncan <1i5t5.dun...@cox.net> wrote: > ... > Of course the fact that the transaction aborted /does/ indicate some sort > of problem, which may in fact have left the filesystem in an unknown > state. However, I'd recommend a co

Re: systemd KillUserProcesses=yes and btrfs scrub

2016-07-31 Thread Gabriel C
On 30.07.2016 22:02, Chris Murphy wrote: > Short version: When systemd-logind login.conf KillUserProcesses=yes, > and the user does "sudo btrfs scrub start" in e.g. GNOME Terminal, and > then logs out of the shell, the user space operation is killed, and > btrfs scrub status reports that the scru

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-31 Thread Anatoly Pugachev
On Fri, Jul 15, 2016 at 2:31 AM, Omar Sandoval wrote: > From: Omar Sandoval > > So it turns out that the free space tree bitmap handling has always been > broken on big-endian systems. Totally my bad. > > Patch 1 fixes this. Technically, it's a disk format change for > big-endian systems, but it

[GIT PULL] Btrfs

2016-07-31 Thread Chris Mason
Hi Linus, This is part one of my btrfs pull, and you can find it in my for-linus-4.8 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.8 This pull is dedicated to Josef's enospc rework, which we've been testing for a few releases now. It fixes some early e

Re: OOM killer invoked during btrfs send/recieve on otherwise idle machine

2016-07-31 Thread Michal Hocko
[CC Mel and linux-mm] On Sun 31-07-16 07:11:21, Markus Trippelsdorf wrote: > Tonight the OOM killer got invoked during backup of /: > > [Jul31 01:56] kthreadd invoked oom-killer: > gfp_mask=0x27000c0(GFP_KERNEL_ACCOUNT|__GFP_NOTRACK), order=2, oom_score_adj=0 This a kernel stack allocation. >

Re: OOM killer invoked during btrfs send/recieve on otherwise idle machine

2016-07-31 Thread Markus Trippelsdorf
On 2016.07.31 at 17:10 +0200, Michal Hocko wrote: > [CC Mel and linux-mm] > > On Sun 31-07-16 07:11:21, Markus Trippelsdorf wrote: > > Tonight the OOM killer got invoked during backup of /: > > > > [Jul31 01:56] kthreadd invoked oom-killer: > > gfp_mask=0x27000c0(GFP_KERNEL_ACCOUNT|__GFP_NOTRACK

Re: systemd KillUserProcesses=yes and btrfs scrub

2016-07-31 Thread Chris Murphy
On Sun, Jul 31, 2016 at 4:56 AM, Gabriel C wrote: > > > On 30.07.2016 22:02, Chris Murphy wrote: >> Short version: When systemd-logind login.conf KillUserProcesses=yes, >> and the user does "sudo btrfs scrub start" in e.g. GNOME Terminal, and >> then logs out of the shell, the user space operation

Re: Btrfs send to send out metadata and data separately

2016-07-31 Thread Qu Wenruo
At 07/29/2016 09:14 PM, Libor Klepáč wrote: Hello, just a little question on receiver point 0), see bellow Dne pátek 29. července 2016 20:40:38 CEST, Qu Wenruo napsal(a): Hi Filipe, and maintainers, Receive will do the following thing first before recovering the subvolume/snapshot: 0) Crea

Re: Btrfs send to send out metadata and data separately

2016-07-31 Thread Qu Wenruo
At 07/31/2016 02:49 AM, g.bt...@cobb.uk.net wrote: On 29/07/16 13:40, Qu Wenruo wrote: Cons: 1) Not full fs clone detection Such clone detection is only inside the send snapshot. For case that one extent is referred only once in the send snapshot, but also referred by source subvolum

Re: systemd KillUserProcesses=yes and btrfs scrub

2016-07-31 Thread Duncan
Chris Murphy posted on Sat, 30 Jul 2016 14:02:17 -0600 as excerpted: > Short version: When systemd-logind login.conf KillUserProcesses=yes, and > the user does "sudo btrfs scrub start" in e.g. GNOME Terminal, and then > logs out of the shell, the user space operation is killed, and btrfs > scrub s

btrfs fi usage bug during shrink

2016-07-31 Thread Sean Greenslade
Hi, all. I was resizing (shrinking) a btrfs partition, and figured I'd check in on how it was going with "btrfs fi usage." It was quite startling: $ sudo btrfs fi usage /mnt/ Overall: Device size: 370.00GiB Device allocated:372.03GiB Device unallocated:

[PATCH v4] btrfs: fix fsfreeze hang caused by delayed iputs deal

2016-07-31 Thread Wang Xiaoguang
When running fstests generic/068, sometimes we got below deadlock: xfs_io D 8800331dbb20 0 6697 6693 0x0080 8800331dbb20 88007acfc140 880034d895c0 8800331dc000 880032d243e8 fffe 880032d24400 0001 8800331dbb38 ff

Re: [PATCH 02/17] xfs: use rmapbt-checking helper

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:29PM -0700, Darrick J. Wong wrote: > Don't open-code _notrun checks for the rmapbt, just use the helper. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the

Re: [PATCH 03/17] xfs/310: fix the size calculation for the huge device

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:35PM -0700, Darrick J. Wong wrote: > Fix the calculation of the dmhuge size. The previous calculation > tried to calculate the size correctly, but got it wrong for 1k > block sizes. Therefore, clean the whole mess up. > > Signed-off-by: Darrick J. Wong Looks fine,

Re: [PATCH 01/17] xfs/26[34]: remove duplicate tests

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:21PM -0700, Darrick J. Wong wrote: > These two tests were accidentally double-added as xfs/30[78], but the > newer versions have fixed up helper usage and fewer whitespace > problems, so nuke the old tests. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by

Re: [PATCH 04/17] xfs/122: list the new log redo items

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:42PM -0700, Darrick J. Wong wrote: > List the new log redo items. These should have stable sizes. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body o

Re: [PATCH 07/17] xfs/128: cycle_mount the scratch device, not the test device

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:01PM -0700, Darrick J. Wong wrote: > This test uses the scratch device, so cycle that, not the test dev. > This is also a xfs_fsr test, so put it in the fsr group. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from

Re: [PATCH 05/17] common/reflink: actually test dedupe on scratch device

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:48PM -0700, Darrick J. Wong wrote: > In _require_scratch_dedupe, test the scratch device, not the testdev. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in th

Re: [PATCH 06/17] xfs: run xfs_repair at the end of each test

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:46:54PM -0700, Darrick J. Wong wrote: > Run xfs_repair twice at the end of each test -- once to rebuild > the btree indices, and again with -n to check the rebuild work. This looks fine to me in general, but shouldn't we have specific tests that test the rebuilding in a

Re: [PATCH 09/17] common/dmerror: fix mount option issues

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:13PM -0700, Darrick J. Wong wrote: > Calling _mount doesn't work when we want to add mount options > such as realtime devices. Since it's just a normal scratch device > mount except for the source device, just call _scratch_mount with > SCRATCH_DEV set to the dmerror

Re: [PATCH 10/17] xfs/179: use scratch device helpers

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:19PM -0700, Darrick J. Wong wrote: > Use the helper functions for scratch devices. This fixes a problem > where xfs/179 fails when there's a realtime device. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this

Re: [PATCH 08/17] xfs/129: fix post-metadump remounting idiocy

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:07PM -0700, Darrick J. Wong wrote: > Use the standard _scratch_mount to mount the filesystem from the restored > image, instead of trying to call mount directly. This is needed in case > we had custom mount options (like rtdev). > > Signed-off-by: Darrick J. Wong L

Re: [PATCH 11/17] xfs/234: use scratch device helpers

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:26PM -0700, Darrick J. Wong wrote: > Use the helper functions for scratch devices. This fixes a problem > where xfs/234 fails when there's a realtime device. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this

Re: [PATCH 12/17] reflink: test cross-mountpoint reflink and dedupe

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:47:32PM -0700, Darrick J. Wong wrote: > Test sharing blocks via reflink and dedupe between two different > mountpoints of the same filesystem. This shouldn't work, since > we don't allow cross-mountpoint functions. > > Signed-off-by: Darrick J. Wong Looks fine, Revie

[PATCH 2/3] btrfs-progs: inspect: Introduce dump-send-stream subcommand

2016-07-31 Thread Qu Wenruo
Introduce a new subcommand "dump-send-stream" for "inspect-internal" command group. It will exam and output all operations inside a send stream. It's quite a useful tool to learn and dig kernel send stream. Signed-off-by: Qu Wenruo --- Documentation/btrfs-inspect-internal.asciidoc | 8 +++ Mak

[PATCH 3/3] btrfs-progs: Remove send-test tool

2016-07-31 Thread Qu Wenruo
Since new "inspect dump-send" has better output and structure, it's time to remove old and function-weak send-test tool. New "inspect dump-send" can handle them all better. Signed-off-by: Qu Wenruo --- Makefile.in | 6 +- send-test.c | 447 -

[PATCH 1/3] btrfs-progs: Introduce new send-dump object

2016-07-31 Thread Qu Wenruo
Introduce send-dump.[ch] which implements a new btrfs_send_ops to exam and output all operations inside a send stream. It has a better output format than the old and no longer compilable send-test tool, but still tries to be script friendly. Provides the basis for later "inspect-internal dump-sen

Re: [PATCH 16/17] xfs/122: add the realtime rmapbt inode and btree fields

2016-07-31 Thread Christoph Hellwig
On Thu, Jul 21, 2016 at 04:48:00PM -0700, Darrick J. Wong wrote: > Add the on-disk structures added by the realtime rmapbt. > > Signed-off-by: Darrick J. Wong Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a m