On 2017年09月27日 14:34, Su Yue wrote:
The Annotation of repair_root_items():
"This must be run before any other repair code - not doing it so,
makes other repair code delete or modify backrefs in the extent tree
for example, which will result in an inconsistent fs after repairing
the root items."
The Annotation of repair_root_items():
"This must be run before any other repair code - not doing it so,
makes other repair code delete or modify backrefs in the extent tree
for example, which will result in an inconsistent fs after repairing
the root items."
However, the rule was broken by commit
The Annotation of repair_root_items():
"This must be run before any other repair code - not doing it so,
makes other repair code delete or modify backrefs in the extent tree
for example, which will result in an inconsistent fs after repairing
the root items."
However, the rule was broken by commit
On Tue, 26 Sep 2017, Duncan wrote:
consider it worth having. No backups means you are defining the data to
be of less value than the time/trouble/resources to make the backup, so
loss is never a big deal, because either you either have a backup if you
I know importance of backups, and this pr
On 26.09.2017 20:39, David Sterba wrote:
> On Tue, Sep 26, 2017 at 05:27:41PM +0300, Nikolay Borisov wrote:
>> btrfs_update_root can fail for any number of reasons, however the only error
>> handling we do is to revert the modified flags, yet we do not abort the
>> transaction but proceed to comm
Currently when a read-only snapshot is received and subsequently its ro property
is set to false i.e. switched to rw-mode the received_uuid of that subvol
remains
intact. However, once the received volume is switched to RW mode we cannot
guaranteee that it contains the same data, so it makes sense
On Tue, Sep 26, 2017 at 05:18:51PM -0700, Liu Bo wrote:
> On Tue, Sep 26, 2017 at 04:37:52PM -0700, Liu Bo wrote:
> > On Tue, Sep 26, 2017 at 05:02:36PM +0800, Eryu Guan wrote:
> > > On Fri, Sep 22, 2017 at 05:21:27PM -0600, Liu Bo wrote:
> > > > We had a bug in btrfs compression code which could e
btrfs_init_new_device() calls btrfs_attach_transaction() to
commit sys chunks, however take the error path out if it fails.
Signed-off-by: Anand Jain
---
fs/btrfs/volumes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index fad3b10
On 09/27/2017 01:49 AM, David Sterba wrote:
On Tue, Sep 26, 2017 at 08:57:47PM +0800, Qu Wenruo wrote:
On 2017年09月26日 16:41, Anand Jain wrote:
When new device is being added to seed FS, seed FS is marked writable,
but when we fail to bring in the new device, we missed to undo the
writable p
While looking at the transaction code and various pattern I came across some
problems which this series aim to fix.
Patch 1 just removes some redundant code.
Patch 2 adds a missing btrfs_abort_transaction, otherwise we don't properly
close out the transaction. I believe this could lead to btrf
If btrfs_transaction_commit fails it will proceed to call cleanup_transaction,
which in turn already does btrfs_abort_transaction. So let's remove the
unnecessary code duplication.
Signed-off-by: Nikolay Borisov
---
fs/btrfs/ioctl.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/fs/btrf
In case we failed the btrfs_uuid_tree_add we want to abort and end the
transaction,
currently the code only does btrfs_abort_transaction and then bails out without
calling either btrfs_transaction_commit (which handles the aborted case) or
btrfs_end_transaction. Fix it by eliminating the wrong lab
btrfs_rm_dev_item calls several function under an activa transaction, however
it fails to abort it if an error happens. Fix this by adding respective
btrfs_abort_transaction calls
Signed-off-by: Nikolay Borisov
---
fs/btrfs/volumes.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
d
On Tue, Sep 26, 2017 at 04:40:09PM -0400, Josef Bacik wrote:
> We pass in a pointer in our send arg struct, this means the struct size
> doesn't
> match with 32bit user space and 64bit kernel space. Fix this by adding a
> compat
> mode and doing the appropriate conversion.
How does this differ
On Thu, Sep 07, 2017 at 11:22:20AM -0600, Liu Bo wrote:
> This was intended to congest higher layers to not send bios, but as
>
> 1) the congested bit has been taken by writeback
Can you please be more specific here?
> 2) and no one is waiting for %nr_async_bios down to zero,
>
> we can safely
On 2017年09月27日 17:50, Anand Jain wrote:
btrfs_init_new_device() calls btrfs_attach_transaction() to
commit sys chunks, however take the error path out if it fails.
Signed-off-by: Anand Jain
Reviewed-by: Qu Wenruo
Thanks,
Qu
---
fs/btrfs/volumes.c | 3 ++-
1 file changed, 2 insertions
On 2017-09-26 18:46, Ferry Toth wrote:
Op Tue, 26 Sep 2017 15:52:44 -0400, schreef Austin S. Hemmelgarn:
On 2017-09-26 12:50, Ferry Toth wrote:
Looking at the Phoronix benchmark here:
https://www.phoronix.com/scan.php?page=article&item=linux414-bcache-
raid&num=2
I think it might be idle hop
On Thu, Sep 07, 2017 at 11:22:22AM -0600, Liu Bo wrote:
> Now that we have the combo of flushing twice, which can make sure IO
> have started since the second flush will wait for page lock which
> won't be unlocked unless setting page writeback and queuing ordered
> extents, we don't need %async_su
On Fri, Aug 25, 2017 at 12:18:40PM +0300, Timofey Titovets wrote:
> Move heuristic to external file
> Implement compression workspaces support for
> heuristic resources
I think the file compression.c is suitable, there's not that much code
the heuristic adds and it its only related to compresessio
On Fri, Aug 25, 2017 at 12:18:41PM +0300, Timofey Titovets wrote:
> Heuristic workspace:
> - Add bucket for storing byte type counters
> - Add sample array for storing partial copy of
>input data range
> - Add counter for store current sample size to workspace
>
> Signed-off-by: Timofey Tit
On Fri, Aug 25, 2017 at 12:18:42PM +0300, Timofey Titovets wrote:
> Copy sample data from input data range to sample buffer
> then calculate byte type count for that sample into bucket.
>
> Signed-off-by: Timofey Titovets
> ---
> fs/btrfs/heuristic.c | 38 +-
>
On Fri, Aug 25, 2017 at 12:18:43PM +0300, Timofey Titovets wrote:
> Walk over data sample and use memcmp to detect
> repeated data (like zeroed)
>
> Signed-off-by: Timofey Titovets
> ---
> fs/btrfs/heuristic.c | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/fs/btrfs/h
On Fri, Aug 25, 2017 at 12:18:44PM +0300, Timofey Titovets wrote:
> Calculate byte set size for data sample:
> Calculate how many unique bytes has been in sample
> By count all bytes in bucket with count > 0
> If byte set low (~25%), data are easily compressible
>
> Signed-off-by: Timofey Titovets
On Fri, Aug 25, 2017 at 12:18:45PM +0300, Timofey Titovets wrote:
> Calculate byte core set for data sample:
> Sort bucket's numbers in decreasing order
> Count how many numbers use 90% of sample
> If core set are low (<=25%), data are easily compressible
> If core set high (>=80%), data are not co
On Fri, Aug 25, 2017 at 12:18:45PM +0300, Timofey Titovets wrote:
> Calculate byte core set for data sample:
> Sort bucket's numbers in decreasing order
> Count how many numbers use 90% of sample
> If core set are low (<=25%), data are easily compressible
> If core set high (>=80%), data are not co
On Wed, Sep 27, 2017 at 11:48:59AM +0300, Nikolay Borisov wrote:
> On 26.09.2017 20:39, David Sterba wrote:
> > On Tue, Sep 26, 2017 at 05:27:41PM +0300, Nikolay Borisov wrote:
> >> btrfs_update_root can fail for any number of reasons, however the only
> >> error
> >> handling we do is to revert t
26.09.2017 10:31, Lukas Pirl пишет:
> On 09/25/2017 06:11 PM, linux-bt...@oh3mqu.pp.hyper.fi wrote as excerpted:
>> After a long googling (about more complex situations) I suddenly
>> noticed "device sdb" WTF??? Filesystem is mounted from /dev/md3 (sdb
>> is part of that mdraid) so btrfs should no
On Wed, Sep 27, 2017 at 05:50:52PM +0800, Anand Jain wrote:
> btrfs_init_new_device() calls btrfs_attach_transaction() to
> commit sys chunks, however take the error path out if it fails.
>
> Signed-off-by: Anand Jain
> ---
> fs/btrfs/volumes.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 delet
On Tue, Sep 26, 2017 at 03:14:27PM +0300, Nikolay Borisov wrote:
>
>
> On 26.09.2017 11:47, Anand Jain wrote:
> > 1/2 fixes a bug which failed to reset writable when sprouting failed
> > 2/2 fixes BUG_ON in btrfs_init_new_device()
> >
> > Anand Jain (2):
> > btrfs: undo writable when sprouting
On 27.09.2017 17:22, David Sterba wrote:
> On Tue, Sep 26, 2017 at 03:14:27PM +0300, Nikolay Borisov wrote:
>>
>>
>> On 26.09.2017 11:47, Anand Jain wrote:
>>> 1/2 fixes a bug which failed to reset writable when sprouting failed
>>> 2/2 fixes BUG_ON in btrfs_init_new_device()
>>>
>>> Anand Jain (
On 27.09.2017 17:00, David Sterba wrote:
> On Wed, Sep 27, 2017 at 11:48:59AM +0300, Nikolay Borisov wrote:
>> On 26.09.2017 20:39, David Sterba wrote:
>>> On Tue, Sep 26, 2017 at 05:27:41PM +0300, Nikolay Borisov wrote:
btrfs_update_root can fail for any number of reasons, however the only
On Wed, Sep 27, 2017 at 12:52:50PM +0200, David Sterba wrote:
> On Tue, Sep 26, 2017 at 04:40:09PM -0400, Josef Bacik wrote:
> > We pass in a pointer in our send arg struct, this means the struct size
> > doesn't
> > match with 32bit user space and 64bit kernel space. Fix this by adding a
> > co
We pass in a pointer in our send arg struct, this means the struct size doesn't
match with 32bit user space and 64bit kernel space. Fix this by adding a compat
mode and doing the appropriate conversion.
Signed-off-by: Josef Bacik
---
- move the args_32 out of the uapi header, they don't need it.
On Wed, Sep 27, 2017 at 11:03:48AM +0900, Misono, Tomohiro wrote:
> Fix subvol del --commit-after to work properly:
> - SYNC ioctl will be issued even when last delete is failed
> - SYNC ioctl will be issued on each file system only once in the end
>
> To achieve this, get_fsid() and add_seen_fs
On Wed, Sep 27, 2017 at 11:00:35AM +0900, Misono, Tomohiro wrote:
> Fix subvol del --commit-after to work properly:
> - SYNC ioctl will be issued even when last delete is failed
> - SYNC ioctl will be issued on each file system only once in the end
>
> To achieve this, each deleted subvol's (par
We want only pages from given range in btree_write_cache_pages() and
extent_write_cache_pages(). Use pagevec_lookup_range_tag() instead of
pagevec_lookup_tag() and remove unnecessary code.
CC: linux-btrfs@vger.kernel.org
CC: David Sterba
Reviewed-by: David Sterba
Signed-off-by: Jan Kara
---
fs
On Mon, Sep 25, 2017 at 07:15:30AM -0400, Austin S. Hemmelgarn wrote:
> On 2017-09-24 10:08, Goffredo Baroncelli wrote:
> > On 09/24/2017 12:10 PM, Anand Jain wrote:
A lot of points in this thread, let me address them here.
I don't want to remove --rootdir functionality, the fix that's being
prop
On Wed, Sep 27, 2017 at 05:46:44PM +0800, Eryu Guan wrote:
> On Tue, Sep 26, 2017 at 05:18:51PM -0700, Liu Bo wrote:
> > On Tue, Sep 26, 2017 at 04:37:52PM -0700, Liu Bo wrote:
> > > On Tue, Sep 26, 2017 at 05:02:36PM +0800, Eryu Guan wrote:
> > > > On Fri, Sep 22, 2017 at 05:21:27PM -0600, Liu Bo
We had a bug in btrfs compression code which could end up with a
kernel panic.
This is adding a regression test for the bug and I've also sent a
kernel patch to fix the bug.
The patch is "Btrfs: fix kernel oops while reading compressed data".
Signed-off-by: Liu Bo
---
v3: - Enable task-filter i
On Sun, Sep 10, 2017 at 05:22:14PM -0700, Marc MERLIN wrote:
> On Sun, Sep 10, 2017 at 01:16:26PM +, Josef Bacik wrote:
> > Great, if the free space cache is fucked again after the next go
> > around then I need to expand the verifier to watch entries being added
> > to the cache as well. Than
A bunch of processes hung, so I rebooted. Upon reboot:
> btrfs check /dev/sdb
Checking filesystem on /dev/sdb
UUID: d53460f0-40b8-4e5c-8172-cb4b7cd26a28
checking extents
checking free space cache
checking fs roots
checking csums
checking root refs
checking quota groups
ERROR: out of memory
ERROR:
Hi,
I was trying to use AMDGPU-PRO's OpenCL stack (with the mainline 4.12.13
kernel) while it suddently crashed the whole system, not even magic sysrq
keys did work anymore.
With no surprise, at the next reboot I found several btrfs warnings (see
https://paste.pound-python.org/show/S5zBG2tXZUTL
On 2017年09月28日 00:20, David Sterba wrote:
On Mon, Sep 25, 2017 at 07:15:30AM -0400, Austin S. Hemmelgarn wrote:
On 2017-09-24 10:08, Goffredo Baroncelli wrote:
On 09/24/2017 12:10 PM, Anand Jain wrote:
A lot of points in this thread, let me address them here.
I don't want to remove --rootd
Output the bad value and expected good value (or its alignment).
Signed-off-by: Qu Wenruo
---
fs/btrfs/tree-checker.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index 4f847955fdc6..52e9ab8c2a79 100644
--- a/f
Use inline function to replace macro since we don't need
stringification.
(Macro still exist until all caller get updated)
And add more info about the error.
For nr_items error, report if it's too large or too small, and output
valid value range.
For blk pointer, added a new alignment checker.
Output the invalid member name and its bad value, along with its
expected value range or alignment.
Signed-off-by: Qu Wenruo
---
fs/btrfs/tree-checker.c | 92 +
1 file changed, 70 insertions(+), 22 deletions(-)
diff --git a/fs/btrfs/tree-checker.c
The patchset can be fetched from github:
https://github.com/adam900710/linux/tree/checker_enhance
It's based on David's misc-next branch, with following commit as base:
a5e50b4b444c ("btrfs: Add checker for EXTENT_CSUM")
According to David's suggestion, enhance the output format of tree block
val
It's no doubt the comprehensive tree block checker will become larger
and larger, so move them into their own file is quite reasonable.
Signed-off-by: Qu Wenruo
---
fs/btrfs/Makefile | 2 +-
fs/btrfs/ctree.h| 4 +
fs/btrfs/disk-io.c | 284 +-
Enhance the output to print:
1) Reason
2) Bad value
If reason can't explain enough
3) Good value (range)
Signed-off-by: Qu Wenruo
---
fs/btrfs/tree-checker.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree
On 28.09.2017 06:36, Qu Wenruo wrote:
> Use inline function to replace macro since we don't need
> stringification.
> (Macro still exist until all caller get updated)
>
> And add more info about the error.
>
> For nr_items error, report if it's too large or too small, and output
> valid value r
On 28.09.2017 06:36, Qu Wenruo wrote:
> Enhance the output to print:
> 1) Reason
> 2) Bad value
>If reason can't explain enough
> 3) Good value (range)
>
> Signed-off-by: Qu Wenruo
> ---
> fs/btrfs/tree-checker.c | 26 --
> 1 file changed, 20 insertions(+), 6 deleti
On 28.09.2017 06:36, Qu Wenruo wrote:
> Output the invalid member name and its bad value, along with its
> expected value range or alignment.
>
> Signed-off-by: Qu Wenruo
> ---
> fs/btrfs/tree-checker.c | 92
> +
> 1 file changed, 70 insertions(
From: Gu JinXiang
When quota disabled, btrfs qgroup show exit with a error message,
but the allocated memory is not freed.
By the way, this bug marked as issue#20 in github.
Signed-off-by: Gu JinXiang
---
cmds-qgroup.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
d
Hi,
I am so sorry for that this patch brings a new problem of double free in normal
scenes.
So I send a new patch .
Please revert this one and use the new patch.
> -Original Message-
> From: David Sterba [mailto:dste...@suse.cz]
> Sent: Tuesday, September 26, 2017 7:28 PM
> To: Gu, Jinxi
When new device is being added to seed FS, seed FS is marked writable,
but when we fail to bring in the new device, we missed to undo the
writable part. This patch fixes it.
Signed-off-by: Anand Jain
Reviewed-by: Nikolay Borisov
---
v4: none
v3: none
v2: add commit log
v1: moving sb->s_flags |=
Instead of BUG_ON return error to the caller. And handle the fail
condition by calling the abort transaction and going through the
error path.
Signed-off-by: Anand Jain
Reviewed-by: Nikolay Borisov
---
v4: none;
v3: meld this with
btrfs: cleanup btrfs_init_new_device()
v2: do not consolidat
btrfs_init_new_device() calls btrfs_attach_transaction() to
commit sys chunks, and it should error out if it fails.
Signed-off-by: Anand Jain
Reviewed-by: Qu Wenruo
---
v4: make this patch as part of this set.
avoid double mutext unlock.
v3: not part of this set
v2: patch did not exist
v1: p
On 09/27/2017 10:26 PM, Nikolay Borisov wrote:
On 27.09.2017 17:22, David Sterba wrote:
On Tue, Sep 26, 2017 at 03:14:27PM +0300, Nikolay Borisov wrote:
On 26.09.2017 11:47, Anand Jain wrote:
1/2 fixes a bug which failed to reset writable when sprouting failed
2/2 fixes BUG_ON in btrfs_i
58 matches
Mail list logo
