Re: Is it safe to use btrfs on top of different types of devices?

2017-10-15 Thread Zoltán Ivánfi
Hi, Thanks for the replies. As you both pointed out, I shouldn't have described the issue having to do with hotplugging. I got confused by this use-case being somewhat emphasized in the description of the bug I linked to. As for the question of why I think that I got bitten by that bug in particu

Re: Is it safe to use btrfs on top of different types of devices?

2017-10-15 Thread Duncan
Zoltán Ivánfi posted on Sun, 15 Oct 2017 10:30:52 +0200 as excerpted: > You assumed correctly that what I really wanted to ask about was btrfs > on SATA+USB, thanks for answering that questions as well. Based on your > replies I feel assured that btrfs should not be affected by this > particular i

Re: [PATCH 3/4] Btrfs: handle unaligned tail of data ranges more efficient

2017-10-15 Thread Timofey Titovets
May be then just add a comment at least at one of that functions? Like: /* * Handle unaligned end, end is inclusive, so always unaligned */ Or something like: /* * It's obvious, kernel use paging, so range * Almost always have aligned start like 0 * and unaligned end like 8192 - 1 */ Or we

Re: Why isnt NOCOW attributes propogated on snapshot transfers?

2017-10-15 Thread Qu Wenruo
On 2017年10月15日 09:19, Cerem Cem ASLAN wrote: `btrfs send | btrfs receive` removes NOCOW attributes. Is it a bug or a feature? If it's a feature, how can we keep these attributes if we need to? It seems that, current send doesn't have support for extra inode flags. Send can only send out c/m/

Re: [PATCH v2 3/3] btrfs-progs: device: add remove missing-all

2017-10-15 Thread Anand Jain
On 10/13/2017 01:27 PM, Duncan wrote: Misono, Tomohiro posted on Wed, 11 Oct 2017 11:18:50 +0900 as excerpted: Add 'btrfs remove missing-all' to remove all the missing devices at once for improving usability. Example: sudo mkfs.btrfs -f -d raid1 /dev/sdb1 /dev/sdb2 /dev/sdb3 /dev/sdb4 su

Re: [PATCH v2] Btrfs: avoid losing data raid profile when deleting a device

2017-10-15 Thread Anand Jain
On 10/14/2017 04:51 AM, Liu Bo wrote: On Wed, Oct 11, 2017 at 10:38:50AM +0300, Nikolay Borisov wrote: On 10.10.2017 20:53, Liu Bo wrote: We've avoided data losing raid profile when doing balance, but it turns out that deleting a device could also result in the same problem This fixes the

Re: [PATCH v2 3/3] btrfs-progs: device: add remove missing-all

2017-10-15 Thread Misono, Tomohiro
On 2017/10/13 14:27, Duncan wrote: > Misono, Tomohiro posted on Wed, 11 Oct 2017 11:18:50 +0900 as excerpted: > >> Add 'btrfs remove missing-all' to remove all the missing devices at once >> for improving usability. >> >> Example: >> sudo mkfs.btrfs -f -d raid1 /dev/sdb1 /dev/sdb2 /dev/sdb3 /dev/

Re: [PATCH v2 3/3] btrfs-progs: device: add remove missing-all

2017-10-15 Thread Misono, Tomohiro
On 2017/10/16 12:30, Anand Jain wrote: > > > On 10/13/2017 01:27 PM, Duncan wrote: >> Misono, Tomohiro posted on Wed, 11 Oct 2017 11:18:50 +0900 as excerpted: >> >>> Add 'btrfs remove missing-all' to remove all the missing devices at once >>> for improving usability. >>> >>> Example: >>> sudo

[PATCH v3 1/2] btrfs-progs: device: add description of alias to help message

2017-10-15 Thread Misono, Tomohiro
State the 'delete' is the alias of 'remove' as the man page says. Signed-off-by: Tomohiro Misono Reviewed-by: Satoru Takeuchi --- cmds-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-device.c b/cmds-device.c index 4337eb2..3b6b985 100644 --- a/cmds-device.c +++

[PATCH v3 2/2] btrfs-progs: doc: add description of missing and example of device remove

2017-10-15 Thread Misono, Tomohiro
This patch updates help/document of "btrfs device remove" in two points: 1. Add explanation of 'missing' for 'device remove'. This is only written in wikipage currently. (https://btrfs.wiki.kernel.org/index.php/Using_Btrfs_with_Multiple_Devices) 2. Add example of device removal in the man documen

[PATCH v3 0/2] btrfs-progs: doc: update btrfs device remove

2017-10-15 Thread Misono, Tomohiro
This updates help/doc of "btrfs device remove". First patch adds the explanation that delete is the alias of remove to help message. Second patch adds the description of "remove missing", which is currently only written in wikipage, and example of device removal. v1->v2: split the patch and upd

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-15 Thread Anand Jain
On 10/14/2017 02:46 AM, Liu Bo wrote: On Sun, Oct 08, 2017 at 10:23:58PM +0800, Anand Jain wrote: On 10/07/2017 07:56 AM, Liu Bo wrote: On Thu, Oct 05, 2017 at 09:56:59PM +0800, Anand Jain wrote: On 10/05/2017 04:11 AM, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain

Re: [PATCH v8 1/2] btrfs: introduce device dynamic state transition to failed

2017-10-15 Thread Anand Jain
On 10/14/2017 02:47 AM, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:19PM +0800, Anand Jain wrote: From: Anand Jain This patch provides helper functions to force a device to failed, and we need it for the following reasons, 1) a. It can be reported that device has failed when it does and

Re: [PATCH v2 3/3] btrfs-progs: device: add remove missing-all

2017-10-15 Thread Anand Jain
On 10/16/2017 12:35 PM, Misono, Tomohiro wrote: On 2017/10/16 12:30, Anand Jain wrote: On 10/13/2017 01:27 PM, Duncan wrote: Misono, Tomohiro posted on Wed, 11 Oct 2017 11:18:50 +0900 as excerpted: Add 'btrfs remove missing-all' to remove all the missing devices at once for improving us

Re: [PATCH] Fstest: btrfs/151: test if device delete ends up with losing raid profile

2017-10-15 Thread Nikolay Borisov
On 13.10.2017 21:08, Liu Bo wrote: > On Thu, Oct 12, 2017 at 03:06:57PM +0800, Eryu Guan wrote: >> On Mon, Oct 09, 2017 at 11:39:21AM -0600, Liu Bo wrote: >>> Currently running 'btrfs device delete' can end up with losing data raid >>> profile (if any), this test is to reproduce the problem. >>>