Re: [PATCH v4 00/13] Add support for other checksums

2019-06-04 Thread Johannes Thumshirn
On Mon, Jun 03, 2019 at 08:30:22PM +0200, David Sterba wrote: > On Mon, Jun 03, 2019 at 04:58:46PM +0200, Johannes Thumshirn wrote: > > This patchset add support for adding new checksum types in BTRFS. > > V4 looks good to me, with a few minor fixups added to topic branch, > including the sha256 p

Re: [PATCH v4 00/13] Add support for other checksums

2019-06-04 Thread Johannes Thumshirn
On Mon, Jun 03, 2019 at 09:56:06PM +0200, waxhead wrote: > > > Johannes Thumshirn wrote: > > This patchset add support for adding new checksum types in BTRFS. > > > > Currently BTRFS only supports CRC32C as data and metadata checksum, which is > > good if you only want to detect errors due to da

Re: [PATCH v4 00/13] Add support for other checksums

2019-06-04 Thread David Sterba
On Tue, Jun 04, 2019 at 09:37:30AM +0200, Johannes Thumshirn wrote: > > Let me summarize the current satus: > > > > for strong hash we have SHA256 and BLAKE2. For the fast hash xxhash and > > murmur3 have been suggested. Let me add XXH3 and xxh128 for now (they're > > not finalized yet). > > I kn

Re: [PATCH v4 00/13] Add support for other checksums

2019-06-04 Thread David Sterba
On Tue, Jun 04, 2019 at 09:37:30AM +0200, Johannes Thumshirn wrote: > On Mon, Jun 03, 2019 at 08:30:22PM +0200, David Sterba wrote: > > On Mon, Jun 03, 2019 at 04:58:46PM +0200, Johannes Thumshirn wrote: > > > This patchset add support for adding new checksum types in BTRFS. > > > > V4 looks good

Re: [PATCH v4 00/13] Add support for other checksums

2019-06-04 Thread David Sterba
On Mon, Jun 03, 2019 at 09:56:06PM +0200, waxhead wrote: > Johannes Thumshirn wrote: > > This patchset add support for adding new checksum types in BTRFS. > > > > Currently BTRFS only supports CRC32C as data and metadata checksum, which is > > good if you only want to detect errors due to data cor

Re: [PATCH] btrfs: don't end the transaction for delayed refs in throttle

2019-06-04 Thread Josef Bacik
On Tue, Jun 04, 2019 at 08:31:23AM +0800, Qu Wenruo wrote: > > > On 2019/6/4 上午1:36, Josef Bacik wrote: > > On Mon, Jun 03, 2019 at 02:53:00PM +0800, Qu Wenruo wrote: > >> > >> > >> On 2019/2/13 上午12:03, David Sterba wrote: > >>> On Thu, Jan 24, 2019 at 09:31:43AM -0500, Josef Bacik wrote: >

5.2rc2, circular lock warning systemd-journal and btrfs_page_mkwrite

2019-06-04 Thread Chris Murphy
This is on Fedora Rawhide systemd-242-3.git7a6d834.fc31.x86_64 kernel 5.2.0-0.rc2.git1.2.fc31.x86_64 Pretty and complete log: https://drive.google.com/open?id=1vhnIki9lpiWK8T5Qsl81_RToQ8CFdnfU Probably MUA wrapped, and excerpt only: [7.816458] fmac.local systemd[1]: Starting Flush Journal to

Re: [PATCH 1/4] zstd: pass pointer rathen than structure to functions

2019-06-04 Thread Andrew Morton
On Mon, 3 Jun 2019 14:32:03 +0530 Maninder Singh wrote: > currently params structure is passed in all functions, which increases > stack usage in all the function and lead to stack overflow on target like > ARM with kernel stack size of 8 KB so better to pass pointer. > > Checked for ARM: > >