On Tue, 17 Dec 2013 10:33:36 +0800, Anand Jain wrote:
this patch will handle the strerror reporting of the error instead of
printing errno, and also replaced the BUG_ON with the error handling
Signed-off-by: Anand Jain anand.j...@oracle.com
---
v2: commit update
---
cmds-device.c | 7
+ ret = btrfs_prepare_device(fddstdev, dstdev, 1, dstdev_block_count, 0,
+mixed, 0);
close(fddstdev);
+ if (ret)
+ goto leave_with_error;
fddstdev = -1;
yeah moved this 3 lines up. thanks.
You change the code
Mhmm. Thanks. I'm begining to understand ;)
Still : how can I see/know that id 5 is mapped to id 0 ? And why doing
this? For what purpose? (is it a default btrfs behavior or is it set
by the Ubuntu installer?)
2013/12/17 Chris Murphy li...@colorremedies.com:
On Dec 16, 2013, at 4:54 PM, Nicolas
On Tue, Dec 17, 2013 at 09:30:11AM +0100, Nicolas Michel wrote:
Mhmm. Thanks. I'm begining to understand ;)
Still : how can I see/know that id 5 is mapped to id 0 ? And why doing
this? For what purpose? (is it a default btrfs behavior or is it set
by the Ubuntu installer?)
It's always
On tue, 17 Dec 2013 12:01:12 +0800, Miao Xie wrote:
We met the following oops when doing space balance:
kobject (88081b590278): tried to init an initialized object, something
is seriously wrong.
...
Call Trace:
[81937262] dump_stack+0x49/0x5f
[8137d259]
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix this problem, i have two ideas.
1.make btrfs snapshot ioctl support passing source subvolume's objectid
2.when we want to using interval subvolume path, we mount it other place
that use subvolume 5 as its
The struct async_sched is not used by any codes and can be removed.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
Reviewed-by: Josef Bacik jba...@fusionio.com
---
Changelog:
v1-v2:
None.
v2-v3:
None.
v3-v4:
None:
---
fs/btrfs/volumes.c | 7 ---
1 file changed, 7 deletions(-)
diff
Add a new btrfs_workqueue_struct which use kernel workqueue to implement
most of the original btrfs_workers, to replace btrfs_workers.
With this patchset, redundant workqueue codes are replaced with kernel
workqueue infrastructure, which not only reduces the code size but also the
effort to
The original btrfs_workers has thresholding functions to dynamically
create or destroy kthreads.
Though there is no such function in kernel workqueue because the worker
is not created manually, we can still use the workqueue_set_max_active
to simulated the behavior, mainly to achieve a better HDD
Much like the fs_info-workers, replace the fs_info-submit_workers
use the same btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
None
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h | 2 +-
fs/btrfs/disk-io.c
Replace the fs_info-scrub_* with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace scrub_*.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h | 6 ++--
Since the _struct suffix is mainly used for distinguish the differnt
btrfs_work between the original and the newly created one,
there is no need using the suffix since all btrfs_workers are changed
into btrfs_workqueue.
Also this patch fixed some codes whose code style is changed due to the
too
Replace the fs_info-readahead_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace readahead_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
Since all the btrfs_worker is replaced with the newly created
btrfs_workqueue, the old codes can be easily remove.
Signed-off-by: Quwenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Reuse the old async-thred.[ch] files.
v3-v4:
- Reuse the old WORK_* bits.
---
Replace the fs_info-endio_* workqueues with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace endio_*.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h
Add high priority function to btrfs_workqueue.
This is implemented by embedding a btrfs_workqueue into a
btrfs_workqueue and use some helper functions to differ the normal
priority wq and high priority wq.
So the high priority wq is completely independent from the normal
workqueue.
Replace the fs_info-delayed_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
None
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h | 2 +-
fs/btrfs/delayed-inode.c | 10
Replace the fs_info-fixup_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace fixup_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
Replace the fs_info-qgroup_rescan_worker with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace qgroup_rescan_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
Replace the fs_info-rmw_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace rmw_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h
Much like the fs_info-workers, replace the fs_info-delalloc_workers
use the same btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
None
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h | 2 +-
Use the newly created btrfs_workqueue_struct to replace the original
fs_info-workers
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
None
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
fs/btrfs/ctree.h | 2 +-
fs/btrfs/disk-io.c | 41
Replace the fs_info-submit_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace submit_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
Use kernel workqueue to implement a new btrfs_workqueue_struct, which
has the ordering execution feature like the btrfs_worker.
The func is executed in a concurrency way, and the
ordred_func/ordered_free is executed in the sequence them are queued
after the corresponding func is done.
The new
Replace the fs_info-cache_workers with the newly created
btrfs_workqueue.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
Changelog:
v1-v2:
None
v2-v3:
- Use the btrfs_workqueue_struct to replace caching_workers.
v3-v4:
- Use the simplified btrfs_alloc_workqueue API.
---
a clean up patch, the BTRFS_STRIPE_LEN is been duplicated across
btrfs-progs, the kernel defines it in volume.h so do the same
for progs.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
v2: commit update
btrfs-convert.c | 19 +--
chunk-recover.c |1 -
cmds-chunk.c
this patch will handle the strerror reporting of the error instead of
printing errno, and also replaced the BUG_ON with the error handling
Signed-off-by: Anand Jain anand.j...@oracle.com
---
v3: fix per Stefan review, update error message
v2: commit update
cmds-device.c |7 +++
Signed-off-by: Anand Jain anand.j...@oracle.com
---
v3: volume.c needs BTRFS_STRIPE_LEN as well
v2: commit update
btrfs-convert.c |2 +-
btrfs-image.c |2 +-
volumes.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/btrfs-convert.c b/btrfs-convert.c
Hello Michael,
I sent a patch to fix the issue(cc you already), can you have a try
and see if it fix your problem.
Thanks,
Wang
On 12/17/2013 09:28 AM, Michael Welsh Duggan wrote:
Wang Shilong wangshilong1...@gmail.com writes:
Hello Michael,
I built the new btrfs-progs 3.12 recently. I
Hello David,
Nice work, Before this patch for btrfs send.
we have to join a transaction to avoid commit root changed.
I send a plus patch that remove transaction protection from btrfs send.
and a little comment below.
[...]
On 12/17/2013 12:34 AM, David Sterba wrote:
All the subvolues that
Since daivd did the work that force us to use readonly snapshot,
we can safely remove transaction protection from btrfs send.
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com
---
fs/btrfs/send.c | 33 -
1 file changed, 33 deletions(-)
diff --git
On Tue, Dec 17, 2013 at 07:58:24PM +0800, Wang Shilong wrote:
Nice work, Before this patch for btrfs send.
we have to join a transaction to avoid commit root changed.
That sounds like a good improvement.
I send a plus patch that remove transaction protection from btrfs send.
and a little
On Tue, Dec 17, 2013 at 01:19:39AM +, Chris Mason wrote:
On Tue, 2013-12-17 at 02:06 +0100, David Sterba wrote:
On Mon, Dec 16, 2013 at 01:26:26PM -0500, Josef Bacik wrote:
I need to create a fake tree to test qgroups and I don't want to have to
setup a
fake btree_inode. The fact
Subject: [PATCH 4/3] btrfs: check balance of send_in_progress
Warn if the balance goes below zero, which appears to be unlikely
though. Otherwise cleans up the code a bit.
Signed-off-by: David Sterba dste...@suse.cz
---
A followup to 3/3 that adds the check if send_in_progress is not going
On Tue, Dec 17, 2013 at 04:37:35PM +0800, Anand Jain wrote:
+zero_dev_error:
+ if (ret) {
+ ret 0 ?
+ fprintf(stderr, ERROR: failed to zero device start '%s' -
%s\n,
+ file, strerror(-ret)) :
+ fprintf(stderr, ERROR: failed to zero device
On Fri, Dec 13, 2013 at 05:59:46PM +0800, Gui Hecheng wrote:
Originally, btrfstune will fail without any options and just exit
with no failure prompt.
Works for me:
$ ./btrfstune
usage: btrfstune [options] device
-S valueenable/disable seeding
-r enable
On 12/16/2013 08:06 PM, David Sterba wrote:
On Mon, Dec 16, 2013 at 01:26:26PM -0500, Josef Bacik wrote:
I need to create a fake tree to test qgroups and I don't want to have to setup a
fake btree_inode. The fact is we only use the radix tree for the fs_info, so
everybody else who allocates
Hi dave,
On Fri, Dec 13, 2013 at 05:59:46PM +0800, Gui Hecheng wrote:
Originally, btrfstune will fail without any options and just exit
with no failure prompt.
Works for me:
$ ./btrfstune
usage: btrfstune [options] device
-S valueenable/disable seeding
-r
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix this problem, i have two ideas.
1.make btrfs snapshot ioctl support passing source subvolume's objectid
2.when we want to using interval
On Tue, Dec 17, 2013 at 09:56:07AM -0500, Josef Bacik wrote:
* alloc_extent_buffer uses radix_preload that turns off preepmtion by
itself, so the lock here would be pointless
Except you still need a lock for other inserts.
* release_extent_buffer locks around radix_tree_delete, here a rcu
Hi dave,
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix this problem, i have two ideas.
1.make btrfs snapshot ioctl support passing source subvolume's objectid
2.when we want to using
On Tue, Dec 17, 2013 at 3:27 PM, David Sterba dste...@suse.cz wrote:
On Mon, Dec 16, 2013 at 05:03:25PM +, Filipe David Manana wrote:
On Mon, Dec 16, 2013 at 2:34 PM, David Sterba dste...@suse.cz wrote:
On Fri, Dec 13, 2013 at 07:39:34PM +, Filipe David Borba Manana wrote:
From the
On Mon, Dec 16, 2013 at 10:17:18AM -0600, Chandra Seetharaman wrote:
On Mon, 2013-12-16 at 14:32 +0200, saeed bishara wrote:
On Thu, Dec 12, 2013 at 1:38 AM, Chandra Seetharaman
sekha...@us.ibm.com wrote:
In order to handle multiple extent buffers per page, first we
need to create a way
On Mon, Dec 16, 2013 at 05:03:25PM +, Filipe David Manana wrote:
On Mon, Dec 16, 2013 at 2:34 PM, David Sterba dste...@suse.cz wrote:
On Fri, Dec 13, 2013 at 07:39:34PM +, Filipe David Borba Manana wrote:
From the compiler:
fs/btrfs/file.c: In function ‘prepare_pages.isra.18’:
David Sterba dste...@suse.cz writes:
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix this problem, i have two ideas.
1.make btrfs snapshot ioctl support passing source subvolume's objectid
It has occurred to me and others that something like BTRFS could be a good fit
to build an AFS fileserver directly on top of. The question is what facilities
would be needed from BTRFS to make this work?
So I thought I'd kick off a shopping list;-)
(1) 64-bit data version numbers that
On Tue, 2013-12-17 at 16:53 +, David Howells wrote:
It has occurred to me and others that something like BTRFS could be a good fit
to build an AFS fileserver directly on top of. The question is what
facilities
would be needed from BTRFS to make this work?
So I thought I'd kick off a
On Tue, Dec 17, 2013 at 04:53:16PM +, David Howells wrote:
It has occurred to me and others that something like BTRFS could be
a good fit to build an AFS fileserver directly on top of. The
question is what facilities would be needed from BTRFS to make this
work? So I thought I'd kick off a
Chris Mason c...@fb.com wrote:
Hmmm, what exactly are vnodes? Could we put them in xattrs?
vnode numbers are AFS's equivalent of inode numbers. Since they're one per
file, they could be the object filename.
Probably there would have to be a table of {vnode,latest_uniquifier} as the
Hugo Mills h...@carfax.org.uk wrote:
(1) 64-bit data version numbers that increase monotonically with
each write. Yes, this is likely to cause some performance
degredation as it introduces an ordering over data writes and
metadata writes to a file. Maybe writes can be batched to improve
On 12/12/13, Chris Mason c...@fb.com wrote:
For me anyway, data=dup in mixed mode is definitely an accident ;)
I personally think data dup is a false sense of security, but drives
have gotten so huge that it may actually make sense in a few
configurations.
Sure, it's not about any security
On Tue, 2013-12-17 at 17:47 +, David Howells wrote:
Hugo Mills h...@carfax.org.uk wrote:
(1) 64-bit data version numbers that increase monotonically with
each write. Yes, this is likely to cause some performance
degredation as it introduces an ordering over data writes and
On Tue, 2013-12-17 at 17:40 +, David Howells wrote:
Chris Mason c...@fb.com wrote:
Hmmm, what exactly are vnodes? Could we put them in xattrs?
vnode numbers are AFS's equivalent of inode numbers. Since they're one per
file, they could be the object filename.
Yes, in fact, the
I have been using btrfs for my /home partition on my home machine for
a few years now. I created the file system RAID1 using two disk
partitions. Recently I noticed btrfs fi df shows extra Data, System,
and Metadata allocations. And btrfs fi show indicates extra
allocations on one of my disk
Garry,
this is a known bug in mkfs.btrfs, the workaround for now is
to run balance on FS having some data. so that unused group-
profile will go away.
HTH, Anand
On 12/18/2013 10:03 AM, Garry T. Williams wrote:
I have been using btrfs for my /home partition on my home machine for
a few
On Tue, 17 Dec 2013 10:40:41 -0500, Michael Welsh Duggan wrote:
David Sterba dste...@suse.cz writes:
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix this problem, i have two ideas.
1.make
Since in David's commit 1104a8855, there is nothing really check the
super block now, the btrfs_check_super_valid function can be removed if
no one else needs the function.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
Cc: David Sterba dste...@suse.cz
---
fs/btrfs/disk-io.c | 18
Miao Xie mi...@cn.fujitsu.com writes:
On Tue, 17 Dec 2013 10:40:41 -0500, Michael Welsh Duggan wrote:
David Sterba dste...@suse.cz writes:
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our default subvolume, btrfs receive will fail to find
subvolume. To fix
Hello Michael,
On 12/18/2013 11:29 AM, Michael Welsh Duggan wrote:
Miao Xie mi...@cn.fujitsu.com writes:
On Tue, 17 Dec 2013 10:40:41 -0500, Michael Welsh Duggan wrote:
David Sterba dste...@suse.cz writes:
On Tue, Dec 17, 2013 at 05:13:49PM +0800, Wang Shilong wrote:
If we change our
Originally, btrfstune will fail without any options, like this:
# btrfstune /dev/sdb
An error prompt usage should show up upon this condition.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
V1 - V2:
add optind assignment to make reviewers happy;
print error
this patch will handle the strerror reporting of the error instead of
printing errno, and also replaced the BUG_ON with the error handling
Signed-off-by: Anand Jain anand.j...@oracle.com
---
v4: replaced ? statement with proper if statement
v3: fix per Stefan review, update error message
v2:
On 12-18-13 10:46:29 Anand Jain wrote:
On 12/18/2013 10:03 AM, Garry T. Williams wrote:
I have been using btrfs for my /home partition on my home machine for
a few years now. I created the file system RAID1 using two disk
partitions. Recently I noticed btrfs fi df shows extra Data,
Wang Shilong wangsl.f...@cn.fujitsu.com writes:
It seems that you use older kernel version but use the latest
btrfs-progs, new btrfs-progs use uuid tree to search but
this tree did not exist yet.
Can you try to upgrade your kernel?
What version is necessary? (I am currently on 3.11.10.)
On 12/18/2013 12:06 PM, Michael Welsh Duggan wrote:
Wang Shilong wangsl.f...@cn.fujitsu.com writes:
It seems that you use older kernel version but use the latest
btrfs-progs, new btrfs-progs use uuid tree to search but
this tree did not exist yet.
Can you try to upgrade your kernel?
What
64 matches
Mail list logo
