[PATCH v2 1/4] Btrfs: fix wrong send_in_progress accounting

2014-01-07 Thread Wang Shilong
Steps to reproduce: # mkfs.btrfs -f /dev/sda8 # mount /dev/sda8 /mnt # btrfs sub snapshot -r /mnt /mnt/snap1 # btrfs sub snapshot -r /mnt /mnt/snap2 # btrfs send /mnt/snap1 -p /mnt/snap2 -f /mnt/1 # dmesg The problem is that we will sort clone roots(include @send_root), it might push

[PATCH v2 2/4] Btrfs: fix protection between send and root deletion

2014-01-07 Thread Wang Shilong
We should gurantee that parent and clone roots can not be destroyed during send, for this we have two ideas. 1.by holding @subvol_sem, this might be a nightmare, because it will block all subvolumes deletion for a long time. 2.Miao pointed out we can reuse @send_in_progress, that mean we will

[PATCH v2 4/4] Btrfs: handle EAGAIN case properly in btrfs_drop_snapshot()

2014-01-07 Thread Wang Shilong
We may return early in btrfs_drop_snapshot(), we shouldn't call btrfs_std_err() for this case, fix it. Cc: sta...@vger.kernel.org Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com --- Changelog v1-v2: cc stable --- fs/btrfs/extent-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 3/4] Btrfs: remove unnecessary transaction commit before send

2014-01-07 Thread Wang Shilong
We will finish orphan cleanups during snapshot, so we don't have to commit transaction here. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Reviewed-by: Miao Xie mi...@cn.fujitsu.com --- Changelog v1-v2: none --- fs/btrfs/send.c | 29 - 1 file changed, 29

Re: [RFC] lib: raid: New RAID library supporting up to six parities

2014-01-07 Thread Andrea Mazzoleni
Hi Neil, On 01/07, NeilBrown wrote: To do the same with up to six failures, it's now required some kind of sort function. So I would probably just make sure we always process the block is the right order. Then sorting would be irrelevant. But as I say, I haven't fiddled with the code,

Re: btrfs-transaction blocked for more than 120 seconds

2014-01-07 Thread Brendan Hide
On 2014/01/06 12:57 AM, Roman Mamedov wrote: Did you align your partitions to accommodate for the 4K sector of the EARS? I had, yes. I had to do a lot of research to get the array working optimally. I didn't need to repartition the spare so this carried over to its being used as an OS disk.

Re: [RFC v2 2/2] fs: btrfs: Extends btrfs/raid56 to support up to six parities

2014-01-07 Thread Andrea Mazzoleni
Hi Chris, On 01/06, Chris Mason wrote: Neat. The faila/failb were always my least favorite part of the btrfs code ;) Did you test just raid5/6 or also the higher parity counts? At this stage no real testing was made with btrfs. The intention of this btrfs patch is mainly to get feedback on

Re: Is anyone using btrfs send/receive howto?

2014-01-07 Thread Marc MERLIN
I read different howtos on the wiki and oracle docs, but I can't get it to work: legolas:/mnt/btrfs_pool1# btrfs subvolume snapshot -r tmp tmp_read_only_new Create a readonly snapshot of 'tmp' in './tmp_read_only_new' legolas:/mnt/btrfs_pool1# sync legolas:/mnt/btrfs_pool1# btrfs send

Re: Is anyone using btrfs send/receive howto?

2014-01-07 Thread Hugo Mills
On Tue, Jan 07, 2014 at 02:49:51AM -0800, Marc MERLIN wrote: I read different howtos on the wiki and oracle docs, but I can't get it to work: legolas:/mnt/btrfs_pool1# btrfs subvolume snapshot -r tmp tmp_read_only_new Create a readonly snapshot of 'tmp' in './tmp_read_only_new'

Re: [RFC v2 0/2] New RAID library supporting up to six parities

2014-01-07 Thread Andrea Mazzoleni
On 01/06, joystick wrote: Just by looking at the Subjects, it seems patch number 0/1 is missing. It might have not gotten through to the lists, or be a numbering mistake. The patch files can be also downloaded from: http://snapraid.sourceforge.net/linux/v2/ Sorry about that, Does your code

Re: [RFC v2 0/2] New RAID library supporting up to six parities

2014-01-07 Thread Andrea Mazzoleni
Hi, It seems that the patch was to big for some linux lists. If you miss some patch files, you can download them also at: http://snapraid.sourceforge.net/linux/v2/ Sorry about that. Ciao, Andrea -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

[RFC PATCH v4] Btrfs: add support for inode properties

2014-01-07 Thread Filipe David Borba Manana
This change adds infrastructure to allow for generic properties for inodes. Properties are name/value pairs that can be associated with inodes for different purposes. They are stored as xattrs with the prefix btrfs. Properties can be inherited - this means when a directory inode has inheritable

Re: [PATCH 0/5] Add support for object properties

2014-01-07 Thread Filipe David Manana
On Sat, Nov 23, 2013 at 12:52 AM, David Sterba dste...@suse.cz wrote: On Tue, Nov 12, 2013 at 01:41:41PM +, Filipe David Borba Manana wrote: This is a revised version of the original proposal/work from Alexander Block to introduce a generic framework to set properties on btrfs filesystem

Re: correct way to rollback a root filesystem?

2014-01-07 Thread Sander
Jim Salter wrote (ao): I tried a kernel upgrade with moderately disastrous (non-btrfs-related) results this morning; after the kernel upgrade Xorg was completely borked beyond my ability to get it working properly again through any normal means. I do have hourly snapshots being taken by cron,

Re: [PATCH 00/21] Consolidate Posix ACL implementation V3

2014-01-07 Thread Christoph Hellwig
On Fri, Dec 20, 2013 at 05:16:35AM -0800, Christoph Hellwig wrote: This series consolidates the various cut'n'pasted Posix ACL implementations into a single common one based on the -get_acl method Linus added a while ago and a new -set_acl counterpart. This remove ~1800 lines of code and

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2014-01-07 Thread Josef Bacik
On 12/21/2013 03:56 AM, Wang Shilong wrote: Hello Josef, Though i know there are still problems related to qgroup(for example removing snapshot will beak qgroup accounting).I did a simple test about your patch.. # btrfs quota enable /mnt # dd if=/dev/zero of=/mnt/data bs=4k count=102400

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Ben Myers
Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I noticed that no matter what seed I

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Eric Sandeen
On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Eric Sandeen
On 1/7/14, 2:10 PM, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to

Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748

2014-01-07 Thread Muthu Kumar
Thanks Fengguang. Final patch with added comment. BTW, fengguang mentioned that git-am has trouble with the inline patch and quilt import worked fine for him... In btrfs_end_bio(), we increment bi_remaining if is_orig_bio. If not, we restore the orig_bio but failed to increment

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Josef Bacik
On 01/07/2014 03:10 PM, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying

[PATCH] Btrfs-progs: deal with invalid key orderings and bad orphan items V2

2014-01-07 Thread Josef Bacik
A user had a fs where the objectid of an orphan item was not the actual orphan item objectid. This screwed up fsck because the block has keys in the wrong order, also the fs scanning stuff will freak out because we have an inode with nlink 0 and no orphan item. So this patch is pretty big but is

Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748

2014-01-07 Thread Chris Mason
On Tue, 2014-01-07 at 12:15 -0800, Muthu Kumar wrote: Thanks Fengguang. Final patch with added comment. BTW, fengguang mentioned that git-am has trouble with the inline patch and quilt import worked fine for him... In btrfs_end_bio(), we increment bi_remaining if is_orig_bio.

[PATCH] Btrfs-progs: bail if we find errors in the extent tree

2014-01-07 Thread Josef Bacik
For some reason we weren't exiting if there were errors in the extent tree, which means we could have errors in just the extent tree and things like xfstests would keep going because we completely throw away the return value. Thanks, Signed-off-by: Josef Bacik jba...@fb.com --- cmds-check.c | 4

Re: btrfsck does not fix

2014-01-07 Thread Hendrik Friedel
Hello, I ran btrfsck on my volume with the repair option. When I re-run it, I get the same errors as before. It mounts without errors? So why then btrfsck/btrfs repair? What precipitated the repair? I don't know what caused the damage, but a check revealed this: Checking filesystem on

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Ben Myers
On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef

Re: [PATCH] Btrfs-progs: bail if we find errors in the extent tree

2014-01-07 Thread Josef Bacik
On 01/07/2014 03:34 PM, Josef Bacik wrote: For some reason we weren't exiting if there were errors in the extent tree, which means we could have errors in just the extent tree and things like xfstests would keep going because we completely throw away the return value. Thanks, Signed-off-by:

Re: [PATCH v2 5/6] Btrfs: use flags instead of the bool variants in delayed node

2014-01-07 Thread David Sterba
On Tue, Jan 07, 2014 at 11:59:18AM +0800, Miao Xie wrote: But I read a discuss about the use of boolean type, some developers suggested us to use bitfields instead of bool, because the bitfields can work better, and they are more flexible, less misuse than bool.

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Josef Bacik
On 01/07/2014 03:40 PM, Ben Myers wrote: On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Chris Mason
On Tue, 2014-01-07 at 16:17 -0500, Josef Bacik wrote: On 01/07/2014 03:40 PM, Ben Myers wrote: On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42

Re: [PATCH] Skip non-regular files in recursive defrag

2014-01-07 Thread Pascal VITOUX
On Mon, Jan 6, 2014 at 4:36 PM, David Sterba dste...@suse.cz wrote: On Wed, Jan 01, 2014 at 03:10:25PM +0100, Pascal VITOUX wrote: --- cmds-filesystem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-filesystem.c b/cmds-filesystem.c index 1c1926b..979dbd9

YOU HAVE RECEIVED A DONATION

2014-01-07 Thread III Seminario Internacional de ActualizaciĆ³n en Agroindustria
Hello, This message is to inform you that you have just received a cash donation of $460,000 from us. You are advised to write us an email once you get this message through the following Email: dawesda...@hotmail.com for more information on how you can redeem your donated sum. Best of luck.

Re: btrfs-transaction blocked for more than 120 seconds

2014-01-07 Thread Marc MERLIN
On Fri, Jan 03, 2014 at 09:34:10PM +, Duncan wrote: IIRC someone also mentioned problems with autodefrag and an about 3/4 gig systemd journal. My gut feeling (IOW, *NOT* benchmarked!) is that double- digit MiB files should /normally/ be fine, but somewhere in the lower triple digits,

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2014-01-07 Thread Qu Wenruo
On Mon, 23 Dec 2013 10:35:04 +0800 , Qu Wenruo wrote: On fri, 20 Dec 2013 05:30:48 -0800, Josef Bacik wrote: On 12/19/2013 07:08 PM, Qu Wenruo wrote: I'm sorry but I failed to reproduce the problem. Btrfs/012 in xfstests has been run for serveral hours but nothing happened. Would you