Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root().

2014-07-10 Thread Satoru Takeuchi
Hi Qu, (2014/07/10 12:05), Qu Wenruo wrote: Before this patch, find_mount_root() and the caller both output error message, which sometimes make the output duplicated and hard to judge what the problem is. This pathh will integrate all the error messages output into find_mount_root() to

Re: [PATCH 3/4] btrfs-progs: Fix wrong indent in btrfs-progs.

2014-07-10 Thread Satoru Takeuchi
(2014/07/10 12:05), Qu Wenruo wrote: When editing cmds-filesystem.c, I found cmd_filesystem_df() uses 7 spaces as indent instead of 1 tab (or 8 spaces). which makes indent quite embarrassing. Such problem is especillay hard to detect when reviewing patches, since the leading '+' makes a tab

Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root().

2014-07-10 Thread Miao Xie
Takeuchi-san On Thu, 10 Jul 2014 16:33:23 +0900, Satoru Takeuchi wrote: (2014/07/10 12:05), Qu Wenruo wrote: Before this patch, find_mount_root() and the caller both output error message, which sometimes make the output duplicated and hard to judge what the problem is. This pathh will

Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root().

2014-07-10 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root(). From: Miao Xie mi...@cn.fujitsu.com To: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date:

Re: btrfs RAID with enterprise SATA or SAS drives

2014-07-10 Thread Martin Steigerwald
Am Donnerstag, 10. Juli 2014, 12:10:46 schrieb Russell Coker: On Wed, 9 Jul 2014 16:48:05 Martin Steigerwald wrote: - for someone using SAS or enterprise SATA drives with Linux, I understand btrfs gives the extra benefit of checksums, are there any other specific benefits over using

Re: btrfs RAID with enterprise SATA or SAS drives

2014-07-10 Thread Austin S Hemmelgarn
On 2014-07-09 22:10, Russell Coker wrote: On Wed, 9 Jul 2014 16:48:05 Martin Steigerwald wrote: - for someone using SAS or enterprise SATA drives with Linux, I understand btrfs gives the extra benefit of checksums, are there any other specific benefits over using mdadm or dmraid? I think I

Re: [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root()

2014-07-10 Thread Martin Steigerwald
Am Donnerstag, 10. Juli 2014, 11:05:10 schrieb Qu Wenruo: When calling find_mount_root(), caller in fact wants to find the mount point of *BTRFS*. So also check ent-fstype in find_mount_root() and output proper error messages if needed. This will suppress a lot of Inapproiate ioctl for

Re: File server structure suggestion

2014-07-10 Thread Tamas Papp
On 07/10/2014 04:41 PM, Andrew Flerchinger wrote: what was going on. That sold me on the idea of data checksums, but I'd rather stay in linux than BSD, and I previously made use of online capacity expansion as needed, which ZFS doesn't support. What do you mean by that? What zfs doesn't

Re: File server structure suggestion

2014-07-10 Thread Andrew Flerchinger
I want to increase the size of the vdev, not just the zpool. I want to make a 3-drive array into a 4-drive array by adding a single drive while still having one parity stripe across all data. Adding more vdevs to a zpool isn't quite the same thing as online capacity expansion. It's not something

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
Hey Dave, thanks for the patch review! Pretty much all of what you wrote sounds good to me, there's just one or two items I wanted to clarify - those comments are inline. Thanks again, On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark

[Question] disk_bytenr with multiple devices

2014-07-10 Thread Zhe Zhang
When a btrfs has multiple devices (e.g. /dev/sdb, /dev/sdc), how should I interpret disk_bytenr in btrfs_file_extent_item? Does it depend on the striping config? Say I used raid0, then disk_bytenr 0~64K will be on /dev/sdb, and 64K~128K on /dev/sdc? Thanks, Zhe -- To unsubscribe from this list:

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Zach Brown
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: + +# Enable qgroups now that we have our filesystem prepared. This +# will kick off a scan which we

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: + +# Enable qgroups now that we have our

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Zach Brown
On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700,

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
On Thu, Jul 10, 2014 at 12:05:05PM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Dave Chinner
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: Hey Dave, thanks for the patch review! Pretty much all of what you wrote sounds good to me, there's just one or two items I wanted to clarify - those comments are inline. Thanks again, On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave

Re: File server structure suggestion

2014-07-10 Thread Duncan
Andrew Flerchinger posted on Thu, 10 Jul 2014 10:41:02 -0400 as excerpted: Enter btrfs. Unfortunately, it's newer than ZFS and isn't as robust, but it does support online capacity expansion, and the on disk format is expect to be stable. It has data checksums and COW, which are the primary

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Duncan
Mark Fasheh posted on Thu, 10 Jul 2014 12:00:55 -0700 as excerpted: Given something like that, you'd just replace the calls to sleep with 'btrfs fi synctheworldandwait' and know that on return, the actions you just queued up completed. I'll admit to not really knowing what I'm talking about

RE: Using serialized BTRFS snapshots as a backup

2014-07-10 Thread David Player
I'm trying to use serialized BTRFS snapshots as a backup system. The problem is that I don't know how to avoid sending duplicate data and also have the ability to prune old backups. Specifically I've considered the following: #snapshot btrfs subvolume snapshot -r  live-volume  volume-date

Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root().

2014-07-10 Thread Satoru Takeuchi
(2014/07/10 17:26), Qu Wenruo wrote: Original Message Subject: Re: [PATCH 2/4] btrfs-progs: Integrate error message output into find_mount_root(). From: Miao Xie mi...@cn.fujitsu.com To: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com, Qu Wenruo quwen...@cn.fujitsu.com,

Btrfs transaction checksum corruption losing root of the tree bizarre UUID change.

2014-07-10 Thread Tomasz Kusmierz
Hi all ! So it been some time with btrfs, and so far I was very pleased, but since I've upgraded to ubuntu from 13.10 to 14.04 problems started to occur (YES I know this might be unrelated). So in the past I've had problems with btrfs which turned out to be a problem caused by static from

[PATCH v3] btrfs: remove unnecessary error check

2014-07-10 Thread Satoru Takeuchi
Hi Eric, (2014/07/10 22:27), Eric Sandeen wrote: On 7/10/14, 1:44 AM, Satoru Takeuchi wrote: (2014/07/10 12:26), Eric Sandeen wrote: On Jul 9, 2014, at 10:20 PM, Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com wrote: From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com If (!IS_ERR(trans)

Re: Btrfs transaction checksum corruption losing root of the tree bizarre UUID change.

2014-07-10 Thread Austin S Hemmelgarn
On 07/10/2014 07:32 PM, Tomasz Kusmierz wrote: Hi all ! So it been some time with btrfs, and so far I was very pleased, but since I've upgraded to ubuntu from 13.10 to 14.04 problems started to occur (YES I know this might be unrelated). So in the past I've had problems with btrfs which

Re: [Question] disk_bytenr with multiple devices

2014-07-10 Thread Qu Wenruo
Original Message Subject: [Question] disk_bytenr with multiple devices From: Zhe Zhang zhe.zhang.resea...@gmail.com To: linux-btrfs@vger.kernel.org Date: 2014年07月11日 02:21 When a btrfs has multiple devices (e.g. /dev/sdb, /dev/sdc), how should I interpret disk_bytenr in