Clarification needed about libbtrfs & libbtrfsutil

2018-05-14 Thread Dimitri John Ledkov
Are both of these meant to be public libraries, installed on the user systems, and available in .so variant as well for 3rd party development and public dynamic linking? Or are these private internal libraries, which are installed as public runtime only, simply to share code between the utils, but

Re: Clarification needed about libbtrfs & libbtrfsutil

2018-05-15 Thread Dimitri John Ledkov
On 14 May 2018 at 21:22, Omar Sandoval wrote: > On Mon, May 14, 2018 at 09:40:19AM +0100, Dimitri John Ledkov wrote: >> Are both of these meant to be public libraries, installed on the user >> systems, and available in .so variant as well for 3rd party >> development and p

[PATCH] Fix bashism in fsck.btrfs for debian/ubuntu dash.

2015-05-15 Thread Dimitri John Ledkov
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784911 Signed-off-by: Dimitri John Ledkov --- fsck.btrfs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsck.btrfs b/fsck.btrfs index f056a7f..3a92804 100755 --- a/fsck.btrfs +++ b/fsck.btrfs @@ -31,7 +31,7 @@ if

Re: [PATCH] Fix bashism in fsck.btrfs for debian/ubuntu dash.

2015-05-21 Thread Dimitri John Ledkov
On 15 May 2015 at 21:28, Dimitri John Ledkov wrote: > Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784911 > Signed-off-by: Dimitri John Ledkov > --- > fsck.btrfs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fsck.btrfs b/fsck.

[PATCH] fsck.btrfs: Fix bashism and bad getopts processing

2015-05-21 Thread Dimitri John Ledkov
First fix == bashism, as that is not accepted by e.g. Debian/Ubuntu dash. Secondly shift OPTIND, such that last parameter is checked to exist. Signed-off-by: Dimitri John Ledkov --- fsck.btrfs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fsck.btrfs b/fsck.btrfs index

Re: "@" prefix in subvolume paths

2015-06-11 Thread Dimitri John Ledkov
On 11 June 2015 at 02:50, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 6/10/15 7:10 PM, Hugo Mills wrote: >> On Tue, Jun 09, 2015 at 07:55:05PM +0200, pu...@xs4all.nl wrote: >>> Hi, >>> >>> I've noticed this "@" sign in the subvolume's path with SLES12. >>> I'm wond

Re: [RFC][PATCH v2] mount.btrfs helper

2014-12-05 Thread Dimitri John Ledkov
On 5 December 2014 at 15:32, Chris Mason wrote: > On Sun, Nov 30, 2014 at 5:57 PM, Dimitri John Ledkov > wrote: >> >> On 30 November 2014 at 22:31, cwillu wrote: >>> >>> >>> In ubuntu, the initfs runs a btrfs dev scan, which should catch >>&g

Re: Announcements for btrfs-progs?

2014-12-14 Thread Dimitri John Ledkov
On 11 December 2014 at 12:37, Holger Hoffstätte wrote: > > David, > > I was wondering if you could please send out announcements for btrfs-progs > when you tag a release or -rc? There doesn't seem to be a good mechanism > to track releases and IMHO the more people are notified, the more > testing

[PATCH] Drop feature defines from C files, in favour of CFLAGS defines.

2015-01-17 Thread Dimitri John Ledkov
ent struct stat from other files (cmds-replace.c). This patch thus cleans up all feature defines, and sets them at a consistent level. Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747969 Signed-off-by: Dimitri John Ledkov --- Makefile | 2 +- btrfs-calc-size.c | 2

[PATCH 1/4] Properly cast to avoid compiler warnings, fixes FTBFS on alpha and ia64.

2014-09-20 Thread Dimitri John Ledkov
Bug-Debian: http://bugs.debian.org/539433 Bug-Debian: http://bugs.debian.org/583768 Authors: Luca Bruno Alexander Kurtz Daniel Baumann Signed-off-by: Dimitri John Ledkov --- btrfs-convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/btrfs-convert.c b/btrfs

[PATCH 3/4] Fixing unaligned memory accesses.

2014-09-20 Thread Dimitri John Ledkov
From: Shawn Landen Bug-Debian: http://bugs.debian.org/656955 Signed-off-by: Dimitri John Ledkov --- ctree.h | 18 ++ volumes.c | 5 +++-- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/ctree.h b/ctree.h index fa73c4a..92c6ad3 100644 --- a/ctree.h +++ b

[PATCH 2/4] Fixes FTBFS with --no-add-needed.

2014-09-20 Thread Dimitri John Ledkov
From: Luk Claes Bug-Debian: http://bugs.debian.org/554059 Signed-off-by: Dimitri John Ledkov --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e721e99..441e925 100644 --- a/Makefile +++ b/Makefile @@ -26,7 +26,7 @@ TESTS = fsck-tests.sh

[PATCH 4/4] Default to acting like fsck.

2014-09-20 Thread Dimitri John Ledkov
Inspect arguments, if we are not called as btrfs, then assume we are called to act like fsck. Bug-Debian: http://bugs.debian.org/712078 Signed-off-by: Dimitri John Ledkov --- btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/btrfs.c b/btrfs.c index e83349c..e8a87ac

Re: [PATCH 4/4] Default to acting like fsck.

2014-09-22 Thread Dimitri John Ledkov
On 21 September 2014 13:59, Tobias Geerinckx-Rice wrote: > On 21 September 2014 03:01, Dimitri John Ledkov wrote: >> >> Inspect arguments, if we are not called as btrfs, then assume we are >> called to act like fsck. > [...] >> - if (!strcmp(bname, "btrfs

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread Dimitri John Ledkov
Hello, On 30 November 2014 at 17:43, Goffredo Baroncelli wrote: > Hi all, > > this patch provides a "mount.btrfs" helper for the mount command. > A btrfs filesystem could span several disks. This helper scans all the > partitions to discover all the disks required to mount a filesystem. > So it w

Re: [RFC][PATCH v2] mount.btrfs helper

2014-11-30 Thread Dimitri John Ledkov
On 30 November 2014 at 22:31, cwillu wrote: > > In ubuntu, the initfs runs a btrfs dev scan, which should catch > anything that would be missed there. > I'm sorry, udev rule(s) is not sufficient in the initramfs-less case, as outlined. In case of booting with initramfs, indeed, both Debian & Ubu

Re: [RFC PATCH] Btrfs: add sha256 checksum option

2014-11-30 Thread Dimitri John Ledkov
On 30 November 2014 at 22:59, Christoph Anton Mitterer wrote: >>Agree with others about -C 256...-C sha256 is only three >>letters more ;) > > Ideally, sha2-256 would be used, since there will be (are) other > versions of sha which have 256 bits size. > Nope, we should use standard names. SHA-2 2