Re: [PATCH] fstests: test for btrfs incremental send after replacing a file

On Tue, Sep 29, 2015 at 10:48 AM, Eryu Guan <eg...@redhat.com> wrote: > On Tue, Sep 29, 2015 at 09:33:34AM +0100, Filipe Manana wrote: >> On Tue, Sep 29, 2015 at 4:54 AM, Eryu Guan <eg...@redhat.com> wrote: >> > On Sat, Sep 26, 2015 at 12:40:13PM +0100, fdman..

Re: [PATCH 2/2] btrfs: Fix lost-data-profile caused by balance bg

On Tue, Sep 29, 2015 at 2:51 PM, Zhao Lei wrote: > Reproduce: > (In integration-4.3 branch) > > TEST_DEV=(/dev/vdg /dev/vdh) > TEST_DIR=/mnt/tmp > > umount "$TEST_DEV" >/dev/null > mkfs.btrfs -f -d raid1 "${TEST_DEV[@]}" > > mount -o nospace_cache "$TEST_DEV"

Re: [PATCH 1/2] btrfs: Fix lost-data-profile caused by auto removing bg

On Tue, Sep 29, 2015 at 2:51 PM, Zhao Lei wrote: > Reproduce: > (In integration-4.3 branch) > > TEST_DEV=(/dev/vdg /dev/vdh) > TEST_DIR=/mnt/tmp > > umount "$TEST_DEV" >/dev/null > mkfs.btrfs -f -d raid1 "${TEST_DEV[@]}" > > mount -o nospace_cache "$TEST_DEV"

Re: [PATCH 2/2] btrfs: Fix lost-data-profile caused by balance bg

On Wed, Sep 30, 2015 at 5:20 AM, Zhao Lei <zhao...@cn.fujitsu.com> wrote: > Hi, Filipe Manana > > Thanks for reviewing. > >> -Original Message- >> From: Filipe Manana [mailto:fdman...@gmail.com] >> Sent: Tuesday, September 29, 2015 11:48 PM >> T

Re: [PATCH 2/2] btrfs: Fix lost-data-profile caused by balance bg

On Wed, Sep 30, 2015 at 9:26 AM, Zhao Lei <zhao...@cn.fujitsu.com> wrote: > Hi, Filipe Manana > >> -Original Message----- >> From: Filipe Manana [mailto:fdman...@gmail.com] >> Sent: Wednesday, September 30, 2015 3:41 PM >> To: Zhao Lei <zha

Re: [PATCH] Btrfs: create_subvol: Commit the current transaction if stale root entry exists.

On Thu, Oct 1, 2015 at 12:57 PM, David Sterba wrote: > On Thu, Oct 01, 2015 at 04:19:55PM +0530, Chandan Rajendra wrote: >> This occurs because, >> >> Mount filesystem >> Create subvol with ID 257 >> Unmount filesystem >> Mount filesystem >> Delete subvol with ID 257 >>

Re: [PATCH] Btrfs: fix deadlock when finalizing block group creation

On Fri, Oct 2, 2015 at 8:04 PM, Josef Bacik <jba...@fb.com> wrote: > On 10/02/2015 01:43 PM, fdman...@kernel.org wrote: >> >> From: Filipe Manana <fdman...@suse.com> >> >> Josef ran into a deadlock while a transaction handle was finalizing the >>

Re: [PATCH v2] btrfs: qgroup: exit the rescan worker during umount

On Sat, Sep 26, 2015 at 1:25 AM, Justin Maggard wrote: > On Tue, Sep 22, 2015 at 7:45 AM, David Sterba wrote: >> On Wed, Sep 02, 2015 at 06:05:17PM -0700, Justin Maggard wrote: >>> v2: Fix stupid error while making formatting changes... >> >> I haven't

Re: [PATCH v2 1/2] btrfs: Fix lost-data-profile caused by auto removing bg

ount it again, there is no data chunk in the > filesystem, so the only available data profile is 0x0, result > is all new chunks are created as single type. > > Fix: > Don't auto-delete last blockgroup for a raid type. > > Test: > Test by above script, and confirmed the lo

Re: kernel BUG at fs/btrfs/extent-tree.c:1833! [btrfs]

On Wed, Dec 2, 2015 at 9:18 AM, Михаил Гаврилов wrote: > kernel BUG at fs/btrfs/extent-tree.c:1833! > invalid opcode: [#1] SMP > Modules linked in: xt_CHECKSUM ipt_MASQUERADE nf_nat_masquerade_ipv4 > tun nls_utf8 isofs rfcomm fuse nf_conntrack_netbios_ns >

Re: [PATCH] Btrfs: fix leaking of ordered extents after direct IO write error

On Wed, Dec 9, 2015 at 10:41 AM, kbuild test robot wrote: > Hi Filipe, > > [auto build test ERROR on v4.4-rc4] > [also build test ERROR on next-20151208] > [cannot apply to btrfs/next] > > url: >

Re: kernel BUG at fs/btrfs/extent-tree.c:1833! [btrfs]

On Wed, Dec 9, 2015 at 11:05 PM, Gerald Hopf wrote: > >>> kernel BUG at fs/btrfs/extent-tree.c:1833! >> >> We got this fixed in 4.4-rc1: >> >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2c3cf7d5f6105bb957df125dfce61d4483b8742d >> >>

Re: [PATCH 3/8] Fix btrfs/094 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/094 | 75 > ++--- > tests/btrfs/094.out | 71 -- >

Re: [PATCH 1/8] Filter xfs_io's output in units of page size

dan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > common/filter | 8 > common/rc | 6 ++ > 2 files changed, 14 insertions(+) > > diff --git a/common/filter b/common/filter > index 05f2fab..1be377c 100644 >

Re: [PATCH V2 4/5] Fix btrfs/056 to work on non-4k block sized filesystems

-by: Chandan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/056 | 51 ++ > tests/btrfs/056.out | 152 > +--- > 2 files changed, 9

Re: !PageLocked BUG_ON hit in clear_page_dirty_for_io

On Thu, Dec 10, 2015 at 9:35 PM, Liu Bo wrote: > On Thu, Dec 10, 2015 at 04:30:24PM -0500, Chris Mason wrote: >> On Thu, Dec 10, 2015 at 02:35:55PM -0500, Dave Jones wrote: >> > On Thu, Dec 10, 2015 at 02:02:20PM -0500, Chris Mason wrote: >> > > On Tue, Dec 08, 2015 at

Re: !PageLocked BUG_ON hit in clear_page_dirty_for_io

_mutex, which we're sure to regret eventually. > > Reported-by: Dave Jones <d...@fb.com> > Signed-off-by: Chris Mason <c...@fb.com> Reviewed-by: Filipe Manana <fdman...@suse.com> > --- > fs/btrfs/file.c | 18 ++ > 1 file changed, 14 inse

Re: Kernel lockup, might be helpful log.

On Sun, Dec 13, 2015 at 10:55 PM, Birdsarenice wrote: > I've finally finished deleting all those nasty unreliable Seagate drives > from my array. During the process I crashed my server - over, and over, and > over. Completely gone - screen blank, controls unresponsive, no

Re: [PATCH 1/2 v3] Btrfs: fix regression when running delayed references

On Sun, Dec 13, 2015 at 10:51 AM, Alex Lyakas <a...@zadarastorage.com> wrote: > Hi Filipe Manana, > > My understanding of selecting delayed refs to run or merging them is > far from complete. Can you please explain what will happen in the > following scenario: > >

Re: [PATCH] Btrfs: fix quick exhaustion of the system array in the superblock

On Sun, Dec 13, 2015 at 10:29 AM, Alex Lyakas <a...@zadarastorage.com> wrote: > Hi Filipe Manana, > > Can't the call to btrfs_create_pending_block_groups() cause a > deadlock, like in > http://www.spinics.net/lists/linux-btrfs/msg48744.html? Because this > call updates the

Re: [PATCH 2/8] Fix btrfs/052 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/052 | 122 + > tests/btrfs/052.out | 744 > +++- > 2 files changed, 515 insertions(+), 351 delet

Re: [PATCH 6/8] Fix btrfs/098 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/098 | 67 > + > tests/btrfs/098.out | 27 - > 2 files changed, 58 insertions(+), 36

Re: [PATCH V2 3/5] Fix btrfs/055 to work on non-4k block sized filesystems

-by: Chandan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/055 | 128 ++ > tests/btrfs/055.out | 378 > +--- > 2 files changed, 25

Re: [PATCH V2 5/5] Fix btrfs/096 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/096 | 45 + > tests/btrfs/096.out | 15 +-- > 2 files changed, 30 insertions(+), 30 deletions(-) >

Re: [PATCH V2 2/5] Fix btrfs/017 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/017 | 16 > tests/btrfs/017.out | 3 +-- > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/tests/btrfs/01

Re: [PATCH V2 1/5] Filter xfs_io and od's output in units of FS block size

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > common/filter | 45 + > 1 file changed, 45 insertions(+) > > diff --git a/common/filter b/common/filter > index af

Re: [PATCH 4/8] Fix btrfs/095 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/095 | 110 > +--- > tests/btrfs/095.out | 42 > 2 files changed, 96 insertions(+), 56

Re: [PATCH 5/8] Fix btrfs/097 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/097 | 41 - > tests/btrfs/097.out | 23 +-- > 2 files changed, 41 insertions(+), 23 deletions(-) &

Re: [PATCH 7/8] Fix btrfs/103 to work on non-4k block sized filesystems

handan Rajendra <chan...@linux.vnet.ibm.com> Reviewed-by: Filipe Manana <fdman...@suse.com> Thanks! > --- > tests/btrfs/103 | 44 +++--- > tests/btrfs/103.out | 132 > ++-- > 2 files changed, 122 insertions(+), 54

Re: kernel BUG at fs/btrfs/send.c:1482

On Thu, Dec 31, 2015 at 4:27 PM, Stephen R. van den Berg wrote: > Stephen R. van den Berg wrote: >>I'm running 4.4.0-rc7. >>This exact problem was present on 4.0.5 and 4.3.3 too though. > >>I do a "btrfs send /var/lib/lxc/template64/rootfs", that generates >>the following error

Re: defrag vs autodefrag

On Mon, Dec 21, 2015 at 8:14 AM, Hugo Mills wrote: > On Sun, Dec 20, 2015 at 07:26:07PM -0600, Donald Pearson wrote: >> I read an implication in a different thread that defrag and autodefrag >> behave differently in that autodefrag is more snapshot friendly for >> COW data. >>

Re: [PATCH 1/2] fstests: fix btrfs test failures after commit 27d077ec0bda

On Wed, Dec 23, 2015 at 11:49 PM, Dave Chinner <da...@fromorbit.com> wrote: > On Tue, Dec 22, 2015 at 02:22:40AM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> Commit 27d077ec0bda (common: use mount/umount helpers everywhere) ma

Re: btrfs send reproducibly fails for a specific subvolume after sending 15 GiB, scrub reports no errors

On Sun, Nov 22, 2015 at 9:59 PM, Nils Steinger wrote: > Hi, > > I recently ran into a problem while trying to back up some of my btrfs > subvolumes over the network: > `btrfs send` works flawlessly on snapshots of most subvolumes, but keeps > failing on snapshots of a certain

Re: PAX: size overflow detected in function try_merge_map fs/btrfs/extent_map.c:238

On Fri, Nov 27, 2015 at 10:47 AM, Toralf Förster wrote: > Happened today few times in a row at a stable 64 bit Gentoo hardened system: > > > > Nov 27 10:23:09 t44 kernel: [41619.519921] PAX: size overflow detected in > function try_merge_map fs/btrfs/extent_map.c:238

Re: PAX: size overflow detected in function try_merge_map fs/btrfs/extent_map.c:238

On Fri, Nov 27, 2015 at 11:20 AM, Toralf Förster <toralf.foers...@gmx.de> wrote: > On 11/27/2015 12:07 PM, Filipe Manana wrote: >> Try the following (also pasted at >> https://friendpaste.com/5O6o1cqWqJZDIKrH1YqG7y): > > Doesn't apply neither against the used 4.2.6 ke

Re: PAX: size overflow detected in function try_merge_map fs/btrfs/extent_map.c:238

On Fri, Nov 27, 2015 at 11:51 AM, Holger Hoffstätte <holger.hoffstae...@googlemail.com> wrote: > On 11/27/15 12:20, Toralf Förster wrote: >> On 11/27/2015 12:07 PM, Filipe Manana wrote: >>> Try the following (also pasted at >>> https://friendpaste.com/5O6o1cqWqJZ

Re: [PATCH] Btrfs: fix error path when failing to submit bio for direct IO write

On Wed, Nov 25, 2015 at 5:58 PM, Liu Bo <bo.li@oracle.com> wrote: > On Tue, Nov 24, 2015 at 05:25:18PM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> Commit 61de718fceb6 ("Btrfs: fix memory corruption on failure

Re: [PATCH] Btrfs: fix unprotected list move from unused_bgs to deleted_bgs list

On Sat, Nov 28, 2015 at 7:34 AM, Duncan <1i5t5.dun...@cox.net> wrote: > fdmanana posted on Fri, 27 Nov 2015 16:38:25 + as excerpted: > >> As of my previous change titled "Btrfs: fix scrub preventing unused >> block groups from being deleted", the following warning at >>

Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

On Wed, Nov 25, 2015 at 11:03 AM, Chandan Rajendra wrote: > This commit makes use of the new _filter_xfs_io_blocks_modified filtering > function to print information in terms of file blocks rather than file > offset. > > Signed-off-by: Chandan Rajendra

Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

On Wed, Nov 25, 2015 at 11:47 AM, Chandan Rajendra <chan...@linux.vnet.ibm.com> wrote: > On Wednesday 25 Nov 2015 11:11:27 Filipe Manana wrote: >> >> Hi Chandan, >> >> I can't agree with this change. We're no longer checking that file >> data is correct a

Re: [PATCH] Fix balance regression in 4.4-rc

ätte <holger.hoffstae...@googlemail.com> > Fixes: bc3094673f22 ("btrfs: extend balance filter usage to take minimum and > maximum") Reviewed-by: Filipe Manana <fdman...@suse.com> Besides prefixing the title with "Btrfs: " as correctly pointed by Duncan, a b

Re: [PATCH] btrfs: qgroup: fix quota disable during rescan

On Thu, Nov 19, 2015 at 1:08 PM, David Sterba wrote: > Hi, > > On Fri, Nov 06, 2015 at 10:36:42AM -0800, Justin Maggard wrote: >> There's a race condition that leads to a NULL pointer dereference if you >> disable quotas while a quota rescan is running. To fix this, we just need

Re: [PATCH] btrfs: account for non-CoW'd blocks in btrfs_abort_transaction

switch it to a bool indicating whether any blocks were used and set > it when should_cow_block returns false. > > Cc: sta...@vger.kernel.org # 3.4+ > Signed-off-by: Jeff Mahoney <je...@suse.com> But anyway, Reviewed-by: Filipe Manana <fdman...@suse.com> > --- > fs/bt

Re: [PATCH v3] fstests: btrfs: add test for qgroup handle extent de-reference

On Mon, Jun 13, 2016 at 9:06 AM, Lu Fengqi wrote: > At 06/13/2016 03:29 PM, Lu Fengqi wrote: >> >> At 06/13/2016 11:04 AM, Eryu Guan wrote: >>> >>> On Mon, Jun 13, 2016 at 10:10:50AM +0800, Lu Fengqi wrote: Test if qgroup can handle extent de-reference during

Re: [PATCH v3] fstests: btrfs: add test for qgroup handle extent de-reference

On Tue, Jun 14, 2016 at 1:58 AM, Qu Wenruo <quwen...@cn.fujitsu.com> wrote: > > > At 06/13/2016 05:49 PM, Filipe Manana wrote: >> >> On Mon, Jun 13, 2016 at 9:06 AM, Lu Fengqi <lufq.f...@cn.fujitsu.com> >> wrote: >>> >>> At 06/13/2016 03:2

Re: [PATCH v3] fstests: btrfs: add test for qgroup handle extent de-reference

On Tue, Jun 14, 2016 at 10:08 AM, Qu Wenruo <quwen...@cn.fujitsu.com> wrote: > > > At 06/14/2016 04:41 PM, Filipe Manana wrote: >> >> On Tue, Jun 14, 2016 at 1:58 AM, Qu Wenruo <quwen...@cn.fujitsu.com> >> wrote: >>> >>> >>> >

Re: [PATCH] fstests: btrfs: add test for qgroup handle de-refer

On Tue, May 31, 2016 at 3:03 AM, Lu Fengqi wrote: > Test if qgroup can handle de-reference reallocation. What is "de-reference reallocation"? > Although current > qgroup can handle it, we still need to prevent any regression which may > break current qgroup. > >

Re: Runaway SLAB usage by 'bio' during 'device replace'

On Mon, May 30, 2016 at 7:48 PM, Chris Johnson wrote: > I have a RAID6 array that had a failed HDD. The drive failed > completely and has been removed from the system. I'm running a 'device > replace' operation with a new disk. The array is ~20TB so this will > take a few

Re: [PATCH] fstests: btrfs: add test for qgroup handle de-refer

On Tue, May 31, 2016 at 10:08 AM, luke <lufq.f...@cn.fujitsu.com> wrote: > > > > > At 05/31/2016 03:39 PM, Filipe Manana wrote: > > On Tue, May 31, 2016 at 3:03 AM, Lu Fengqi <lufq.f...@cn.fujitsu.com> wrote: > > Test if qgroup can handle de-reference

Re: [PATCH v2] btrfs: Add debug warning for new block group reservations

On Thu, May 26, 2016 at 8:06 AM, Qu Wenruo wrote: > Since the we are using atomic and wait queue for block group > reservations and it's not controlled by lockdep, we need pay much more > attention to any modification to write path. > > Or it's very easy to under flow

Re: Starting btrfs defrag with xargs -P 2 locks

On Fri, May 27, 2016 at 4:58 AM, Jérôme Poulin wrote: > I was de-fragmenting a BTRFS recently and it was quite slow, so I > decided to pipe find output to xargs -P 2 to speed up the file listing > process and found out it breaks BTRFS quite fast. In 2 minutes, I had > this

Re: Device replace issues and disabling it until they are solved

On Thu, May 26, 2016 at 8:09 PM, Scott Talbert <scott.talb...@hgst.com> wrote: > On Wed, 11 May 2016, Filipe Manana wrote: > >>> I've noticed some time ago that our device replace implementation is >>> unreliable. Basically under several situations it ends up not

Re: Device replace issues and disabling it until they are solved

On Thu, Jun 2, 2016 at 11:03 AM, Yauhen Kharuzhy <yauhen.kharu...@zavadatar.com> wrote: > On Fri, May 27, 2016 at 10:43:47AM +0100, Filipe Manana wrote: >> > Hi Filipe, >> >> Hi Scott, >> >> > >> > Does your recent patch set (from May 20) addre

Re: [PATCH] btrfs: don't force mounts to wait for cleaner_kthread to delete one or more subvolumes

On Wed, Jun 1, 2016 at 5:39 AM, Zygo Blaxell wrote: > On Thu, May 05, 2016 at 12:23:49AM -0400, Zygo Blaxell wrote: >> During a mount, we start the cleaner kthread first because the transaction >> kthread wants to wake up the cleaner kthread. We start the

Re: [PATCH v2] fstests: btrfs: fix 006 adds _runnt_btrfs_util_prog()

On Thu, Jun 23, 2016 at 12:34 PM, Anand Jain wrote: > > > On 06/23/2016 07:18 PM, Eryu Guan wrote: >> >> On Thu, Jun 23, 2016 at 07:03:59PM +0800, Anand Jain wrote: >>> >>> >>> >>> On 06/23/2016 06:53 PM, Eryu Guan wrote: >> >> [snip] > > diff --git a/common/rc

Re: [PATCH] fstests: btrfs, test for send with clone operations

On Thu, Feb 4, 2016 at 9:21 PM, Dave Chinner <da...@fromorbit.com> wrote: > On Thu, Feb 04, 2016 at 12:11:28AM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> Test that an incremental send operation which issues clone operat

Re: [PATCH] fs: btrfs: fixes a pass by reference issue in send.c

On Mon, Feb 1, 2016 at 11:53 AM, Ben Marsh wrote: > This patch fixes a pointer issue from passing a struct as a parameter > to the function btrfs_root_dec_send_in_progress. > > Signed-off-by: Ben Marsh > --- > fs/btrfs/send.c | 2 +- > 1 file changed, 1

Re: [PATCH] Btrfs: fix hang on extent buffer lock caused by the inode_paths ioctl

On Wed, Feb 3, 2016 at 11:19 PM, Liu Bo <bo.li@oracle.com> wrote: > On Wed, Feb 03, 2016 at 08:26:50PM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> While doing some tests I ran into an hang on an extent buffer's rwlock >

Re: [PATCH] Btrfs: fix hang on extent buffer lock caused by the inode_paths ioctl

On Thu, Feb 4, 2016 at 12:28 AM, Liu Bo <bo.li@oracle.com> wrote: > On Thu, Feb 04, 2016 at 12:23:12AM +0000, Filipe Manana wrote: >> On Thu, Feb 4, 2016 at 12:20 AM, Liu Bo <bo.li@oracle.com> wrote: >> > On Wed, Feb 03, 2016 at 11:24:33PM +, Filipe Man

Re: [PATCH] Btrfs: fix hang on extent buffer lock caused by the inode_paths ioctl

On Thu, Feb 4, 2016 at 12:20 AM, Liu Bo <bo.li@oracle.com> wrote: > On Wed, Feb 03, 2016 at 11:24:33PM +0000, Filipe Manana wrote: >> On Wed, Feb 3, 2016 at 11:19 PM, Liu Bo <bo.li@oracle.com> wrote: >> > On Wed, Feb 03, 2016 at 08:26:50PM +, fdman..

Re: [PATCH 1/5] fstests: Add support to check btrfs sysfs features

On Wed, Feb 24, 2016 at 6:35 AM, Qu Wenruo wrote: > Btrfs has its sysfs interface showing what features current kernel/btrfs > module support. > > Add _require_btrfs_kernel_feature() to check such interface. I think you sent the wrong patch. This doesn't add such a

Re: [RFC - PATCH] btrfs: do not write corrupted metadata blocks to disk

On Mon, Feb 22, 2016 at 9:46 AM, Alex Lyakas <a...@zadarastorage.com> wrote: > Thank you, Filipe, for your review. > > On Mon, Feb 22, 2016 at 3:05 AM, Filipe Manana <fdman...@kernel.org> wrote: >> On Sun, Feb 21, 2016 at 3:36 PM, Alex Lyakas <a...@zadarastorage.com

Re: [Question]: Contributing to btrfs

On Mon, Feb 22, 2016 at 7:26 AM, Philippe Loctaux wrote: > On Mon, Feb 22, 2016 at 09:18:04AM +0800, Qu Wenruo wrote: >> https://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git >> For branch, normally I use 'integration-X.X' as base for kernel development.

Re: [Question]: Contributing to btrfs

On Mon, Feb 22, 2016 at 12:02 PM, Simon Quigley wrote: >> 1) You don't learn anything by doing them. You don't learn nothing >> about btrfs internals, filesystems in general, kernel programming in >> general, general programming in C, etc. It ends up being only a waste >> of

Re: BZ#101951, Overlayfs on top of btrfs causes kernel oops + freeze

On Tue, Feb 16, 2016 at 3:38 PM, Colin Ian King wrote: > Hi there, > > bug: https://bugzilla.kernel.org/show_bug.cgi?id=101951 and also > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1532145 > > Commit 4bacc9c9234c7c8eec44f5ed4e960d9f96fa0f01 ("overlayfs: Make

Re: BZ#101951, Overlayfs on top of btrfs causes kernel oops + freeze

On Tue, Feb 16, 2016 at 4:08 PM, Colin Ian King <colin.k...@canonical.com> wrote: > On 16/02/16 15:51, Filipe Manana wrote: >> On Tue, Feb 16, 2016 at 3:38 PM, Colin Ian King >> <colin.k...@canonical.com> wrote: >>> Hi there, >>> >>> bug: https

Re: [PATCH 1/3] generic/304: fix high offset

On Wed, Feb 17, 2016 at 9:56 AM, Christoph Hellwig wrote: > On Mon, Feb 15, 2016 at 12:46:14PM -0800, Darrick J. Wong wrote: >> "Invalid argument" is a better response to an impossibly high offset >> dedupe request than "extents don't match", so change the test. > > What does

Re: btrfs send error

On Wed, Feb 17, 2016 at 1:02 PM, Pavol Cupka wrote: > Hi all, > > when trying to btrfs send a snaphost I get this in dmesg: > [8614395.539466] BTRFS error (device sda1): did not find backref in > send_root. inode=673755, offset=131072, disk_byte=25730310144 found >

Re: [PATCH 1/2] fstests: generic test for directory fsync after rename operation

On Thu, Feb 18, 2016 at 1:30 AM, Dave Chinner <da...@fromorbit.com> wrote: > On Mon, Feb 15, 2016 at 10:54:23AM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> Test that if we move one file between directories, fsync the parent

Re: [PATCH 1/2] fstests: generic test for directory fsync after rename operation

On Thu, Feb 18, 2016 at 4:43 PM, Darrick J. Wong <darrick.w...@oracle.com> wrote: > On Thu, Feb 18, 2016 at 01:38:41PM +0000, Filipe Manana wrote: >> On Thu, Feb 18, 2016 at 1:30 AM, Dave Chinner <da...@fromorbit.com> wrote: >> > On Mon, Feb 15, 2016 at 10:54:23AM +0

Re: [PATCH] Btrfs: fix deadlock between direct IO reads and buffered writes

On Thu, Feb 18, 2016 at 7:53 PM, Liu Bo <bo.li@oracle.com> wrote: > On Thu, Feb 18, 2016 at 05:42:50PM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> While running a test with a mix of buffered IO and direct IO against &

Re: [RFC - PATCH] btrfs: do not write corrupted metadata blocks to disk

On Sun, Feb 21, 2016 at 3:36 PM, Alex Lyakas wrote: > csum_dirty_buffer was issuing a warning in case the extent buffer > did not look alright, but was still returning success. > Let's return error in this case, and also add two additional sanity > checks on the extent

Re: [PATCH 2/2] btrfs: avoid overflowing f_bfree

On Wed, Mar 30, 2016 at 9:53 PM, Luis de Bethencourt wrote: > Since mixed block groups accounting isn't byte-accurate and f_bree is an > unsigned integer, it could overflow. Avoid this. > > Signed-off-by: Luis de Bethencourt > Suggested-by: David

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

On Thu, Apr 7, 2016 at 5:44 PM, Holger Hoffstätte wrote: > Hi, > > Looks like I just found an exciting new corner case. > kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. > > Try on a fresh volume: > > $btrfs subvolume create foo > Create subvolume './foo'

Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

rfs fix this patch relates to can be found at the following url: > http://thread.gmane.org/gmane.comp.file-systems.btrfs/54755 > > Thanks, > --Mark > > Signed-off-by: Mark Fasheh <mfas...@suse.de> Reviewed-by: Filipe Manana <fdman...@suse.com> Looks good,

Re: [PATCH] btrfs: qgroup: Fix qgroup accounting when creating snapshot

On Wed, Apr 6, 2016 at 3:04 AM, Qu Wenruo wrote: > Current btrfs qgroup design implies a requirement that after calling > btrfs_qgroup_account_extents() there must be a commit root switch. > > Normally this is OK, as btrfs_qgroup_accounting_extents() is only called >

Re: [PATCH] btrfs: handle non-fatal errors in btrfs_qgroup_inherit()

On Thu, Mar 31, 2016 at 1:57 AM, Mark Fasheh wrote: > create_pending_snapshot() will go readonly on _any_ error return from > btrfs_qgroup_inherit(). If qgroups are enabled, a user can crash their fs by > just making a snapshot and asking it to inherit from an invalid qgroup. For

Re: WARN_ON in record_root_in_trans() when deleting freshly renamed subvolume

On Thu, Apr 7, 2016 at 5:44 PM, Holger Hoffstätte wrote: > Hi, > > Looks like I just found an exciting new corner case. > kernel 4.4.6 with btrfs ~4.6, so 4.6 should reproduce. Using Chris' for-linus-4.6 branch, which is 4.5-rc6 + all 4.6 btrfs patches, it

Re: [PATCH] btrfs:Change BUG_ON to new error path in __clear_extent_bit

On Wed, Apr 6, 2016 at 4:56 PM, Bastien Philbert wrote: > This remove the unnessary BUG_ON if the allocation with > alloc_extent_state_atomic fails due to this function > failure not being unrecoverable. Instead we now change > this BUG_ON into a new error path that

Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

On Thu, Apr 7, 2016 at 12:22 AM, Mark Fasheh <mfas...@suse.de> wrote: > On Wed, Apr 06, 2016 at 10:40:02PM +0100, Filipe Manana wrote: >> On Wed, Apr 6, 2016 at 10:30 PM, Mark Fasheh <mfas...@suse.de> wrote: >> > Test that an invalid parent qgroup does not cause

Re: [PATCH v2] fstests: test fsync on overlayfs merged directory

On Tue, Mar 22, 2016 at 3:00 AM, Eryu Guan <eg...@redhat.com> wrote: > On Mon, Mar 21, 2016 at 05:50:25PM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> Test that calling fsync against a file using the merged directory does &

Re: [PATCH] fstest: btrfs: remove _need_to_be_root fix btrfs/118

On Thu, Mar 24, 2016 at 10:13 AM, Anand Jain wrote: > commit 56ff01f471c9b72de0a447b37cdb1051adcede6a > xfstests: remove _need_to_be_root > > Removed _need_to_be_root(), and so btrfs/118 needs an update

Re: [PATCH] fstest: btrfs: update 048.out inline with ui changes

On Thu, Mar 24, 2016 at 10:11 AM, Anand Jain wrote: > To be inline with progs changes > 28831d54895443e5fc795392f23ce3a8b122cb71 > btrfs-progs: cmd property: switch to common error message wrapper > update 048.out > > Signed-off-by: Anand Jain >

Re: [PATCH] Btrfs: fix crash/invalid memory access on fsync when using overlayfs

On Mon, Mar 21, 2016 at 5:51 PM, Chris Mason <c...@fb.com> wrote: > On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote: >> From: Filipe Manana <fdman...@suse.com> >> >> If the lower or upper directory of an overlayfs mount belong to a btrfs >

Re: [PATCH] Btrfs: fix crash/invalid memory access on fsync when using overlayfs

On Fri, Mar 25, 2016 at 6:49 PM, Chris Mason <c...@fb.com> wrote: > On Mon, Mar 21, 2016 at 05:52:44PM +0000, Filipe Manana wrote: >> On Mon, Mar 21, 2016 at 5:51 PM, Chris Mason <c...@fb.com> wrote: >> > On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel

Re: [PATCH] Show a warning message if one of highest objectid reaches its max value

On Fri, Mar 4, 2016 at 2:37 AM, Satoru Takeuchi wrote: > - It's better to show a warning message for the exceptional case > that one of highest objectid (in most case, inode number) > reaches its max value, BTRFS_LAST_FREE_OBJECTID. Show this > message only

Re: [PATCH] Btrfs: fix loading of orphan roots leading to BUG_ON

On Thu, Mar 3, 2016 at 6:29 AM, Qu Wenruo <quwen...@cn.fujitsu.com> wrote: > > > wrote on 2016/03/02 15:49 +0000: >> >> From: Filipe Manana <fdman...@suse.com> >> >> When looking for orphan roots during mount we can end up hitting a >> BUG_ON()

Re: [PATCH] Btrfs: fix loading of orphan roots leading to BUG_ON

On Thu, Mar 3, 2016 at 4:31 AM, Duncan <1i5t5.dun...@cox.net> wrote: > fdmanana posted on Wed, 02 Mar 2016 15:49:38 + as excerpted: > >> When looking for orphan roots during mount we can end up hitting a >> BUG_ON() (at root-item.c:btrfs_find_orphan_roots()) if a log tree is >> replayed and

Re: ENOSPC while creating snapshot

On Sat, Mar 5, 2016 at 2:09 AM, Duncan <1i5t5.dun...@cox.net> wrote: > Roman Mamedov posted on Sat, 05 Mar 2016 03:49:10 +0500 as excerpted: > >> As you use the nodatacow mount option, this seems to be another case of >> http://www.spinics.net/lists/linux-btrfs/msg51276.html >>

Re: [PATCH 2/2] fstests: generic test for fsync after renaming file

On Wed, Mar 30, 2016 at 10:39 AM, <fdman...@kernel.org> wrote: > From: Filipe Manana <fdman...@suse.com> > > Test that if we rename a file, create a new file that has the old name > of the other file and is a child of the same parent directory, fsync the > new

Re: [PATCH] Btrfs: fix unreplayable log after snapshot deletion and parent re-creation

On Thu, Mar 24, 2016 at 5:06 PM, <fdman...@kernel.org> wrote: > From: Filipe Manana <fdman...@suse.com> > > If we delete a snapshot, delete its parent directory, create a new > directory with the same name as that parent and then fsync either that > new directory or som

Re: [PATCH] delete obsolete function btrfs_print_tree()

On Mon, Apr 4, 2016 at 4:54 PM, Holger Hoffstätte wrote: > On 04/04/16 15:56, David Sterba wrote: >> On Fri, Mar 25, 2016 at 03:53:17PM +0100, Holger Hoffstätte wrote: >>> Dan Carpenter's static checker recently found missing IS_ERR handling >>> in

Re: [PATCH 2/2] btrfs: do not write corrupted metadata blocks to disk

heck on the extent buffer header. > The caller up the chain may BUG_ON on this, for example flush_epd_write_bio > will, > but it is better than to have a silent metadata corruption on disk. > > Signed-off-by: Alex Lyakas <a...@zadarastorage.com> Reviewed-by: Filipe Manana <fdman

Re: [PATCH 1/2] btrfs: csum_tree_block: return proper errno value

On Thu, Mar 10, 2016 at 11:09 AM, Alex Lyakas <alex.bols...@gmail.com> wrote: > Signed-off-by: Alex Lyakas <a...@zadarastorage.com> Reviewed-by: Filipe Manana <fdman...@suse.com> > --- > fs/btrfs/disk-io.c | 13 + > 1 file changed, 5 insertions(+), 8 de

Re: [PATCH v2] btrfs: qgroup: Fix qgroup accounting when creating snapshot

On Tue, Apr 12, 2016 at 8:35 AM, Qu Wenruo wrote: > Current btrfs qgroup design implies a requirement that after calling > btrfs_qgroup_account_extents() there must be a commit root switch. > > Normally this is OK, as btrfs_qgroup_accounting_extents() is only called >

Re: [PATCH] btrfs: do not return EBUSY on concurrent subvolume mounts

On Wed, Apr 27, 2016 at 4:14 PM, David Sterba wrote: > A user reported mount failures with EBUSY during boot, there's root > partition and many subvolumes, mounted via /etc/fstab. > > The failure depends on timing, when multiple subvolumes reach the code > between superblock

Re: [PATCH 13/16] btrfs: __set_extent_bit, try preallocation out of locked section with lighter gfp flags

On Fri, Apr 29, 2016 at 10:20 AM, David Sterba wrote: > In __set_extent_bit we allocate with GFP_ATOMIC with the tree lock > held, this takes away allocator opportunities to satisfy the allocation. > In some cases we leave the locked section and we could repeat the >

Re: [PATCH V18 00/18] Allow I/O on blocks whose size is less than page size

On Tue, Apr 26, 2016 at 2:26 PM, Chandan Rajendra wrote: > Btrfs assumes block size to be the same as the machine's page > size. This would mean that a Btrfs instance created on a 4k page size > machine (e.g. x86) will not be mountable on machines with larger page >

Re: [PATCH 0/3] Fixes for races in relocation and avoid start and wait for unrelated IO

On Tue, Apr 26, 2016 at 2:42 PM, Holger Hoffstätte wrote: > On Mon, Apr 25, 2016 at 3:01 AM, wrote: >> The following patches fix 2 hard to hit races in relocation that make its >> first phase (MOVE_DATA_EXTENTS) miss extents, triggers a

Re: [PATCH v2 2/2] Btrfs: don't do unnecessary delalloc flushes when relocating

On Tue, Apr 26, 2016 at 5:02 PM, Josef Bacik <jba...@fb.com> wrote: > On 04/26/2016 11:39 AM, fdman...@kernel.org wrote: >> >> From: Filipe Manana <fdman...@suse.com> >> >> Before we start the actual relocation process of a block group, we do >> calls

<    1   2   3   4   5   6   7   8   >