Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-28 Thread Omar Sandoval
On Tue, Jul 28, 2015 at 06:52:07PM +0200, David Sterba wrote: On Tue, Jul 28, 2015 at 12:22:56AM +0200, Brendan Hide wrote: It does not, I apparently forgot that you could use single to concatenate multiple devices. I'll fix that in v2. Thanks for reviewing! Late to the party.

Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-27 Thread Hugo Mills
On Tue, Jul 28, 2015 at 12:22:56AM +0200, Brendan Hide wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2015/07/24 07:50 PM, Omar Sandoval wrote: On Fri, Jul 24, 2015 at 02:09:46PM +0200, David Sterba wrote: On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote: +

Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-27 Thread Brendan Hide
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2015/07/24 07:50 PM, Omar Sandoval wrote: On Fri, Jul 24, 2015 at 02:09:46PM +0200, David Sterba wrote: On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote: + # We can't do replace with these profiles because they +

Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-24 Thread Omar Sandoval
On Fri, Jul 24, 2015 at 02:09:46PM +0200, David Sterba wrote: On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote: + # We can't do replace with these profiles because they + # imply only one device ($SCRATCH_DEV), and we need to +

Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-24 Thread David Sterba
On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote: + # We can't do replace with these profiles because they + # imply only one device ($SCRATCH_DEV), and we need to + # keep $SCRATCH_DEV around for _scratch_mount +

[PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-23 Thread Omar Sandoval
Replacing and scrubbing RAID 5/6 is now supported on Btrfs. Enable it in _btrfs_get_profile_configs while making it more generic to also support replace missing. Signed-off-by: Omar Sandoval osan...@fb.com --- common/rc | 96 --- 1 file

Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs

2015-07-23 Thread Eryu Guan
On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote: Replacing and scrubbing RAID 5/6 is now supported on Btrfs. Enable it in _btrfs_get_profile_configs while making it more generic to also support replace missing. Signed-off-by: Omar Sandoval osan...@fb.com Looks great! Tested