[PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Filipe Manana
If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info-caching_block_groups that points to the block group and is accessed at transaction commit time. This results in accessing an invalid or incorrect block group. This issue became visible after

Re: [PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Josef Bacik
On 11/26/2014 10:28 AM, Filipe Manana wrote: If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info-caching_block_groups that points to the block group and is accessed at transaction commit time. This results in accessing an invalid or

Re: [PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Filipe David Manana
On Wed, Nov 26, 2014 at 3:57 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 10:28 AM, Filipe Manana wrote: If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info-caching_block_groups that points to the block group and is accessed at

Re: [PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Josef Bacik
On 11/26/2014 11:09 AM, Filipe David Manana wrote: On Wed, Nov 26, 2014 at 3:57 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 10:28 AM, Filipe Manana wrote: If we remove a block group (because it became empty), we might have left a caching_ctl structure in fs_info-caching_block_groups

Re: [PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Filipe David Manana
On Wed, Nov 26, 2014 at 4:24 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 11:09 AM, Filipe David Manana wrote: On Wed, Nov 26, 2014 at 3:57 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 10:28 AM, Filipe Manana wrote: If we remove a block group (because it became empty), we might

Re: [PATCH 2/6] Btrfs: fix crash caused by block group removal

2014-11-26 Thread Josef Bacik
On 11/26/2014 11:34 AM, Filipe David Manana wrote: On Wed, Nov 26, 2014 at 4:24 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 11:09 AM, Filipe David Manana wrote: On Wed, Nov 26, 2014 at 3:57 PM, Josef Bacik jba...@fb.com wrote: On 11/26/2014 10:28 AM, Filipe Manana wrote: If we