Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-21 Thread Brendan Hide
On 2014/05/21 06:15 AM, Qu Wenruo wrote: [snip] Further on top of your check_missing patch I am writing code to to handle disk reappear. I should be sending them all soon. Disk reappear problem is also reproduce here. I am intersting about how will your patch to deal with. Is your patch

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Qu Wenruo
I'm sorry to bother your but it has been about 2 weeks after your last reply. Is there any problem? Thanks, Qu Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Anand Jain
Hi Qu, Either we need to determine missing disk when disk disappear or when we hit by -ENODEV during IO. Discovering the same at the time when user run 'btrfs fi show' or 'btrfs dev del', is just not correct. You might use interface as proposed here. [PATCH RFC] btrfs: revamp

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Anand Jain
. Thanks, Anand On 21/05/14 11:12, Qu Wenruo wrote: I'm sorry to bother your but it has been about 2 weeks after your last reply. Is there any problem? Thanks, Qu Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月21日 11:54 Hi Qu, Thanks for checking with me. sorry for the delay

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-07 Thread Anand Jain
Thanks for working on this. I am running some tests will let you know. Anand On 05/06/2014 02:33 PM, Qu Wenruo wrote: Old btrfs can't find a missing btrfs device since there is no mechanism for block layer to inform fs layer. But we can use a workaround that only check status(by using

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-07 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月07日 16:00 Thanks for working on this. I am running some tests will let you know

[RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-06 Thread Qu Wenruo
Old btrfs can't find a missing btrfs device since there is no mechanism for block layer to inform fs layer. But we can use a workaround that only check status(by using request_queue-queue_flags) of every device in a btrfs filesystem when calling dev_info/rm_dev ioctl, since other ioctls do not