Re: Fixup direct bi_rw modifiers

2016-08-02 Thread Jens Axboe
On 08/02/2016 05:32 AM, Christoph Hellwig wrote: On Mon, Aug 01, 2016 at 01:55:36PM -0600, Jens Axboe wrote: Set of three patches, where the target one is an actual bug fix... Temporary branch, I'll rebase it once -rc1 is out, if more changes/fixups need to be made in the next week until that

Re: Fixup direct bi_rw modifiers

2016-08-02 Thread Christoph Hellwig
On Mon, Aug 01, 2016 at 01:55:36PM -0600, Jens Axboe wrote: > > Set of three patches, where the target one is an actual bug fix... > Temporary branch, I'll rebase it once -rc1 is out, if more > changes/fixups need to be made in the next week until that happens. > >

Re: Fixup direct bi_rw modifiers

2016-08-01 Thread Jens Axboe
On 08/01/2016 09:17 AM, Jens Axboe wrote: On 08/01/2016 05:47 AM, Christoph Hellwig wrote: On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote: bi_rw should be using bio_set_op_attrs to set bi_rw. Looks fine, Reviewed-by: Christoph Hellwig Added, thanks Shaun.

Re: Fixup direct bi_rw modifiers

2016-08-01 Thread Jens Axboe
On 08/01/2016 05:47 AM, Christoph Hellwig wrote: On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote: bi_rw should be using bio_set_op_attrs to set bi_rw. Looks fine, Reviewed-by: Christoph Hellwig Added, thanks Shaun. Jens, what do you think about renaming

Re: Fixup direct bi_rw modifiers

2016-08-01 Thread Christoph Hellwig
On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote: > bi_rw should be using bio_set_op_attrs to set bi_rw. Looks fine, Reviewed-by: Christoph Hellwig Jens, what do you think about renaming bi_rw? There aren't too many users left, and any old code that would keep

Fixup direct bi_rw modifiers

2016-07-30 Thread Shaun Tancheff
bi_rw should be using bio_set_op_attrs to set bi_rw. Signed-off-by: Shaun Tancheff Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: Mike Christie --- Patch is against linux-next tag next-20160729