On Sun, Feb 01, 2015 at 11:51:19PM +0300, Dan Carpenter wrote:
Hello Mark Fasheh,
The patch 1152651a0817: btrfs: qgroup: account shared subtrees
during snapshot delete from Jul 17, 2014, leads to the following
static checker warning:
What checker are you using?
fs/btrfs/extent
Hello Mark Fasheh,
The patch 1152651a0817: btrfs: qgroup: account shared subtrees
during snapshot delete from Jul 17, 2014, leads to the following
static checker warning:
fs/btrfs/extent-tree.c:7642 account_shared_subtree()
error: off-by-one overflow 'path-nodes' size 8. index
On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote:
On 07/17/2014 03:39 PM, Mark Fasheh wrote:
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
On 07/17/2014 03:39 PM, Mark Fasheh wrote:
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
On Tue, Aug 12, 2014 at 02:36:17PM -0400, Chris Mason wrote:
On 08/12/2014 02:32 PM, Mark Fasheh wrote:
On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote:
On 07/17/2014 03:39 PM, Mark Fasheh wrote:
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees
On 08/12/2014 03:01 PM, Mark Fasheh wrote:
On Tue, Aug 12, 2014 at 02:36:17PM -0400, Chris Mason wrote:
On 08/12/2014 02:32 PM, Mark Fasheh wrote:
On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote:
On 07/17/2014 03:39 PM, Mark Fasheh wrote:
During its tree walk,
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
removing our snapshot root leaves the subtree with
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
removing our snapshot root leaves the subtree with
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
removing our snapshot root leaves the subtree with
During its tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
removing our snapshot root leaves the subtree with
On Fri, Jun 20, 2014 at 08:29:58AM -0700, Mark Fasheh wrote:
+static int account_shared_subtree(struct btrfs_trans_handle *trans,
+ struct btrfs_root *root,
+ struct extent_buffer *root_eb,
+ u64
On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
We don't pay attention to the return value, we should probably abort the
transaction if there is a problem.
Abort or log an error and continue? I ask because technically we could
continue with the subvolume drop but obviously
that. Below is patch #2 with all review comments
implemented.
Thanks, Mark
--
Mark Fasheh
From: Mark Fasheh mfas...@suse.de
btrfs: qgroup: account shared subtrees during snapshot delete
During it's tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when
On 06/20/2014 08:29 AM, Mark Fasheh wrote:
On Fri, Jun 20, 2014 at 01:25:34PM +0200, David Sterba wrote:
On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
We don't pay attention to the return value, we should probably abort the
transaction if there is a problem.
Abort or log an
During it's tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
removing our snapshot root leaves the subtree
On 06/19/2014 02:49 PM, Mark Fasheh wrote:
During it's tree walk, btrfs_drop_snapshot() will skip any shared
subtrees it encounters. This is incorrect when we have qgroups
turned on as those subtrees need to have their contents
accounted. In particular, the case we're concerned with is when
Thanks for the review Josef, I will implement everything you mentioned. I
have one question below though:
On Thu, Jun 19, 2014 at 03:25:12PM -0700, Josef Bacik wrote:
On 06/19/2014 02:49 PM, Mark Fasheh wrote:
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 46f39bf..672d2a4
On 06/19/2014 04:16 PM, Mark Fasheh wrote:
Thanks for the review Josef, I will implement everything you mentioned. I
have one question below though:
On Thu, Jun 19, 2014 at 03:25:12PM -0700, Josef Bacik wrote:
On 06/19/2014 02:49 PM, Mark Fasheh wrote:
diff --git a/fs/btrfs/extent-tree.c
18 matches
Mail list logo
