Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-26 Thread Brendan Hide
On 2014/04/16 05:22 PM, David Sterba wrote: On Wed, Apr 16, 2014 at 04:59:09PM +0200, Brendan Hide wrote: On 2014/04/16 03:40 PM, Chris Mason wrote: So in my example with the automated tool, the tool really shouldn't be deleting a snapshot where send is in progress. The tool should be told

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-16 Thread David Sterba
On Tue, Apr 15, 2014 at 01:21:46PM -0400, Chris Mason wrote: On 04/15/2014 12:27 PM, David Sterba wrote: On Tue, Apr 15, 2014 at 12:00:49PM -0400, Chris Mason wrote: I'm worried about the use case where we have: * periodic automated snapshots * periodic automated deletion of old

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-16 Thread Chris Mason
On 04/16/2014 09:32 AM, David Sterba wrote: On Tue, Apr 15, 2014 at 01:21:46PM -0400, Chris Mason wrote: On 04/15/2014 12:27 PM, David Sterba wrote: On Tue, Apr 15, 2014 at 12:00:49PM -0400, Chris Mason wrote: I'm worried about the use case where we have: * periodic automated

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-16 Thread Brendan Hide
On 2014/04/16 03:40 PM, Chris Mason wrote: So in my example with the automated tool, the tool really shouldn't be deleting a snapshot where send is in progress. The tool should be told that snapshot is busy and try to delete it again later. It makes more sense now, 'll queue this up for 3.16

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-16 Thread David Sterba
On Wed, Apr 16, 2014 at 09:40:41AM -0400, Chris Mason wrote: It makes more sense now, 'll queue this up for 3.16 and we can try it out in -next. Thanks. 3.16 is fine for me. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-16 Thread David Sterba
On Wed, Apr 16, 2014 at 04:59:09PM +0200, Brendan Hide wrote: On 2014/04/16 03:40 PM, Chris Mason wrote: So in my example with the automated tool, the tool really shouldn't be deleting a snapshot where send is in progress. The tool should be told that snapshot is busy and try to delete it

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-15 Thread Chris Mason
On 04/15/2014 10:41 AM, David Sterba wrote: The patch Btrfs: fix protection between send and root deletion (18f687d538449373c37c) does not actually prevent to delete the snapshot and just takes care during background cleaning, but this seems rather user unfriendly, this patch implements the idea

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-15 Thread David Sterba
On Tue, Apr 15, 2014 at 10:52:14AM -0400, Chris Mason wrote: On 04/15/2014 10:41 AM, David Sterba wrote: The patch Btrfs: fix protection between send and root deletion (18f687d538449373c37c) does not actually prevent to delete the snapshot and just takes care during background cleaning, but

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-15 Thread Chris Mason
On 04/15/2014 11:44 AM, David Sterba wrote: On Tue, Apr 15, 2014 at 10:52:14AM -0400, Chris Mason wrote: On 04/15/2014 10:41 AM, David Sterba wrote: The patch Btrfs: fix protection between send and root deletion (18f687d538449373c37c) does not actually prevent to delete the snapshot and just

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-15 Thread David Sterba
On Tue, Apr 15, 2014 at 12:00:49PM -0400, Chris Mason wrote: I'm worried about the use case where we have: * periodic automated snapshots * periodic automated deletion of old snapshots * periodic send for backup The automated deletion doesn't want to error out if send is in

Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send

2014-04-15 Thread Chris Mason
On 04/15/2014 12:27 PM, David Sterba wrote: On Tue, Apr 15, 2014 at 12:00:49PM -0400, Chris Mason wrote: I'm worried about the use case where we have: * periodic automated snapshots * periodic automated deletion of old snapshots * periodic send for backup The automated deletion