Hi again
ping again ?
> ping ?
>
> >
> > From: Kuninori Morimoto
> >
> > This patch adds CS2000 Fractional-N driver as clock provider.
> >
> > Signed-off-by: Kuninori Morimoto
> > ---
> > v5 -> v6
> >
> > - remove red
Hi
ping ?
>
> From: Kuninori Morimoto
>
> This patch adds CS2000 Fractional-N driver as clock provider.
>
> Signed-off-by: Kuninori Morimoto
> ---
> v5 -> v6
>
> - remove redundant variable from each functions
> - multi line code become
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
Signed-off-by: Kuninori Morimoto
---
v5 -> v6
- remove redundant variable from each functions
- multi line code become one line
- end of comment has dot
- cs2000_wait_pll_lock() returns -ETIMED
Hi Andy
> >> > +static int cs2000_wait_pll_lock(struct cs2000_priv *priv)
> >> > +{
> >> > + struct device *dev = priv_to_dev(priv);
> >> > + s32 val;
> >> > + unsigned int i;
> >> > +
> >> > + for (i = 0; i < 256; i++) {
> >> > + val = cs2000_read(priv, DEVI
Hi
Thank you for your feedback
> > From: Kuninori Morimoto
>
> Hmm… Something wrong with send-email settings?
Nothing wrong. I would like to overwrite Author
(Sender and Author are same though...)
> > +#define priv_to_client(priv) (priv->client)
>
> t
Hi again
ping again ?
> [R] 森本 wrote:
> >
> > From: Kuninori Morimoto
> >
> > This patch adds CS2000 Fractional-N driver as clock provider.
> >
> > Signed-off-by: Kuninori Morimoto
> > ---
> > v4 -> v5
> >
> > - remov
Hi
ping ?
[R] 森本 wrote:
>
> From: Kuninori Morimoto
>
> This patch adds CS2000 Fractional-N driver as clock provider.
>
> Signed-off-by: Kuninori Morimoto
> ---
> v4 -> v5
>
> - remove "clock-frequency"
> - use dev on clk_register()
>
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
Signed-off-by: Kuninori Morimoto
---
v4 -> v5
- remove "clock-frequency"
- use dev on clk_register()
- remove CLK_IS_BASIC
- .enable -> .prepare since it is using I2C
. .disabe -> .un
And requested clock requests this clock too.
Thus, these clocks have dead lock on probe time
cs2000: clk_multiplier@4f {
...
clocks = <&rcar_sound 0>, ...
...
};
&rcar_sound {
...
assigned-clocks = <&
Hi Stephen
Thank you for your review
> > + init.parent_names = parent_names;
> > + init.num_parents= ARRAY_SIZE(parent_names);
> > +
> > + priv->hw.init = &init;
> > +
> > + clk = clk_register(NULL, &priv->hw);
>
> How about using devm_clk_register() and passing the i2c de
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
Signed-off-by: Kuninori Morimoto
---
v3 -> v4
- clk_ops base
- add #clock-cells on document
- drop 0x from example
- add "." on document
- drop parentheses
- care of_clk_add_provide
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
It is useful if it supports runtime clock setting, but it supports
fixed clock rate only at this point.
Signed-off-by: Kuninori Morimoto
---
v2 -> v3
- cs2000_ratio_set() used "val = (u64)rate_o
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
It is useful if it supports runtime clock setting, but it supports
fixed clock rate only at this point.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- adds "clock-names" in DT
- it uses "
Hi Geert
Thank you for your review
> > From: Kuninori Morimoto
> >
> > This patch adds CS2000 Fractional-N driver as clock provider.
> > It is useful if it supports runtime clock setting, but it supports
> > fixed clock rate only at this point.
> >
From: Kuninori Morimoto
This patch adds CS2000 Fractional-N driver as clock provider.
It is useful if it supports runtime clock setting, but it supports
fixed clock rate only at this point.
Signed-off-by: Kuninori Morimoto
---
.../devicetree/bindings/clock/cs2000-cp.txt| 20
15 matches
Mail list logo
