Re: [PATCH] crypto: authenc - convert to ahash

2009-07-20 Thread Steffen Klassert
On Mon, Jul 20, 2009 at 02:52:44PM +0800, Herbert Xu wrote: This is not quite right. What I had in mind was to use the digest interface if the assoc SG list has a single entry in it. Otherwise it should just fall back to doing update followed by finup. Ok. I was not even aware that the

Re: [RFC] [PATCH 2/7] crypto: authenc - convert to ahash

2009-07-20 Thread Steffen Klassert
On Mon, Jul 20, 2009 at 02:55:14PM +0800, Herbert Xu wrote: For the case at hand, as we've agreed to only do the chaining if there is only a single entry in the list, we don't need this at all. All you need to do is copy the page pointer, offset and length without copying the raw

Re: [RFC] [PATCH 2/7] crypto: authenc - convert to ahash

2009-07-20 Thread Herbert Xu
On Mon, Jul 20, 2009 at 09:57:01AM +0200, Steffen Klassert wrote: Agreed for this case. What about the existing code, should we create an interface for it? Can you point me to the existing code? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~}

Re: [PATCH] crypto: authenc - convert to ahash

2009-07-20 Thread Herbert Xu
On Mon, Jul 20, 2009 at 09:49:56AM +0200, Steffen Klassert wrote: Aside the optimization, another reason to use the digest interface was to avoid callback functions for init, update and finup. I guess we can not avoid this if assoc can be a sg list with more than one entry, so I'll update the

Re: [PATCH] crypto: authenc - convert to ahash

2009-07-20 Thread Steffen Klassert
On Mon, Jul 20, 2009 at 04:22:24PM +0800, Herbert Xu wrote: Actually, you can assume that init is always sync since I'll ensure that everything supports export/import before hmac is converted to ahash (from shash). Ok, I'll update and resend the patch. Thanks. -- To unsubscribe from this