Re: [PATCH resend 00/15] arm64 crypto roundup

2014-05-08 Thread Ard Biesheuvel
On 8 May 2014 23:50, Catalin Marinas wrote: > On 8 May 2014, at 12:22, Ard Biesheuvel wrote: >> On 7 May 2014 16:45, Catalin Marinas wrote: >>> On Thu, May 01, 2014 at 04:49:32PM +0100, Ard Biesheuvel wrote: This is a repost of the arm64 crypto patches that I have posted to the LAKML

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-05-08 Thread Stanimir Vabanov
Hi Herbert, On 04/28/2014 11:59 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +#define QCE_MAJOR_VERSION5 0x05 >> +#define QCE_QUEUE_LENGTH50 > > What is the purpose of this software queue? Why can't you directly > feed the requests to the h

Re: [PATCH resend 00/15] arm64 crypto roundup

2014-05-08 Thread Catalin Marinas
On 8 May 2014, at 12:22, Ard Biesheuvel wrote: > On 7 May 2014 16:45, Catalin Marinas wrote: >> On Thu, May 01, 2014 at 04:49:32PM +0100, Ard Biesheuvel wrote: >>> This is a repost of the arm64 crypto patches that I have posted to the LAKML >>> over the past months. They have now been verified on

Re: [PATCH 00/11] crypto: caam: Error reporting fixes

2014-05-08 Thread Marek Vasut
On Thursday, May 08, 2014 at 04:01:06 PM, Herbert Xu wrote: > On Thu, Apr 24, 2014 at 08:05:11PM +0200, Marek Vasut wrote: > > First stab at reworking the error.c thing in Freescale CAAM. > > This patchset cleans it up so it's not doing any too insane > > string messing anymore. > > > > NOTE: Can

Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support

2014-05-08 Thread Herbert Xu
On Mon, Apr 28, 2014 at 10:44:52AM +, Naveen Krishna Chatradhi wrote: > SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added > features to the one on S5PV210. However with minor changes the s5p-sss.c > driver can be reused to support SSS modules on Exynos4 and 5 SoCs. > > This pa

Re: [PATCH] crypto: user - Allow CRYPTO_MSG_GETALG without CAP_NET_ADMIN

2014-05-08 Thread Herbert Xu
On Thu, Apr 24, 2014 at 10:51:06PM +, Matthias-Christian Ott wrote: > > CRYPTO_USER requires CAP_NET_ADMIN for all operations. Most information > provided by CRYPTO_MSG_GETALG is also accessible through /proc/modules > and AF_ALG. CRYPTO_MSG_GETALG should not require CAP_NET_ADMIN so that > pr

Re: [PATCH] s390/crypto: fix aes,des ctr mode concurrency finding.

2014-05-08 Thread Herbert Xu
On Wed, May 07, 2014 at 04:51:29PM +0200, Harald Freudenberger wrote: > An additional testcase found an issue with the last > series of patches applied: the fallback solution may > not save the iv value after operation. This very small > fix just makes sure the iv is copied back to the > walk/desc

Re: [PATCH 00/11] crypto: caam: Error reporting fixes

2014-05-08 Thread Herbert Xu
On Thu, Apr 24, 2014 at 08:05:11PM +0200, Marek Vasut wrote: > First stab at reworking the error.c thing in Freescale CAAM. > This patchset cleans it up so it's not doing any too insane > string messing anymore. > > NOTE: Can someone please test this on real hardware? I have > none at hand,

Re: [PATCH] crypto: caam - Fix key inlining in AEAD shared descriptors

2014-05-08 Thread Herbert Xu
On Tue, May 06, 2014 at 03:11:14PM -0500, Kim Phillips wrote: > > > > > I think that the form I submitted is equally easy to read. > > > > > > adding one line instead of two -> less lines overall -> more code on one > > > screen -> easier to read. > > > > I think that this is a matter of personal

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-08 Thread Herbert Xu
On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote: > Coverity detected possible use of uninitialized pointer when printing info > message during module load. While this is higly unlikely to cause any troubles > simple change in sha1_ssse3_mod_init to make it look like sha256/512 init >

Re: [PATCH resend 00/15] arm64 crypto roundup

2014-05-08 Thread Ard Biesheuvel
On 7 May 2014 16:45, Catalin Marinas wrote: > On Thu, May 01, 2014 at 04:49:32PM +0100, Ard Biesheuvel wrote: >> This is a repost of the arm64 crypto patches that I have posted to the LAKML >> over the past months. They have now been verified on actual hardware >> (Cortex-A57) so if there are no r