[PATCH v2] crypto: qat - enable VF irq after guest exits ungracefully

2015-12-09 Thread Tadeusz Struk
From: Zeng Xin The VF bundle interrupt is not triggered any more in the case when guest is shut down with sample app running. Need to clear the flag interrupt bit when restarting to fix this irrecoverable state. Signed-off-by: Zeng Xin Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_c

Re: [PATCH] crypto: qat - enable VF irq after guest exits ungracefully

2015-12-09 Thread Tadeusz Struk
Hi Herbert, On 12/09/2015 11:59 AM, Tadeusz Struk wrote: > From: Signed-off-by: Zeng Xin > > The VF bundle interrupt is not triggered any more in > the case when guest is shut down with sample app running. > Need to clear the flag interrupt bit when restarting to fix > this irrecoverable state. >

Re: [cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation

2015-12-09 Thread Herbert Xu
On Thu, Dec 10, 2015 at 02:49:27AM +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2 > commit: 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6 [53/54] crypto: rsa - RSA > padd

Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

2015-12-09 Thread Herbert Xu
On Wed, Dec 09, 2015 at 09:23:14AM -0800, Tim Chen wrote: > > This is an internal algorithm. We are indeed casting the request > to the outer ablkcipher request when we do the async cipher walk. The question remain: why does it have to be a blkcipher rather than an ablkcipher? Cheers, -- Email

Re: [RFC PATCH V2] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

2015-12-09 Thread Zain
Hi, 在 2015年12月09日 18:55, LABBE Corentin 写道: > Hello > > I have some comments below. Thanks for your comments.:-) > > On Wed, Dec 09, 2015 at 06:16:42PM +0800, Zain Wang wrote: >> Add md5 sha1 sha256 support for crypto engine in rk3288. >> This patch can't support multiple updatings because of limi

[PATCH 1/2] crypto: KEYS: convert public key to the akcipher api

2015-12-09 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +- crypto/asymmetric_keys/pkcs7_trus

[PATCH 2/2] integrity: convert digsig to akcipher api

2015-12-09 Thread Tadeusz Struk
Convert asymmetric_verify to akcipher api. Signed-off-by: Tadeusz Struk --- security/integrity/digsig_asymmetric.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c index 4fec181..55f4

[PATCH 0/2] crypto: KEYS: convert public key to akcipher api

2015-12-09 Thread Tadeusz Struk
This patch set converts the module verification and digital signature code to the new akcipher API. RSA implementation has been removed from crypto/asymmetric_keys and the new API is used for cryptographic primitives. There is no need for MPI above the akcipher API anymore. Modules can be verified

[cryptodev:master 50/54] adf_c3xxxvf_hw_data.c:undefined reference to `adf_iov_putmsg'

2015-12-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2 commit: 8b206f2d666f41f0aa83dec83504801ee945d3dc [50/54] crypto: qat - add support for c3xxxvf accel type config: x86_64-randconfig-x009-12092253 (attached as

[PATCH] crypto: qat - select PCI_IOV when VF are enabled

2015-12-09 Thread Tadeusz Struk
Fix i386-randconfig-x004-12092241. PCI_IOV needs to be selected when VFs are enabled Reported-by: Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig index d275d48..85b44e5 1

[PATCH] crypto: qat - enable VF irq after guest exits ungracefully

2015-12-09 Thread Tadeusz Struk
From: Signed-off-by: Zeng Xin The VF bundle interrupt is not triggered any more in the case when guest is shut down with sample app running. Need to clear the flag interrupt bit when restarting to fix this irrecoverable state. Signed-off-by: Zeng Xin Signed-off-by: Tadeusz Struk --- drivers/c

[PATCH] crypto: asymmetric_keys/signature.c does not need

2015-12-09 Thread Paul Gortmaker
This file does not contain any modular related function calls. So get rid of module.h since it drags in a lot of other headers and adds to the preprocessing load. It does export some symbols though, so we'll need to ensure it has export.h present instead. Cc: Herbert Xu Cc: "David S. Miller" C

[PATCH] crypto: qat - ring returning retry even though ring has BW

2015-12-09 Thread Tadeusz Struk
From: Harvijay Saini When many threads submit multiple requests they get blocked until all responses are processed, which prevents them from submitting more requests even though there is space on the rings. To fix this we need to decrement the inflight counter early to in the callback. Signed-of

[cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation

2015-12-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2 commit: 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6 [53/54] crypto: rsa - RSA padding algorithm config: s390-allmodconfig (attached as .config) reproduce:

Re: [PATCH RFC 07/11] crypto: caam: check and use dma_map_sg() return code

2015-12-09 Thread Russell King - ARM Linux
On Wed, Dec 09, 2015 at 05:20:45PM +0200, Horia Geantă wrote: > On 12/7/2015 9:12 PM, Russell King wrote: > > Strictly, dma_map_sg() may coalesce SG entries, but in practise on iMX > > hardware, this will never happen. However, dma_map_sg() can fail, and > > we completely fail to check its return

Re: [PATCH RFC 06/11] crypto: caam: ensure that we clean up after an error

2015-12-09 Thread Russell King - ARM Linux
On Wed, Dec 09, 2015 at 05:08:41PM +0200, Horia Geantă wrote: > On 12/7/2015 9:12 PM, Russell King wrote: > > Ensure that we clean up allocations and DMA mappings after encountering > > an error rather than just giving up and leaking memory and resources. > > > > Signed-off-by: Russell King > >

[cryptodev:master 51/54] drivers/crypto/qat/qat_c62xvf/adf_drv.c:116:57: error: 'struct pci_dev' has no member named 'physfn'

2015-12-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2 commit: 3771df3cff7536da19cba2b4755ad628dc4bf371 [51/54] crypto: qat - add support for c62xvf accel type config: i386-randconfig-x004-12092241 (attached as .co

Re: [PATCH RFC 00/13] Further iMX CAAM updates

2015-12-09 Thread Russell King - ARM Linux
On Wed, Dec 09, 2015 at 05:06:03PM +0200, Horia Geantă wrote: > On 12/7/2015 9:11 PM, Russell King - ARM Linux wrote: > > Here are further imx-caam updates that I've had since before the > > previous merge window. Please review and (I guess) if Freescale > > folk can provide acks etc that would be

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

2015-12-09 Thread David Miller
From: Herbert Xu Date: Wed, 9 Dec 2015 16:44:58 +0800 > On Wed, Dec 09, 2015 at 02:13:32PM +0530, Rameshwar Sahu wrote: >> >> Yes, we are not upstream in-kernel users right now, but later client >> ma upstream there patches. > > Well I'd prefer to not take any crypto drivers that don't have > in

Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

2015-12-09 Thread Tim Chen
On Wed, 2015-12-09 at 10:52 +0800, Herbert Xu wrote: > On Wed, Dec 02, 2015 at 12:02:45PM -0800, Tim Chen wrote: > > > > +/* > > + * CRYPTO_ALG_ASYNC flag is passed to indicate we have an ablk > > + * scatter-gather walk. > > + */ > > + > > +static struct crypto_alg aes_cbc_mb_alg = { > > + .cra_

Re: [PATCH RFC 10/11] crypto: caam: add ahash_edesc_add_src()

2015-12-09 Thread Horia Geantă
On 12/7/2015 9:12 PM, Russell King wrote: > Add a helper to map the source scatterlist into the descriptor. > > Signed-off-by: Russell King After appending 07/11 ("crypto: caam: check and use dma_map_sg() return code") as follows: diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caa

Re: [PATCH RFC 07/11] crypto: caam: check and use dma_map_sg() return code

2015-12-09 Thread Horia Geantă
On 12/7/2015 9:12 PM, Russell King wrote: > Strictly, dma_map_sg() may coalesce SG entries, but in practise on iMX > hardware, this will never happen. However, dma_map_sg() can fail, and > we completely fail to check its return value. So, fix this properly. > > Arrange the code to map the scatte

Re: [PATCH RFC 00/13] Further iMX CAAM updates

2015-12-09 Thread Horia Geantă
On 12/7/2015 9:11 PM, Russell King - ARM Linux wrote: > Here are further imx-caam updates that I've had since before the > previous merge window. Please review and (I guess) if Freescale > folk can provide acks etc that would be nice. Thanks. Thanks Russell. Note that the patch set does not app

Re: [PATCH RFC 06/11] crypto: caam: ensure that we clean up after an error

2015-12-09 Thread Horia Geantă
On 12/7/2015 9:12 PM, Russell King wrote: > Ensure that we clean up allocations and DMA mappings after encountering > an error rather than just giving up and leaking memory and resources. > > Signed-off-by: Russell King I guess the error cleanup code should be grouped under an "err" label, inste

Re: [PATCH 1/2] blkcipher: Copy iv from desc even for 0-len walks

2015-12-09 Thread Herbert Xu
On Sun, Dec 06, 2015 at 02:51:37AM +0100, Jason A. Donenfeld wrote: > Some ciphers actually support encrypting zero length plaintexts. For > example, many AEAD modes support this. The resulting ciphertext for > those winds up being only the authentication tag, which is a result of > the key, the iv

Re: [PATCH 2/2] chacha20poly1305: Skip encryption/decryption for 0-len

2015-12-09 Thread Herbert Xu
On Sun, Dec 06, 2015 at 02:51:38AM +0100, Jason A. Donenfeld wrote: > If the length of the plaintext is zero, there's no need to waste cycles > on encryption and decryption. Using the chacha20poly1305 construction > for zero-length plaintexts is a common way of using a shared encryption > key for A

Re: [PATCH 0/7] Add support for qat_c3xxx and qat_c62x devices

2015-12-09 Thread Herbert Xu
On Fri, Dec 04, 2015 at 04:56:12PM -0800, Tadeusz Struk wrote: > The following series adds support for the new > qat_c3xxx and qat_c62x acceleration devices. > > --- > Pingchao Yang (1): > crypto: qat - add support for new devices to FW loader > > Tadeusz Struk (6): > crypto: qat - ad

Re: [PATCH] crypto: fix kernel-doc warnings in crypto/aead.h

2015-12-09 Thread Herbert Xu
On Thu, Dec 03, 2015 at 12:00:41PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix 21 occurrences of this kernel-doc warning in : > > ..//include/crypto/aead.h:149: warning: No description found for parameter > 'base' > > Signed-off-by: Randy Dunlap Patch applied. Thanks. -- Email:

Re: [RFC PATCH V2] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

2015-12-09 Thread LABBE Corentin
Hello I have some comments below. On Wed, Dec 09, 2015 at 06:16:42PM +0800, Zain Wang wrote: > Add md5 sha1 sha256 support for crypto engine in rk3288. > This patch can't support multiple updatings because of limited of IC, > as result, it can't support import and export too. > > Signed-off-by:

[RFC PATCH V2] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

2015-12-09 Thread Zain Wang
Add md5 sha1 sha256 support for crypto engine in rk3288. This patch can't support multiple updatings because of limited of IC, as result, it can't support import and export too. Signed-off-by: Zain Wang --- Changes in V2: - add some comments to code. - fix some issues about zero message process.

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

2015-12-09 Thread Herbert Xu
On Wed, Dec 09, 2015 at 02:13:32PM +0530, Rameshwar Sahu wrote: > > Yes, we are not upstream in-kernel users right now, but later client > ma upstream there patches. Well I'd prefer to not take any crypto drivers that don't have in-kernel users. Cheers, -- Email: Herbert Xu Home Page: http://go

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

2015-12-09 Thread Rameshwar Sahu
On Wed, Dec 9, 2015 at 1:57 PM, Herbert Xu wrote: > On Wed, Dec 09, 2015 at 01:55:55PM +0530, Rameshwar Sahu wrote: >> >> Any comments on above patch ?? > > My concern that there aren't going to be any in-kernel users remains. Yes, we are not upstream in-kernel users right now, but later client ma

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

2015-12-09 Thread Herbert Xu
On Wed, Dec 09, 2015 at 01:55:55PM +0530, Rameshwar Sahu wrote: > > Any comments on above patch ?? My concern that there aren't going to be any in-kernel users remains. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubk

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

2015-12-09 Thread Rameshwar Sahu
Hi, On Mon, Nov 16, 2015 at 2:42 PM, wrote: > From: Rameshwar Prasad Sahu > > This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver > and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC > has > DMA engine capable of performing CRC32C computation