Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-24 Thread Steffen Klassert
On Fri, Jul 24, 2009 at 03:23:11PM +0800, Herbert Xu wrote: Ah, that makes sense. I've done the prehash patch, let me know if this works. Yes, it works. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-23 Thread Steffen Klassert
On Tue, Jul 21, 2009 at 09:07:25PM +0800, Herbert Xu wrote: On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: I just noticed that your shash version of hmac keeps the paded keys on the transform. I assumed the hashing to be reentrant, so I removed the locks arround the hash

Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-22 Thread Steffen Klassert
On Wed, Jul 22, 2009 at 03:02:59PM +0800, Herbert Xu wrote: On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote: + err = crypto_ahash_finup(ahreq); + if (err == -EINPROGRESS) + return; This is redundant. All completion functions must expect to be called

Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-22 Thread Herbert Xu
On Wed, Jul 22, 2009 at 09:32:11AM +0200, Steffen Klassert wrote: On Wed, Jul 22, 2009 at 03:02:59PM +0800, Herbert Xu wrote: On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote: + err = crypto_ahash_finup(ahreq); + if (err == -EINPROGRESS) + return; This

[PATCH v2] crypto: authenc - convert to ahash

2009-07-21 Thread Steffen Klassert
This patch converts authenc to the new ahash interface. Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- crypto/authenc.c | 371 -- 1 files changed, 302 insertions(+), 69 deletions(-) diff --git a/crypto/authenc.c

Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-21 Thread Herbert Xu
On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: I just noticed that your shash version of hmac keeps the paded keys on the transform. I assumed the hashing to be reentrant, so I removed the locks arround the hash functions here. The padded keys are in the transform because

Re: [PATCH v2] crypto: authenc - convert to ahash

2009-07-21 Thread Steffen Klassert
On Tue, Jul 21, 2009 at 09:07:25PM +0800, Herbert Xu wrote: On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: I just noticed that your shash version of hmac keeps the paded keys on the transform. I assumed the hashing to be reentrant, so I removed the locks arround the hash