Re: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-14 Thread Herbert Xu
On Tue, Jan 13, 2015 at 06:19:35PM +, McCaffrey, Timothy M wrote: -Original Message- From: Jarod Wilson [mailto:ja...@redhat.com] Sent: Tuesday, January 13, 2015 1:17 PM On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: These patches fix the RFC4106

RE: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-13 Thread McCaffrey, Timothy M
-Original Message- From: Jarod Wilson [mailto:ja...@redhat.com] Sent: Tuesday, January 13, 2015 1:17 PM On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: These patches fix the RFC4106 implementation in the aesni-intel module so it supports 192 256 bit keys.

Re: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-13 Thread Jarod Wilson
On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: These patches fix the RFC4106 implementation in the aesni-intel module so it supports 192 256 bit keys. Since the AVX support that was added to this module also only supports 128 bit keys, and this patch only affects the

Re: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-13 Thread Herbert Xu
On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: I created this diff from a git clone of crypto-2.6.git. Sorry, but your patch doesn't apply against either crypto or cryptodev. I get $ git apply ~/p /home/gondolin/herbert/p:48: trailing whitespace. * movaps (move aligned

RE: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-12 Thread McCaffrey, Timothy M
On Monday, January 12, 2015 1:07 AM, Herbert Xu wrote: On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: This patch has been tested with Sandy Bridge and Haswell processors. With 128 bit keys and input buffers 512 bytes a slight performance degradation was noticed (~1%).

Re: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-12 Thread Tim Chen
On Mon, 2015-01-12 at 17:06 +1100, Herbert Xu wrote: On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: This patch has been tested with Sandy Bridge and Haswell processors. With 128 bit keys and input buffers 512 bytes a slight performance degradation was noticed

Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-11 Thread Timothy McCaffrey
These patches fix the RFC4106 implementation in the aesni-intel module so it supports 192 256 bit keys. Since the AVX support that was added to this module also only supports 128 bit keys, and this patch only affects the SSE implementation, changes were also made to use the SSE version if key

Re: Crypto: Add support for 192 256 bit keys to AESNI RFC4106 - resubmission

2015-01-11 Thread Herbert Xu
On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: This patch has been tested with Sandy Bridge and Haswell processors. With 128 bit keys and input buffers 512 bytes a slight performance degradation was noticed (~1%). For input buffers of less than 512 bytes there was no