Re: Is a crypto_ahash_init required before invoking crypto_ahash_import?

2016-02-26 Thread Herbert Xu
On Thu, Feb 25, 2016 at 04:26:54PM -0600, Tom Lendacky wrote: > > Thanks for the clarification Herbert. I'll send in a patch to perform > the memset during the import. I know it's late in the cycle, but will > you be able to apply it to the current cryptodev-2.6 tree which contains > the ccp

Re: Is a crypto_ahash_init required before invoking crypto_ahash_import?

2016-02-25 Thread Tom Lendacky
On 02/25/2016 04:11 PM, Herbert Xu wrote: > On Thu, Feb 25, 2016 at 03:56:31PM -0600, Tom Lendacky wrote: >> >> I can fix this in the driver by doing a memset to zero of the request >> context area during the import. But I guess I'm also wondering if there >> is an expectation/requirement that

Re: Is a crypto_ahash_init required before invoking crypto_ahash_import?

2016-02-25 Thread Herbert Xu
On Thu, Feb 25, 2016 at 03:56:31PM -0600, Tom Lendacky wrote: > > I can fix this in the driver by doing a memset to zero of the request > context area during the import. But I guess I'm also wondering if there > is an expectation/requirement that crypto_ahash_init() be called before > doing an

Is a crypto_ahash_init required before invoking crypto_ahash_import?

2016-02-25 Thread Tom Lendacky
I'm seeing an issue on one system that I wasn't seeing on another system. It turns out that the testmgr sha testing exports an ahash request context, allocates a new ahash request context and then imports into that new ahash request context. Since crypto_ahash_init() is not performed the driver