Re: [PATCH 8/9] drm: remove no longer needed drm-get-put coccinelle script

2018-11-18 Thread Julia Lawall
On Thu, 15 Nov 2018, Fernando Ramos wrote: > The coccinelle script was used to rename some (deprecated) functions > which no longer exist now. > > Signed-off-by: Fernando Ramos Acked-by: Julia Lawall > --- > scripts/coccinelle/api/drm-get-put.cocci | 78

Re: [PATCH] rtc: sysfs: move sysfs & ioctl interface to Documentation/ABI

2018-01-01 Thread Julia Lawall
On Mon, 1 Jan 2018, Aishwarya Pant wrote: > Right now, the decription of the rtc and sysfs interfaces is in > Documentation/rtc.txt. Since these are a part of the ABI, they should be > in Documentation/ABI along with the rest. > > Signed-off-by: Aishwarya Pant > --- > Let me know if the contact

Re: [PATCH] hwmon: (sht3x) move sysfs documentation to Documentation/ABI (fwd)

2017-12-23 Thread Julia Lawall
In the end, the change was not very popular... julia -- Forwarded message -- Date: Fri, 22 Dec 2017 10:10:28 -0800 From: Guenter Roeck To: Aishwarya Pant Cc: Jean Delvare , linux-hw...@vger.kernel.org, linux-ker...@vger.kernel.org, David Frey , Pascal Sachs , julia.law..

Re: [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

2017-12-16 Thread Julia Lawall
> diff --git a/Documentation/dev-tools/runchecks.rst > b/Documentation/dev-tools/runchecks.rst > new file mode 100644 > index 000..b25b3de > --- /dev/null > +++ b/Documentation/dev-tools/runchecks.rst > @@ -0,0 +1,215 @@ > +.. Copyright 2017 Knut Omang > + > +Makefile support for running chec

Re: device attribute documentation

2017-12-14 Thread Julia Lawall
On Thu, 14 Dec 2017, Jonathan Corbet wrote: > On Thu, 14 Dec 2017 15:30:13 +0100 (CET) > Julia Lawall wrote: > > [CC += Greg in case he disagrees] > > > My intern, Aishwarya Pant, is looking into how to improve the > > documentation of device attributes. She col

device attribute documentation

2017-12-14 Thread Julia Lawall
Hello, My intern, Aishwarya Pant, is looking into how to improve the documentation of device attributes. She collected a list of attirbutes that are not represented anywhere under Documentation/ABI, but soeof these seem to be represented elsewhere, for examples: Documentation/hwmon/sht3x: sysfs

Re: [PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

2017-11-13 Thread Julia Lawall
On Tue, 14 Nov 2017, Masahiro Yamada wrote: > Hi Julia, Jon, > > 2017-11-14 1:50 GMT+09:00 Julia Lawall : > > The wiki is no longer available. > > > > Signed-off-by: Julia Lawall > > > > > Jon sent the doc pull request yesterday. > > I will p

[PATCH] docs: dev-tools: coccinelle: delete out of date wiki reference

2017-11-13 Thread Julia Lawall
The wiki is no longer available. Signed-off-by: Julia Lawall --- diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst index 37e474f..94f41c2 100644 --- a/Documentation/dev-tools/coccinelle.rst +++ b/Documentation/dev-tools/coccinelle.rst @@ -33,9 +33,6

[PATCH] docs: dev-tools: correct Coccinelle version number

2017-10-15 Thread Julia Lawall
There is no Coccinelle version 1.2. 1.0.2 must be what was intended. Signed-off-by: Julia Lawall --- Documentation/dev-tools/coccinelle.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst

[PATCH] ipmi: bt-i2c: fix call_kern.cocci warnings

2017-08-05 Thread Julia Lawall
endan Higgins Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/ipmi-bt-i2c-added-IPMI-Block-Transfer-over-I2C/20170806-034713 ipmi_bmc_bt_i2c.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/

kerneldoc

2017-03-26 Thread Julia Lawall
Kerneldoc seems to be written sometimes kerneldoc and sometimes kernel-doc. Which is preferred? Having two spellings makes it hard to use grep to find out what are the conventions for writing kernel documentation. julia -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in t

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Julia Lawall
On Wed, 15 Mar 2017, Alison Schofield wrote: > On Wed, Mar 15, 2017 at 09:07:56PM +0100, Julia Lawall wrote: > > > > > > On Wed, 15 Mar 2017, Tamara Diaconita wrote: > > > > > Fix typos in sync_file.txt to make documentation grammatically correct. >

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Julia Lawall
On Wed, 15 Mar 2017, Tamara Diaconita wrote: > Fix typos in sync_file.txt to make documentation grammatically correct. It's a bit picky, but you are not making the text grammatically correct, You are fixing spelling mistakes, but not changing any aspect of the grammar. julia > > Signed-off-by

Re: [Outreachy kernel] [PATCH v2] Documentation: admin-guide: Fix typos

2017-03-14 Thread Julia Lawall
problem in other files, and thus find more opportunities for patches. julia > > marți, 14 martie 2017, 11:05:55 UTC+2, Julia Lawall a scris: > > > On Tue, 14 Mar 2017, Tamara Diaconita wrote: > > > Fix typos in admin-guide directory. > > Make docu

Re: [Outreachy kernel] [PATCH v2] Documentation: admin-guide: Fix typos

2017-03-14 Thread Julia Lawall
On Tue, 14 Mar 2017, Tamara Diaconita wrote: > Fix typos in admin-guide directory. > Make documentation clear and grammatically correct. You may want to collect the words in which you find problems, and see if other files have the same problems. julia > > Signed-off-by: Tamara Diaconita > --

Re: [Outreachy kernel] [PATCH] Documentation: x86: Fix typos

2017-03-14 Thread Julia Lawall
On Tue, 14 Mar 2017, Tamara Diaconita wrote: > Fix typos in x86 directory. > Make documentation clear and grammatically correct. > > Signed-off-by: Tamara Diaconita > --- > Documentation/x86/boot.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/x86

Re: [PATCH v4 1/1] DM: inplace compressed DM target (fwd)

2017-02-13 Thread Julia Lawall
On line 1759, since ret is unsigned it will not be less than 0. julia -- Forwarded message -- Date: Tue, 14 Feb 2017 09:00:39 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 1/1] DM: inplace compressed DM target CC: kbuild-...@01.org In

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-23 Thread Julia Lawall
On Sun, 22 Jan 2017, Joe Perches wrote: > On Sun, 2017-01-22 at 22:43 -0800, Joe Perches wrote: > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * de

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Julia Lawall
hwmon to convert in applesmc.c > > > > Perhaps a coccinelle script? > > > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * dev be made an arbitrary id

[PATCH] drivers: hwmon: fix platform_no_drv_owner.cocci warnings

2017-01-09 Thread Julia Lawall
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Jaghathiswari Rankappagounder Natarajan Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- aspeed-pwm-tacho.c |1 - 1 file changed, 1 deletion

[PATCH] drivers: hwmon: fix ptr_ret.cocci warnings

2017-01-09 Thread Julia Lawall
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Jaghathiswari Rankappagounder Natarajan Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- aspeed-pwm-tacho.c |5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH] drivers: hwmon: fix device_node_continue.cocci warnings

2017-01-09 Thread Julia Lawall
Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci CC: Jaghathiswari Rankappagounder Natarajan Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- The patch

[PATCH] drivers: hwmon: fix semicolon.cocci warnings

2017-01-09 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Jaghathiswari Rankappagounder Natarajan Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- url: https://github.com/0day-ci/linux/commits/Jaghathiswari-Rankappagounder-Natar ajan/Support-for-ASPEED

Re: [PATCH] doc: add note on usleep_range range

2016-12-13 Thread Julia Lawall
On Tue, 13 Dec 2016, Nicholas Mc Guire wrote: > On Tue, Dec 13, 2016 at 11:10:50AM +0200, Jani Nikula wrote: > > On Tue, 13 Dec 2016, Nicholas Mc Guire wrote: > > > useleep_range() with a delta of 0 makes no sense and only prevents the > > > timer subsystem from optimizing interrupts. As any us

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

2016-10-07 Thread Julia Lawall
t; in August 2016. > > Fixes: 4b9033a33494ec9154d63e706e9e47f7eb3fd59e ("docs: sphinxify > coccinelle.txt and add it to dev-tools") > Signed-off-by: Markus Elfring Acked-by: Julia Lawall > --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation)

2016-10-05 Thread Julia Lawall
On Wed, 5 Oct 2016, Jani Nikula wrote: > On Wed, 05 Oct 2016, Daniel Vetter wrote: > > Jani Nikula has a patch with a scrip to make the one kernel-doc parser > > into a lint/checker pass over the entire kernel. I think that'd would > > be more robust instead of trying to approximate the real ke

kernel-doc

2016-10-03 Thread Julia Lawall
Hello, I have the inpression that not all comments on specific functions are using the following notation: function_name() - Brief description of function. They are good about using the -, but some don't have the () after the function name and others (perhaps only one subsystem) have the functio

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next

2016-09-22 Thread Julia Lawall
> > The main intent of checkpatch these days appears to be providing an easy > > way of thoughtless inflation of commit counts, everything else be damned. > > Make-work, in other words. > > Yes, I've noticed the trend too :-( But that's a problem with the > people using the tool, mostly, not with t

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

2016-09-19 Thread Julia Lawall
On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > > On Mon, 19 Sep 2016, Joe Perches wrote: > > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > > IMO what we need is to go through all rules in CodingStyl

Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

2016-09-19 Thread Julia Lawall
On Mon, 19 Sep 2016, Joe Perches wrote: > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > IMO what we need is to go through all rules in CodingStyle and if for > > some rule there is no overwhelming majority in the core kernel, well, > > the list has grown way too large and could use massi

Re: [PATCH 02/10] docs: sphinxify coccinelle.txt and add it to dev-tools

2016-08-08 Thread Julia Lawall
Acked-by: Julia Lawall On Mon, 8 Aug 2016, Jonathan Corbet wrote: > No textual changes have been made, but the formatting has obviously been > tweaked. > > Cc: Michal Marek > Cc: Gilles Muller > Cc: Nicolas Palix > Cc: Julia Lawall > Signed