[PATCH] x86, boot: Move z_extract_offset calculation to header.S

2015-03-12 Thread Yinghai Lu
At that point, we have exact decompressor size, so we don't need to guess that size in mkpiggy.c We use 8 pages less in final init_size with this patch. input: [0x13f2b33b4-0x13fe44346], output: [0x13e00-0x13fe61fff], heap: [0x13fe4f080-0x13fe5707f] before patch input: [0x13f2bb3b4-0x1

Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-12 Thread Matt Fleming
On Tue, 10 Mar, at 08:51:59AM, Andy Lutomirski wrote: > > I'm not 100% happy with write(2) (which is all we have in sysfs) for > two reasons: > > 1. If we write a file name, eww. That's more complicated, requires > temporary files, has annoying mount namespace issues, etc. > > 2. If we write th

Re: efivarfs and writev() support

2015-03-12 Thread Al Viro
On Thu, Mar 12, 2015 at 07:58:35AM -0700, Marcel Holtmann wrote: > I do not know about the specific semantics of efivarfs and frankly I have not > tried every single combination. However it sounds to me that currently it > requires that the whole file content is provided with a single write(). I

Re: efivarfs and writev() support

2015-03-12 Thread Marcel Holtmann
Hi Al, it seems that efivarfs only supports readv(), but when it comes to writev(), I am getting an error. Is there any reason to not support vectored write on this filesystem? Especially with the uint32 header for each file, I think it would make perfect sense to support it. >

Re: efivarfs and writev() support

2015-03-12 Thread Marcel Holtmann
Hi Matt, >> it seems that efivarfs only supports readv(), but when it comes to >> writev(), I am getting an error. Is there any reason to not support >> vectored write on this filesystem? Especially with the uint32 header >> for each file, I think it would make perfect sense to support it. > > Wh

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-12 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: >> In arch/x86/boot/header.S, we already use VO and ZO. >> So please keep on using them, and don't introduce "kernel proper" etc. > > So you're suggesting commit messages should us

Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-12 Thread Andy Lutomirski
On Tue, Mar 10, 2015 at 10:26 AM, Peter Jones wrote: > On Tue, Mar 10, 2015 at 08:51:59AM -0700, Andy Lutomirski wrote: >> On Tue, Mar 10, 2015 at 8:40 AM, Peter Jones wrote: >> > >> >> >> So, for the sysfs interface, let's not allow loading from /lib. Let's >> >> >> not require a userland tool.

Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-12 Thread Andy Lutomirski
On Tue, Mar 10, 2015 at 8:40 AM, Peter Jones wrote: > >> >> So, for the sysfs interface, let's not allow loading from /lib. Let's >> >> not require a userland tool. Let's just do, >> >> >> >> # echo /path/to/my/awesome/capsule.bin > /sys/../capsule >> > >> >> >> >> and be done with it. >> >> >>