Re: [PATCH 1/2 v8] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED'

2018-12-11 Thread lijiang
在 2018年12月05日 05:33, Lendacky, Thomas 写道: > On 11/29/2018 09:37 PM, Dave Young wrote: >> + more people >> >> On 11/29/18 at 04:09pm, Lianbo Jiang wrote: >>> When doing kexec_file_load, the first kernel needs to pass the e820 >>> reserved ranges to the second kernel. But kernel can not exactly >>> m

Re: [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > On secure boot enabled systems, the bootloader verifies the kernel > image and possibly the initramfs signatures based on a set of keys. A > soft reboot(kexec) of the system, with the same kernel image and > initramfs, requires access to the original keys to

Re: [PATCH v2 6/7] efi: Allow the "db" UEFI variable to be suppressed

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > From: Josh Boyer > > If a user tells shim to not use the certs/hashes in the UEFI db variable > for verification purposes, shim will set a UEFI variable called > MokIgnoreDB. Have the uefi import code look for this and ignore the db > variable if it is fou

Re: [PATCH v2 5/7] efi: Import certificates from UEFI Secure Boot

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > +/* > + * Blacklist an X509 TBS hash. > + */ > +static __init void uefi_blacklist_x509_tbs(const char *source, > +const void *data, size_t len) > +{ > + char *hash, *p; > + > + hash = kmalloc(4 + len * 2 + 1, G

Re: [PATCH v2 3/7] efi: Add EFI signature data types

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > From: Dave Howells > > Add the data types that are used for containing hashes, keys and > certificates for cryptographic verification along with their corresponding > type GUIDs. > > Signed-off-by: David Howells > Acked-by: Nayna Jain > Acked-by: Serge

Re: [PATCH v2 2/7] integrity: Load certs to the platform keyring

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > The patch refactors integrity_load_x509(), making it a wrapper for a new > function named integrity_add_key(). This patch also defines a new > function named integrity_load_cert() for loading the platform keys. > > Signed-off-by: Nayna Jain > Reviewed-by:

Re: [PATCH v2 1/7] integrity: Define a trusted platform keyring

2018-12-11 Thread James Morris
On Sun, 9 Dec 2018, Nayna Jain wrote: > On secure boot enabled systems, a verified kernel may need to kexec > additional kernels. For example, it may be used as a bootloader needing > to kexec a target kernel or it may need to kexec a crashdump kernel. In > such cases, it may want to verify the si

[PATCH 4.19 104/118] x86/efi: Allocate e820 buffer before calling efi_exit_boot_service

2018-12-11 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Eric Snowberg commit b84a64fad40637b1c9fa4f4dbf847a23e29e672b upstream. The following commit: d64934019f6c ("x86/efi: Use efi_exit_boot_services()") introduced a regression on systems with

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Leif Lindholm
On Tue, Dec 11, 2018 at 12:55:39PM +, Pankaj Bansal wrote: > I am not able to understand the reservation about this patch. The reservation is that from an outside perspective, this patch set gives the impression that somewhere deep down the line, a fundamental misunderstanding exists. This im

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 6:31 PM > To: Pankaj Bansal > Cc: Bhupesh Sharma ; Mark Rutland > ; Leif Lindholm ; Grant > Likely ; Varun Sethi ; Udit Kumar > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 13:55, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 6:18 PM > > To: Pankaj Bansal > > Cc: Bhupesh Sharma ; Mark Rutland > > ; Leif Lindholm ; Grant > > Likely ; Var

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 6:18 PM > To: Pankaj Bansal > Cc: Bhupesh Sharma ; Mark Rutland > ; Leif Lindholm ; Grant > Likely ; Varun Sethi ; Udit Kumar > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 13:44, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 6:02 PM > > To: Pankaj Bansal > > Cc: Bhupesh Sharma ; Mark Rutland > > ; Leif Lindholm ; Grant > > Likely ; Var

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 6:02 PM > To: Pankaj Bansal > Cc: Bhupesh Sharma ; Mark Rutland > ; Leif Lindholm ; Grant > Likely ; Varun Sethi ; Udit Kumar > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 13:29, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 5:55 PM > > To: Pankaj Bansal > > Cc: Bhupesh Sharma ; Mark Rutland > > ; Leif Lindholm ; Grant > > Likely ; Var

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 5:55 PM > To: Pankaj Bansal > Cc: Bhupesh Sharma ; Mark Rutland > ; Leif Lindholm ; Grant > Likely ; Varun Sethi ; Udit Kumar > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 13:22, Pankaj Bansal wrote: > > -Original Message- > > From: Bhupesh Sharma [mailto:bhsha...@redhat.com] > > Sent: Tuesday, December 11, 2018 4:25 PM > > To: Pankaj Bansal > > Cc: Ard Biesheuvel ; Mark Rutland > > ; Leif Lindholm ; Grant > > Likely ; Varun Sethi ; U

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Bhupesh Sharma [mailto:bhsha...@redhat.com] > Sent: Tuesday, December 11, 2018 4:25 PM > To: Pankaj Bansal > Cc: Ard Biesheuvel ; Mark Rutland > ; Leif Lindholm ; Grant > Likely ; Varun Sethi ; Udit Kumar > ; linux-efi@vger.kernel.org > Subject: Re: [PATCH v2

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Bhupesh Sharma
Hi Pankaj, On Tue, Dec 11, 2018 at 3:54 PM Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 3:45 PM > > To: Pankaj Bansal > > Cc: Mark Rutland ; Leif Lindholm > > ; Grant Likely ; Varun Seth

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 3:45 PM > To: Pankaj Bansal > Cc: Mark Rutland ; Leif Lindholm > ; Grant Likely ; Varun Sethi > ; Udit Kumar ; Bhupesh Sharma > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 11:13, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 3:41 PM > > To: Pankaj Bansal > > Cc: Mark Rutland ; Leif Lindholm > > ; Grant Likely ; Varun Sethi > > ; Udit K

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 3:41 PM > To: Pankaj Bansal > Cc: Mark Rutland ; Leif Lindholm > ; Grant Likely ; Varun Sethi > ; Udit Kumar ; Bhupesh Sharma > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 11:08, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 3:32 PM > > To: Pankaj Bansal > > Subject: Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in > > con

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 3:32 PM > To: Pankaj Bansal > Subject: Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in > configuration table > > On Tue, 11 Dec 2018 at 10:47, Pankaj Bansal w

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 10:27, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 2:55 PM > > To: Pankaj Bansal > > Cc: Mark Rutland ; Leif Lindholm > > ; Grant Likely ; Varun Sethi > > ; Udit K

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 2:55 PM > To: Pankaj Bansal > Cc: Mark Rutland ; Leif Lindholm > ; Grant Likely ; Varun Sethi > ; Udit Kumar ; Bhupesh Sharma > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 10:23, Pankaj Bansal wrote: > > > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, December 11, 2018 2:48 PM > > To: Pankaj Bansal > > Cc: Mark Rutland ; Leif Lindholm > > ; Grant Likely ; Varun Sethi > > ; Udit K

RE: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 2:48 PM > To: Pankaj Bansal > Cc: Mark Rutland ; Leif Lindholm > ; Grant Likely ; Varun Sethi > ; Udit Kumar ; Bhupesh Sharma > ; linux-efi > Subject: Re: [PATCH v2 2/2] dri

Re: [PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 10:04, Pankaj Bansal wrote: > > Bootloader may need to fixup the device tree before OS can use it. > > Therefore, install fdt used by OS in configuration tables and associate it > with device tree guid. > > UEFI/DXE drivers can fixup this device tree in their respective > Ex

[PATCH v2 1/2] drivers: firmware: efi: change sys_table to sys_table_arg

2018-12-11 Thread Pankaj Bansal
efi_call_early(f, ...) macro expands to sys_table_arg->boottime->f(__VA_ARGS__). Therefore, change sys_table to sys_table_arg so that efi_call_early macro can be used. Cc: Ard Biesheuvel Cc: linux-efi@vger.kernel.org Signed-off-by: Pankaj Bansal --- Notes: V2: No change drivers/firmwa

[PATCH v2 0/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
This patch series is the modification of patches that i had sent a while back: https://www.spinics.net/lists/linux-efi/msg13701.html The main reservation about these changes was that these patches made the fdt supplied by "dtb=" kernel command line parameter available to boot firmware. Now, for bo

[PATCH v2 2/2] drivers: firmware: efi: install new fdt in configuration table

2018-12-11 Thread Pankaj Bansal
Bootloader may need to fixup the device tree before OS can use it. Therefore, install fdt used by OS in configuration tables and associate it with device tree guid. UEFI/DXE drivers can fixup this device tree in their respective ExitBootServices events. Cc: Ard Biesheuvel Cc: linux-efi@vger.ker