Re: [2.6.24 patch] let EXT4DEV_FS depend on BROKEN

2008-01-03 Thread Valdis . Kletnieks
On Wed, 02 Jan 2008 13:51:32 PST, Eric Anopolsky said: > their own kernels in the first place. IMHO, it's reasonable to expect > the small minority of Linux users who want to compile their own kernels > to learn that "EXPERIMENTAL" means something. And what, exactly, does it mean, given that ther

Re: [PATCH] UPDATED2: types fixup for mballoc

2008-01-03 Thread Eric Sandeen
Andreas Dilger wrote: > On Jan 03, 2008 14:10 -0600, Eric Sandeen wrote: >> @@ -1732,17 +1735,19 @@ static void ext4_mb_scan_aligned(struct >> +/* find first stripe-aligned block in group */ >> +a = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb) >> + le32_to_cpu(sbi->s_es->s_first

[PATCH] e2fsprogs: report minimal resize size when given size is too small

2008-01-03 Thread Josef Bacik
Hello, Ok this is the reworked patch which implements both of your suggestions. Whenever a size is passed to resize2fs that is too small for the fs the minimum size is spat out. Thanks much, Josef diff --git a/resize/main.c b/resize/main.c index 7c1d0c1..a9653ee 100644 --- a/resize/main.c +++

Re: [PATCH] UPDATED2: types fixup for mballoc

2008-01-03 Thread Andreas Dilger
On Jan 03, 2008 14:10 -0600, Eric Sandeen wrote: > @@ -1732,17 +1735,19 @@ static void ext4_mb_scan_aligned(struct > + /* find first stripe-aligned block in group */ > + a = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb) > + le32_to_cpu(sbi->s_es->s_first_data_block); > + a +

Re: [PATCH] e2fsprogs: add minimal resize size option

2008-01-03 Thread Eric Sandeen
Theodore Tso wrote: > On Wed, Jan 02, 2008 at 03:16:59PM -0500, Josef Bacik wrote: >> Hello, >> >> People wishing to make live usb disks and such are looking for a way >> to get the minimum resize size for an ext fs in blocks so that they >> can just resize their image to that size and do with it w

Re: [PATCH] e2fsprogs: add minimal resize size option

2008-01-03 Thread Josef Bacik
On Thu, Jan 03, 2008 at 12:21:01PM -0500, Theodore Tso wrote: > On Wed, Jan 02, 2008 at 03:16:59PM -0500, Josef Bacik wrote: > > Hello, > > > > People wishing to make live usb disks and such are looking for a way > > to get the minimum resize size for an ext fs in blocks so that they > > can just

[PATCH] UPDATED2: types fixup for mballoc

2008-01-03 Thread Eric Sandeen
3rd time's the charm I hope! - I ran into a potential overflow in ext4_mb_scan_aligned, and went looking for others in mballoc. This patch hits a few spots, compile-tested only at this point, comments welcome. This patch: changes fe_len to an int, I don't think we need it to be a

Re: [PATCH] UPDATED: types fixup for mballoc

2008-01-03 Thread Eric Sandeen
Andreas Dilger wrote: > On Jan 02, 2008 14:01 -0600, Eric Sandeen wrote: >> This patch: >> >> changes fe_len to an int, I don't think we need it to be a long, >> looking at how it's used (should it be a grpblk_t?) Also change >> anything assigned to return value of mb_find_extent, since it return

Re: [PATCH] UPDATED: types fixup for mballoc

2008-01-03 Thread Andreas Dilger
On Jan 02, 2008 14:01 -0600, Eric Sandeen wrote: > This patch: > > changes fe_len to an int, I don't think we need it to be a long, > looking at how it's used (should it be a grpblk_t?) Also change > anything assigned to return value of mb_find_extent, since it returns > fe_len. > > changes any

Re: [PATCH] e2fsprogs: add minimal resize size option

2008-01-03 Thread Theodore Tso
On Wed, Jan 02, 2008 at 03:16:59PM -0500, Josef Bacik wrote: > Hello, > > People wishing to make live usb disks and such are looking for a way > to get the minimum resize size for an ext fs in blocks so that they > can just resize their image to that size and do with it what they > will. This pat