Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Mon, 04 Jun 2007 16:01:45 -0700 Mingming Cao [EMAIL PROTECTED] wrote: On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote: On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Dave Kleikamp
On Tue, 2007-06-05 at 06:41 -0500, Jose R. Santos wrote: On Mon, 04 Jun 2007 16:01:45 -0700 Mingming Cao [EMAIL PROTECTED] wrote: On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote: On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Laurent Vivier
Dave Kleikamp wrote: On Tue, 2007-06-05 at 06:41 -0500, Jose R. Santos wrote: On Mon, 04 Jun 2007 16:01:45 -0700 Mingming Cao [EMAIL PROTECTED] wrote: On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote: On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: Set the journals

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 15:26:53 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Dave Kleikamp wrote: Jose is right. The endian conversion is unnecessary. Shaggy But by using le32_to_cpu(es-s_blocks_count_hi) you explicitly mark the variable as a little-endian. So if someone reads the

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Laurent Vivier
Jose R. Santos wrote: On Tue, 05 Jun 2007 15:26:53 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Dave Kleikamp wrote: Jose is right. The endian conversion is unnecessary. Shaggy But by using le32_to_cpu(es-s_blocks_count_hi) you explicitly mark the variable as a little-endian. So if

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 16:03:44 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Jose R. Santos wrote: Hi Laurent, In this particular case though, the value of s_blocks_count_hi should not be uses on its own. The correct way would be to use ext4_blocks_count() which already does the endian

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Laurent Vivier
Jose R. Santos wrote: On Tue, 05 Jun 2007 16:03:44 +0200 Laurent Vivier [EMAIL PROTECTED] wrote: Jose R. Santos wrote: Hi Laurent, In this particular case though, the value of s_blocks_count_hi should not be uses on its own. The correct way would be to use ext4_blocks_count() which

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-05 Thread Jose R. Santos
On Tue, 05 Jun 2007 10:46:43 -0700 Mingming Cao [EMAIL PROTECTED] wrote: The better choice to me is using ext4_blocks_count() to hide the details of the little endian. It's fine to use s_blocks_count_hi directly, just to make it clear, this is on-disk superblock data and better to do little

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] --- fs/ext4/super.c

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 16:01 -0700, Mingming Cao wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Mingming Cao [EMAIL PROTECTED] Signed-off-by: Jose R.