[f2fs-dev] [PATCH 2/2] fsck.f2fs: show parse errors neatly

2017-01-20 Thread Jaegeuk Kim
This patch is just to clean up. Cc: Sheng Yong Signed-off-by: Jaegeuk Kim --- fsck/fsck.h | 8 fsck/main.c | 140 2 files changed, 93 insertions(+), 55 deletions(-) diff --git a/fsck/fsck.h b/fsck/fsck.h index f21e199..5a6f018

[f2fs-dev] [PATCH 1/2] fsck.f2fs: support -p without argument

2017-01-20 Thread Jaegeuk Kim
This patch allows fsck run -p without argument. So we could use -p as -p, -p 0, -p 1. '-p' and '-p 0' have the same meaning as '-a'. '-p 1' check more meta data than '-a'. Reported-by: KARBOWSKI Piotr Signed-off-by: Sheng Yong Signed-off-by: Jaegeuk Kim --- fsck/main.c | 99 +++

Re: [f2fs-dev] [PATCH 2/2] fsck.f2fs: support -p without argument

2017-01-20 Thread Jaegeuk Kim
On 01/20, Sheng Yong wrote: > Hi Jaegeuk, > > On 1/20/2017 5:47 PM, Jaegeuk Kim wrote: > > On 01/20, Sheng Yong wrote: > [..] > >>> > >>> if (!strcmp("fsck.f2fs", prog)) { > >>> - const char *option_string = "ad:fp:t"; > >>> + const char *option_string = ":a:d:f:p:t:"; > >> I t

Re: [f2fs-dev] [PATCH 2/2] fsck.f2fs: support -p without argument

2017-01-20 Thread Sheng Yong
Hi Jaegeuk, On 1/20/2017 5:47 PM, Jaegeuk Kim wrote: > On 01/20, Sheng Yong wrote: [..] >>> >>> if (!strcmp("fsck.f2fs", prog)) { >>> - const char *option_string = "ad:fp:t"; >>> + const char *option_string = ":a:d:f:p:t:"; >> I think there is no need to modify options -a

Re: [f2fs-dev] f2fs corruption due to f2fs_gc crash.

2017-01-20 Thread Jaegeuk Kim
On 01/20, KARBOWSKI Piotr wrote: > Hi, > > On 01/20/2017 12:43 AM, Jaegeuk Kim wrote: > > If possible, could you share the fsck log whether it repaired something? > > That message is caused by wrong summary type, which is able to be fixed by > > fsck. > > Yes, of course. Please find the log below

Re: [f2fs-dev] [PATCH 2/2] fsck.f2fs: support -p without argument

2017-01-20 Thread Jaegeuk Kim
On 01/20, Sheng Yong wrote: > Hi Jaegeuk, > > On 1/20/2017 7:19 AM, Jaegeuk Kim wrote: > > Hi Sheng Yong, > > > > I tested this, but failed on -p with arguments. > Sorry, this may because double colon in optsting can only be used > at some Unix-like distributions :( > > > > Could you take a look

Re: [f2fs-dev] [PATCH 2/2] fsck.f2fs: support -p without argument

2017-01-20 Thread Sheng Yong
Hi Jaegeuk, On 1/20/2017 7:19 AM, Jaegeuk Kim wrote: > Hi Sheng Yong, > > I tested this, but failed on -p with arguments. Sorry, this may because double colon in optsting can only be used at some Unix-like distributions :( > > Could you take a look at this change? I tested this patch, it satisif