Re: [f2fs-dev] (2) [PATCH v2] f2fs: New victim selection for GC

2023-12-13 Thread Yonggil Song
> On 12/08, Yonggil Song wrote: > > Overview > > > > > > This patch introduces a new way to preference data sections when selecting > > GC victims. Migration of data blocks causes invalidation of node blocks. > > Therefore, in situations where GC is frequent, selecting data blocks as > >

[f2fs-dev] [PATCH 7/8] libfs: Don't support setting casefold operations during lookup

2023-12-13 Thread Gabriel Krisman Bertazi
No filesystems depend on it anymore, and it is generally a bad idea. Since all dentries should have the same set of dentry operations in case-insensitive filesystems, it should be configured through ->s_d_op. Signed-off-by: Gabriel Krisman Bertazi --- fs/libfs.c | 15 --- 1 file chan

[f2fs-dev] [PATCH 4/8] libfs: Expose generic_ci_dentry_ops outside of libfs

2023-12-13 Thread Gabriel Krisman Bertazi
In preparation to allow filesystems to set this through sb->s_d_op, expose the symbol directly to the filesystems. Signed-off-by: Gabriel Krisman Bertazi --- fs/libfs.c | 2 +- include/linux/fs.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/libfs.c b/fs/libfs.c

[f2fs-dev] [PATCH 1/8] dcache: Add helper to disable d_revalidate for a specific dentry

2023-12-13 Thread Gabriel Krisman Bertazi
Case-insensitive wants d_compare/d_hash for every dentry in the filesystem, while fscrypt needs d_revalidate only for DCACHE_NOKEY_NAME. This means we currently can't use sb->s_d_op to set case-insensitive hooks in fscrypt+case-insensitive filesystems without paying the cost to call d_revalidate fo

[f2fs-dev] [PATCH 8/8] fscrypt: Move d_revalidate configuration back into fscrypt

2023-12-13 Thread Gabriel Krisman Bertazi
This partially reverts commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), which moved this handler out of fscrypt and into the filesystems, in preparation to support casefold and fscrypt combinations. Now that we set casefolding operations through ->s_d_op, move this back into f

[f2fs-dev] [PATCH 2/8] fscrypt: Drop d_revalidate if key is available

2023-12-13 Thread Gabriel Krisman Bertazi
fscrypt dentries are always valid once the key is available. Since the key cannot be removed without evicting the dentry, we don't need to keep retrying to revalidate it. Signed-off-by: Gabriel Krisman Bertazi --- fs/crypto/fname.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[f2fs-dev] [PATCH 0/8] Revert setting casefolding dentry operations through s_d_op

2023-12-13 Thread Gabriel Krisman Bertazi
When case-insensitive and fscrypt were adapted to work together, we moved the code that sets the dentry operations for case-insensitive dentries(d_hash and d_compare) to happen from a helper inside ->lookup. This is because fscrypt wants to set d_revalidate only on some dentries, so it does it onl

[f2fs-dev] [PATCH 5/8] ext4: Set the case-insensitive dentry operations through ->s_d_op

2023-12-13 Thread Gabriel Krisman Bertazi
All dentries in a case-insensitive filesystem have the same set of dentry operations. Therefore, we should let VFS propagate them from sb->s_d_op d_alloc instead of setting at lookup time. This was already the case before commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but i

[f2fs-dev] [PATCH 3/8] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops

2023-12-13 Thread Gabriel Krisman Bertazi
In preparation to get case-insensitive dentry operations from sb->s_d_op again, use the same structure for case-insensitive filesystems with and without fscrypt. This means that on a casefolded filesystem without fscrypt, we end up having to call fscrypt_d_revalidate once per dentry, which does th

[f2fs-dev] [PATCH 6/8] f2fs: Set the case-insensitive dentry operations through ->s_d_op

2023-12-13 Thread Gabriel Krisman Bertazi
All dentries in a case-insensitive filesystem have the same set of dentry operations. Therefore, we should let VFS propagate them from sb->s_d_op d_alloc instead of setting at lookup time. This was already the case before commit bb9cd9106b22 ("fscrypt: Have filesystems handle their d_ops"), but i

Re: [f2fs-dev] [PATCH 3/3] fs: move fscrypt keyring destruction to after ->put_super

2023-12-13 Thread Neal Gompa
On Tue, Dec 12, 2023 at 11:01 PM Eric Biggers wrote: > > From: Josef Bacik > > btrfs has a variety of asynchronous things we do with inodes that can > potentially last until ->put_super, when we shut everything down and > clean up all of our async work. Due to this we need to move > fscrypt_dest

Re: [f2fs-dev] [PATCH 3/3] fs: move fscrypt keyring destruction to after ->put_super

2023-12-13 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb

2023-12-13 Thread Christoph Hellwig
On Tue, Dec 12, 2023 at 08:00:16PM -0800, Eric Biggers wrote: > From: Christoph Hellwig > > blkdev_put must not be called under sb->s_umount to avoid a lock order > reversal with disk->open_mutex once call backs from block devices to > the file system using the holder ops are supported. Move the