[f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-08-26 Thread wangzijie
Thread A -dquot_initialize -dqget -f2fs_dquot_acquire -v2_read_dquot -qtree_read_dquot -find_tree_dqentry -f2fs_quota_read -read_cache_page_gfp -do_read_cache_folio -fiemap_read_folio -folio_wait_locked_killable -receive SIGKILL : re

Re: [f2fs-dev] [PATCH v4 1/5] fs, block: refactor enum rw_hint

2024-08-26 Thread Kanchan Joshi
On 8/26/2024 11:14 PM, Bart Van Assche wrote: > On 8/26/24 10:06 AM, Kanchan Joshi wrote: >> Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint >> (in request) to use u8 data-type rather than this enum. > > That sounds fishy to me. Why to increase the size of this enum? Why to >

[f2fs-dev] [linux-next:fs-next] [f2fs] 96cfeb0389: INFO:task_blocked_for_more_than#seconds

2024-08-26 Thread kernel test robot
Hello, kernel test robot noticed "INFO:task_blocked_for_more_than#seconds" on: commit: 96cfeb0389530ae32ade8a48ae3ae1ac3b6c009d ("f2fs: fix to wait dio completion") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git fs-next [test failed on linux-next/master 1ca4237ad9ce29b0c66f

[f2fs-dev] [PATCH] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-08-26 Thread Julian Sun
Hi, all. Recently syzbot reported a bug as following: kernel BUG at fs/f2fs/inode.c:896! CPU: 1 UID: 0 PID: 5217 Comm: syz-executor605 Not tainted 6.11.0-rc4-syzkaller-00033-g872cf28b8df9 #0 RIP: 0010:f2fs_evict_inode+0x1598/0x15c0 fs/f2fs/inode.c:896 Call Trace: evict+0x532/0x950 fs/inode.c:

Re: [f2fs-dev] [PATCH 02/14] btrfs: convert get_next_extent_buffer() to take a folio

2024-08-26 Thread Josef Bacik
On Mon, Aug 26, 2024 at 05:56:01PM +0100, Matthew Wilcox wrote: > On Mon, Aug 26, 2024 at 10:13:01AM -0400, Josef Bacik wrote: > > On Fri, Aug 23, 2024 at 04:38:27PM +0100, Matthew Wilcox wrote: > > > On Fri, Aug 23, 2024 at 11:43:41AM +0930, Qu Wenruo wrote: > > > > 在 2024/8/23 07:55, Qu Wenruo 写道

[f2fs-dev] [PATCH] f2fs: prevent atomic file from being dirtied before commit

2024-08-26 Thread Daeho Jeong
From: Daeho Jeong Keep atomic file clean while updating and make it dirtied during commit in order to avoid unnecessary and excessive inode updates in the previous fix. Fixes: 4bf78322346f ("f2fs: mark inode dirty for FI_ATOMIC_COMMITTED flag") Signed-off-by: Daeho Jeong --- fs/f2fs/f2fs.h

Re: [f2fs-dev] [PATCH v4 1/5] fs, block: refactor enum rw_hint

2024-08-26 Thread Bart Van Assche via Linux-f2fs-devel
On 8/26/24 10:06 AM, Kanchan Joshi wrote: Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint (in request) to use u8 data-type rather than this enum. That sounds fishy to me. Why to increase the size of this enum? Why to reduce the ability of the compiler to perform type check

[f2fs-dev] [PATCH v4 1/5] fs, block: refactor enum rw_hint

2024-08-26 Thread Kanchan Joshi
Rename enum rw_hint to rw_life_hint. Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint (in request) to use u8 data-type rather than this enum. This is in preparation to introduce a new write hint type. Signed-off-by: Kanchan Joshi --- fs/buffer.c | 4 ++-- fs/f

[f2fs-dev] [PATCH v4 5/5] nvme: enable FDP support

2024-08-26 Thread Kanchan Joshi
Flexible Data Placement (FDP), as ratified in TP 4146a, allows the host to control the placement of logical blocks so as to reduce the SSD WAF. Userspace can send the data placement information using the write hints. Fetch the placement-identifiers if the device supports FDP. The incoming placeme

[f2fs-dev] [PATCH v4 4/5] sd: limit to use write life hints

2024-08-26 Thread Kanchan Joshi
From: Nitesh Shetty The incoming hint value maybe either life hint or placement hint. Make SCSI interpret only temperature-based write life hints. Signed-off-by: Nitesh Shetty Signed-off-by: Kanchan Joshi --- drivers/scsi/sd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[f2fs-dev] [PATCH v4 3/5] fcntl: add F_{SET/GET}_RW_HINT_EX

2024-08-26 Thread Kanchan Joshi
This is similar to existing F_{SET/GET}_RW_HINT but more generic/extensible. F_SET/GET_RW_HINT_EX take a pointer to a struct rw_hint_ex as argument: struct rw_hint_ex { __u8type; __u8pad[7]; __u64 val; }; With F_SET_RW_HINT_EX, the user passes the hint type and

[f2fs-dev] [PATCH v4 0/5] Write-placement hints and FDP

2024-08-26 Thread Kanchan Joshi
Current write-hint infrastructure supports 6 temperature-based data life hints. The series extends the infrastructure with a new temperature-agnostic placement-type hint. New fcntl codes F_{SET/GET}_RW_HINT_EX allow to send the hint type/value on file. See patch #3 commit description for the detail

[f2fs-dev] [PATCH v4 2/5] fcntl: rename rw_hint_* to rw_life_hint_*

2024-08-26 Thread Kanchan Joshi
F_GET/SET_RW_HINT fcntl handlers query/set write life hints. Rename the handlers/helpers to be explicit that write life hints are being handled. This is in preparation to introduce a new interface that supports more than one type of write hint. Signed-off-by: Kanchan Joshi --- fs/fcntl.c | 12 +

Re: [f2fs-dev] [PATCH 02/14] btrfs: convert get_next_extent_buffer() to take a folio

2024-08-26 Thread Matthew Wilcox
On Mon, Aug 26, 2024 at 10:13:01AM -0400, Josef Bacik wrote: > On Fri, Aug 23, 2024 at 04:38:27PM +0100, Matthew Wilcox wrote: > > On Fri, Aug 23, 2024 at 11:43:41AM +0930, Qu Wenruo wrote: > > > 在 2024/8/23 07:55, Qu Wenruo 写道: > > > > 在 2024/8/22 21:37, Matthew Wilcox 写道: > > > > > On Thu, Aug 22

Re: [f2fs-dev] [PATCH -next 00/14] btrfs: Cleaned up folio->page conversion

2024-08-26 Thread Josef Bacik
On Fri, Aug 23, 2024 at 05:15:22PM -0400, Josef Bacik wrote: > On Fri, Aug 23, 2024 at 03:50:51PM -0400, Josef Bacik wrote: > > On Thu, Aug 22, 2024 at 09:37:00AM +0800, Li Zetao wrote: > > > Hi all, > > > > > > In btrfs, because there are some interfaces that do not use folio, > > > there is page

Re: [f2fs-dev] [PATCH 02/14] btrfs: convert get_next_extent_buffer() to take a folio

2024-08-26 Thread Josef Bacik
On Fri, Aug 23, 2024 at 04:38:27PM +0100, Matthew Wilcox wrote: > On Fri, Aug 23, 2024 at 11:43:41AM +0930, Qu Wenruo wrote: > > 在 2024/8/23 07:55, Qu Wenruo 写道: > > > 在 2024/8/22 21:37, Matthew Wilcox 写道: > > > > On Thu, Aug 22, 2024 at 08:28:09PM +0930, Qu Wenruo wrote: > > > > > But what will ha