Re: [f2fs-dev] [PATCH 49/60] f2fs: Pass a folio to f2fs_is_compressed_page()

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/9/25 01:03, Matthew Wilcox (Oracle) wrote: > All callers now have a folio so pass it in. Also remove the test for > the private flag; it is redundant with checking folio->private for being > NULL. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/f2fs/compress.c | 14 ++ >

Re: [f2fs-dev] [PATCH v3] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/22/25 14:02, yohan.joung wrote: > read for the pinfile using Direct I/O do not wait for dio write. > > Signed-off-by: yohan.joung Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lis

[f2fs-dev] [PATCH v3] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

2025-07-21 Thread yohan.joung
read for the pinfile using Direct I/O do not wait for dio write. Signed-off-by: yohan.joung --- fs/f2fs/file.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4039ccb5022c..58a4d25eb08f 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/fi

Re: [f2fs-dev] [PATCH v2] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/22/25 13:20, yohan.joung wrote: > read for the pinfile using Direct I/O do not wait for dio write. > > Signed-off-by: yohan.joung > --- > fs/f2fs/file.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 4039ccb5022c..2b

[f2fs-dev] [PATCH v2] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

2025-07-21 Thread yohan.joung
read for the pinfile using Direct I/O do not wait for dio write. Signed-off-by: yohan.joung --- fs/f2fs/file.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4039ccb5022c..2b7e5c46c1ae 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/fi

Re: [f2fs-dev] [PATCH] f2fs: zone: wait for inflight dio completion, excluding pinned files

2025-07-21 Thread yohan.joung
>On 7/21/25 13:41, yohan.joung wrote: >> pinfile is excluded as it operates with direct I/O > >pinfile can use buffer IO as well? only considered direct I/O. I'll re-upload the pinfile considering buffered I/O Thanks > >Thanks, > >> >> Signed-off-by: yohan.joung >> --- >> fs/f2fs/file.c | 3 ++-

Re: [f2fs-dev] [PATCH] f2fs: zone: wait for inflight dio completion, excluding pinned files

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/21/25 13:41, yohan.joung wrote: > pinfile is excluded as it operates with direct I/O pinfile can use buffer IO as well? Thanks, > > Signed-off-by: yohan.joung > --- > fs/f2fs/file.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.

Re: [f2fs-dev] Compressed files & the page cache

2025-07-21 Thread Barry Song
On Mon, Jul 21, 2025 at 7:37 PM Qu Wenruo wrote: > > > > 在 2025/7/21 19:55, Jan Kara 写道: > > On Mon 21-07-25 11:14:02, Gao Xiang wrote: > >> Hi Barry, > >> > >> On 2025/7/21 09:02, Barry Song wrote: > >>> On Wed, Jul 16, 2025 at 8:28 AM Gao Xiang > >>> wrote: > [...] > >>> Given the difficulty o

Re: [f2fs-dev] [PATCH] f2fs: ignore valid ratio when free section count is low

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/19/25 06:04, Daeho Jeong wrote: > From: Daeho Jeong > > Otherwise F2FS will not do GC in background in low free section. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sou

Re: [f2fs-dev] [PATCH v2] f2fs: add gc_boost_gc_greedy sysfs node

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/19/25 05:50, Daeho Jeong wrote: > From: Daeho Jeong > > Add this to control GC algorithm for boost GC. > > Signed-off-by: Daeho Jeong > --- > v2: use GC_GREEDY instead of 1 > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 8 +++- > fs/f2fs/gc.c| 3 ++- >

Re: [f2fs-dev] [PATCH v2] f2fs: add gc_boost_gc_multiple sysfs node

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
On 7/19/25 05:40, Daeho Jeong wrote: > From: Daeho Jeong > > Add a sysfs knob to set a multiplier for the background GC migration > window when F2FS Garbage Collection is boosted. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Li

[f2fs-dev] [PATCH] fsck.f2fs: disable linear lookup by default

2025-07-21 Thread Chao Yu via Linux-f2fs-devel
As we know, Android is the only user of casefold feature, in casefolded directory, creating a filename w/ character has ignorable code points in buggy kernel v6.12 is a very rare case, we don't get any report that user can not access file w/ character has ignorable code points till now. Let's disa

Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid redundant clean nat entry move in lru list

2025-07-21 Thread Jaegeuk Kim via Linux-f2fs-devel
I think it'd be better to add a parameter like __lookup_nat_cache(for_dirty). On 07/18, wangzijie wrote: > __lookup_nat_cache follows LRU manner to move clean nat entry, when nat > entries are going to be dirty, no need to move them to tail of lru list. > > Signed-off-by: wangzijie > --- > fs/f

Re: [f2fs-dev] Compressed files & the page cache

2025-07-21 Thread Gao Xiang
On 2025/7/21 19:36, Qu Wenruo wrote: 在 2025/7/21 19:55, Jan Kara 写道: On Mon 21-07-25 11:14:02, Gao Xiang wrote: Hi Barry, On 2025/7/21 09:02, Barry Song wrote: On Wed, Jul 16, 2025 at 8:28 AM Gao Xiang wrote: [...] Given the difficulty of allocating large folios, it's always a good ide

Re: [f2fs-dev] Compressed files & the page cache

2025-07-21 Thread Gao Xiang
Hi Jan, On 2025/7/21 18:25, Jan Kara wrote: On Mon 21-07-25 11:14:02, Gao Xiang wrote: Hi Barry, On 2025/7/21 09:02, Barry Song wrote: On Wed, Jul 16, 2025 at 8:28 AM Gao Xiang wrote: ... ... high-order folios can cause side effects on embedded devices like routers and IoT devices, wh

Re: [f2fs-dev] Compressed files & the page cache

2025-07-21 Thread Qu Wenruo via Linux-f2fs-devel
在 2025/7/21 19:55, Jan Kara 写道: On Mon 21-07-25 11:14:02, Gao Xiang wrote: Hi Barry, On 2025/7/21 09:02, Barry Song wrote: On Wed, Jul 16, 2025 at 8:28 AM Gao Xiang wrote: [...] Given the difficulty of allocating large folios, it's always a good idea to have order-0 as a fallback. While I

Re: [f2fs-dev] Compressed files & the page cache

2025-07-21 Thread Jan Kara
On Mon 21-07-25 11:14:02, Gao Xiang wrote: > Hi Barry, > > On 2025/7/21 09:02, Barry Song wrote: > > On Wed, Jul 16, 2025 at 8:28 AM Gao Xiang > > wrote: > > > > > ... > > > > > > > ... high-order folios can cause side effects on embedded devices > > > like routers and IoT devices, which sti