Re: [f2fs-dev] [PATCH 2/4] f2fs: allow wrong configure dio to buffered write

2018-07-09 Thread Chao Yu
On 2018/7/10 4:41, Jaegeuk Kim wrote: > On 07/09, Chao Yu wrote: >> On 2018/7/7 5:09, Jaegeuk Kim wrote: >>> This fixes to support unaligned dio as buffered writes. >> >> Should we return -EINVAL as manual of write said: >> >> EINVAL fd is attached to an object which is unsuitable for writing; or

Re: [f2fs-dev] [PATCH 2/4] f2fs: allow wrong configure dio to buffered write

2018-07-09 Thread Jaegeuk Kim
On 07/09, Chao Yu wrote: > On 2018/7/7 5:09, Jaegeuk Kim wrote: > > This fixes to support unaligned dio as buffered writes. > > Should we return -EINVAL as manual of write said: > > EINVAL fd is attached to an object which is unsuitable for writing; or the > file > was opened with the O_DIRECT

Re: [f2fs-dev] [PATCH 2/4] f2fs: allow wrong configure dio to buffered write

2018-07-09 Thread Chao Yu
On 2018/7/7 5:09, Jaegeuk Kim wrote: > This fixes to support unaligned dio as buffered writes. Should we return -EINVAL as manual of write said: EINVAL fd is attached to an object which is unsuitable for writing; or the file was opened with the O_DIRECT flag, and either the address specified

[f2fs-dev] [PATCH 2/4] f2fs: allow wrong configure dio to buffered write

2018-07-06 Thread Jaegeuk Kim
This fixes to support unaligned dio as buffered writes. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index e66379961804..6e8e78bb64a7 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2425,7