On Mon, 2007-10-01 at 14:30 -0700, Andrew Morton wrote:
> On Mon, 1 Oct 2007 13:55:29 -0700 (PDT)
> Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> > On Sat, 29 Sep 2007, Andrew Morton wrote:
> >
> > > > atomic allocations. And with SLUB using higher order pages, atomic !0
> > > > order allocati
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 0079b2c..d8fb795 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
...
> +
> + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);
> if (IS_ERR(raw_inode))
> goto bad_inode;
Hmm, why don't you use the return valu
> diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
> index e45dbd6..c2f0a0d 100644
> --- a/fs/ext3/ialloc.c
> +++ b/fs/ext3/ialloc.c
> @@ -646,7 +646,7 @@ struct inode *ext3_orphan_get(struct super_block *sb,
> unsigned long ino)
> unsigned long block_group;
> int bit;
> struct b
And one more thing...
> diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
> index e45dbd6..c2f0a0d 100644
> --- a/fs/ext3/ialloc.c
> +++ b/fs/ext3/ialloc.c
> @@ -646,7 +646,7 @@ struct inode *ext3_orphan_get(struct super_block *sb,
> unsigned long ino)
> unsigned long block_group;
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 427f830..8bb63f2 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -682,9 +682,14 @@ struct inode *ext4_orphan_get(struct super_block *sb,
> unsigned long ino)
>* is a valid orphan (no e2fsck run on fs). Orphans also i
Zach Brown <[EMAIL PROTECTED]> wrote:
> /* haha, continuing the fine tradition of terrible names in this api.. */
> static inline void *PTR_PTR(void *err_ptr) {
> BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
> return err_ptr;
> }
How about ERR_CAST() instead? Or maybe CAST_ERR()?
Jan Kara <[EMAIL PROTECTED]> wrote:
> Hmm, why don't you use the return value from raw_inode? It can be
> either -EIO or -EINVAL if 'ino' was invalid...
Good point. Altered.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PRO
On Tue, 2007-10-02 at 13:32 +0100, David Howells wrote:
> Zach Brown <[EMAIL PROTECTED]> wrote:
>
> > /* haha, continuing the fine tradition of terrible names in this api.. */
> > static inline void *PTR_PTR(void *err_ptr) {
> > BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
> > return err_ptr;
>
Jan Kara <[EMAIL PROTECTED]> wrote:
> But if you 'goto out' in some branches, we loose the ext3_warning()
> which we probably don't want.
Ugh. Okay, I need to rework the changes to that function.
> > return ERR_PTR(-EACCES);
> Wouldn't here -EIO be more appropriate?
I w
Dave Kleikamp <[EMAIL PROTECTED]> wrote:
> Of course, the cast is unnecessary,
The cast is necessary as the argument is a const pointer and the return type
is not.
> and I'm sure you meant to return error:
Oops. Yes, I changed my mind and renamed the argument to be 'error', but
forgot to chang
Jan Kara <[EMAIL PROTECTED]> wrote:
> Same comments as for ext3 - I think you reversed ext4_test_bit() test
> and also the warning won't be issued in some cases which is wrong.
Same replies as for ext3 too. Blech.
You should find altered patches landing in your inbox if you'd care to inspect
After several years of helping tune file systems for normal (ATA/S-ATA)
drives, we have been doing some performance work on ext3 & reiserfs on
disk arrays.
One thing that jumps out is that the way we currently batch synchronous
work loads into transactions does really horrible things to perf
On Tue, 2007-10-02 at 14:24 +0100, David Howells wrote:
> Dave Kleikamp <[EMAIL PROTECTED]> wrote:
>
> > Of course, the cast is unnecessary,
>
> The cast is necessary as the argument is a const pointer and the return type
> is not.
Ah yes. I stand corrected.
--
David Kleikamp
IBM Linux Techno
[PATCH]: Fill the size of pipes
Instead of reporting 0 in size when stating() a pipe, we give the number of
queued bytes. This might avoid using ioctl(FIONREAD) to get this information.
References and derived from: http://lkml.org/lkml/2007/4/2/138
Cc: Eric Dumazet <[EMAIL PROTECTED]>
Signed-off
[PATCH]: Fill the size of FIFOs
Instead of reporting 0 in size when stating() a pipe, we give the number of
queued bytes. This might avoid using ioctl(FIONREAD) to get this information.
References: http://lkml.org/lkml/2007/4/2/138
Cc: Eric Dumazet <[EMAIL PROTECTED]>
Signed-off-by: Jan Engelhar
Add %S_IWUGO bit for files on ISO-9660 filesystems without RockRidge
extensions. This allows one to modify the files right after copying,
without having to do an extra recursive chmod if `cp -p` or
`rsync -p` is used.
References: http://lkml.org/lkml/2007/4/1/164
Signed-off-by: Jan Engelhardt <[E
On Tuesday 02 October 2007 07:01, Christoph Lameter wrote:
> On Sat, 29 Sep 2007, Peter Zijlstra wrote:
> > On Fri, 2007-09-28 at 11:20 -0700, Christoph Lameter wrote:
> > > Really? That means we can no longer even allocate stacks for forking.
> >
> > I think I'm running with 4k stacks...
>
> 4k st
On Tuesday 02 October 2007 06:50, Christoph Lameter wrote:
> On Fri, 28 Sep 2007, Nick Piggin wrote:
> > I thought it was slower. Have you fixed the performance regression?
> > (OK, I read further down that you are still working on it but not
> > confirmed yet...)
>
> The problem is with the weird
18 matches
Mail list logo
